Commit graph

5273 commits

Author SHA1 Message Date
Ray Speth
930bcceddc Clean up formatting of SpeciesThermoInterpType 2014-10-15 02:02:46 +00:00
Harry Moffat
e5c3377dd2 Changed the name of a few internal variables. 2014-10-10 01:40:40 +00:00
Ray Speth
b50ab99326 [Test] Fix fileLog class used in DH_graph_1
The class was missing the implementation of writeendl, which caused the
base class method to be called, occasionally leading to confusing test failures.

Not setting the mode of the output file caused it not to be automatically created,
so the log file usually wasn't even being written.
2014-10-08 16:54:55 +00:00
Ray Speth
044235c065 [SCons] Remove unnecessary uses of pjoin 2014-10-08 16:54:49 +00:00
Ray Speth
43f022384c Add version of installVPThermoForSpecies without unused arguments
Deprecate the old version of SpeciesThermoFactory::installVPThermoForSpecies.
2014-10-08 16:54:44 +00:00
Ray Speth
c4a5f2667f Remove CTML_VERSION macros
CTML_VERSION_1_4_1 was never used, and defining CTML_VERSION_1_4 broke reading
values written by the addInteger and addFloat functions with the getInteger and
getFloat functions, respectively.
2014-10-08 16:54:42 +00:00
Ray Speth
0db18ad0b1 [SCons/Test] Re-run tests if shared library changes 2014-10-08 16:54:39 +00:00
Ray Speth
17c3b019c0 [Kinetics] Deprecate unused methods for writing hard-coded mechanisms 2014-10-08 16:54:35 +00:00
Ray Speth
609a7e07ac [Kinetics] Deprecate unused methods of rate coefficient implementations 2014-10-08 16:54:31 +00:00
Ray Speth
c31aadc57f [Doc] Give better examples for using 'const_cp' 2014-10-08 16:54:26 +00:00
Ray Speth
4457b4297c [Doc] Describe syntax for specifying coverage dependencies 2014-10-08 16:54:21 +00:00
Ray Speth
4fe752f5f2 [Kinetics] Fix calculation of coverage-dependent reaction rates
The formula used was not consistent with the standard formulation for
coverage-dependent reaction rates, which uses 10 as the base for the
temperature-independent term with the coverage in the exponential (see
Eq. 11.113 of Kee et al.).

The impact of this change should be minor, as most coverage-dependent reaction
rates appear not to use this term of the parameterization.
2014-10-08 16:54:18 +00:00
Ray Speth
b1e89a09a8 [Doc] Fix errors in NASA9 formula documentation
Also, remove duplicate (erroneous) documentation from Nasa9PolyMultiTempRegion
and replace this with a reference to the docs for Nasa9Poly1.
2014-10-08 16:54:14 +00:00
Ray Speth
f58fb95404 [Doc] Fix version number shown in Doxygen documentation 2014-10-08 16:54:09 +00:00
Bryan W. Weber
9ed87e857c [Cython] Allow None when setting the quality of a PureFluid
Allow None as an option for the quality as well as the
temperature and pressure when setting the state of a PureFluid.
Completes r3213.
2014-10-08 12:42:15 +00:00
Bryan W. Weber
7c60182142 Allow None when setting the state of a PureFluid
Allow None as an option when setting the temperature and quality or
pressure and quality of a PureFluid. This mimics similar functionality
for Solutions.
2014-10-08 12:37:41 +00:00
Ray Speth
5624794faf Remove unusable Adsorbate::install method
This method shouldn't exist, since it's not part of the base class
(SpeciesThermoInterpType) interface.
2014-10-03 22:15:11 +00:00
Ray Speth
55fab6ca83 Deprecate unused return value of importPhase 2014-10-03 22:15:08 +00:00
Ray Speth
6d4271fdfe [Test] Improve visibility of total test suite failures
Treat crashes when running the GTest test programs and the Python test suite as
being more severe than individual test failures.
2014-10-03 22:15:06 +00:00
Ray Speth
a5149ae665 [1D] Reduce default minimum grid size
The new value is OK even for high pressure flames - it is less than the mean
free path in air at 100 bar and 300 K.
2014-10-03 22:15:03 +00:00
Ray Speth
4910b1bc1c Fix compilation with Visual Studio 2013
Fixes regression introduced in r3125.

Resolves Issue 240.
2014-10-03 16:48:21 +00:00
Ray Speth
787c90adeb [Thermo] Make header files for SpeciesThermoInterpType descendants public 2014-10-03 01:45:58 +00:00
Ray Speth
5b1b08849c Additional uses for getValue with default value 2014-10-03 01:45:54 +00:00
Ray Speth
a74fda8ad2 Introduce 'getValue' to avoid making std::map members mutable 2014-10-03 01:45:49 +00:00
Ray Speth
91f3a2b073 Fix statements that called the assignment operator twice 2014-10-03 01:45:41 +00:00
Ray Speth
ceeaaecae7 [Test] fix some size_t warnings 2014-10-03 01:45:38 +00:00
Ray Speth
23921c7889 [Test] Run 'appdelete' at end of GTest tests
This makes it easier to find memory leaks when using Valgrind by suppressing
false positives associated with data cached by Cantera.
2014-10-01 17:52:28 +00:00
Ray Speth
ab4813c592 [Test] Fix memory leaks in CtiConversionTest and ChemkinConversionTest 2014-10-01 17:52:26 +00:00
Ray Speth
afe9ccb03e Remove unnecessary checks before deleting pointers 2014-10-01 17:52:23 +00:00
Ray Speth
1a5f75dd2d [Test] Use Cantera shared library for tests, when possible
On Linux systems, link tests against the Cantera shared library, rather than the
static library to reduce the size of the compiled test suite. This saves over 1
GB of disk space when compiling with debug symbols enabled, and also reduces the
run time of the test suite.

This does not work on Windows, where the shared library only exports the Cantera
C interface.
2014-10-01 17:52:21 +00:00
Ray Speth
4544fd3392 [Test] Build tests with optimization disabled
Compiling the tests takes longer than running them, so it actually saves time to
compile the tests with optimizations disabled.
2014-10-01 17:52:18 +00:00
Ray Speth
b0085eb58e [CTI] Check for correct number of coverage parameters
This detects errors such as providing two sets of coverage parameters as a
single list, rather than as a list with separate entries for each set of
coverage parameters.
2014-09-29 19:13:21 +00:00
Ray Speth
c0dc7bb922 [SCons] Setting 'msvc_version' implies 'toolchain=msvc' 2014-09-29 19:13:18 +00:00
Ray Speth
5c26f7b003 [Test] Preliminary tests for constructing a phase without an input file 2014-09-27 00:09:16 +00:00
Ray Speth
79461c34e8 [Thermo] Add default value for 'id' argument of 'newPhase' 2014-09-27 00:09:11 +00:00
Ray Speth
4baccc732c [Thermo] Simplify interface for adding elements to a Phase
Phase::addElements(string name, ...) is the single entry point for adding
elements. It always perform the uniqueness check, and can do the extra
additional work required to add elements to a phase that already has species,
removing the need for "freezing" the phase's elements. Parsing the XML tree for
elements is now handled in "installElements". The variant element-adding methods
are deprecated.
2014-09-27 00:09:05 +00:00
Ray Speth
473827a8a6 [Thermo] Check to make sure parameterizations are of the correct type 2014-09-27 00:09:02 +00:00
Ray Speth
1cb688150e [Thermo] Fix SpeciesThermoDuo to pass on the parameterization type 2014-09-27 00:08:59 +00:00
Ray Speth
a8f4c76097 [Thermo] Check to make sure thermo data is installed for all species 2014-09-27 00:08:54 +00:00
Ray Speth
89888e6697 [Thermo] Fix derived classes to always call parent's initThermo()
Remove unnecessary reimplementations that only called the parent's method.
2014-09-27 00:08:46 +00:00
Ray Speth
f46b61a740 Make "string&" arguments "const string&"
This way, these functions can accept constant strings, including string
literals.
2014-09-26 13:45:12 +00:00
Ray Speth
53102e8d70 [Test] Convert 'fracCoeff' test to GTest 2014-09-26 13:45:06 +00:00
Ray Speth
992782d1e2 [Test] Show test class and test name for failing GTest tests 2014-09-26 13:45:02 +00:00
Ray Speth
f3fc8f2ce2 [Thermo] Use findXMLPhase in initThermoFile
This allows many constructors which take a filename to work with CTI files
directly, and to make use of the parsed XML cache.
2014-09-26 13:44:57 +00:00
Ray Speth
337c573958 [Test] Move NASA9poly test to GTest test suite 2014-09-24 23:18:01 +00:00
Ray Speth
5ecdc1a4e1 [Equil] Deprecate VCS 'UseCanteraCalls' flag
When this flag is removed, the behavior will be as if the flag's value were
'true'.
2014-09-24 23:17:58 +00:00
Ray Speth
5298f703c3 [Doc] Add note about running 'scons install' as Administrator on Windows 2014-09-24 23:17:55 +00:00
Ray Speth
ca68fbc075 Rename Cabinet member variables to avoid using reserved identifiers
Names containing double underscores are reserved for the C++ implementation.
2014-09-24 23:17:50 +00:00
Ray Speth
de9928977c [ck2cti] Preserve mechanism header comment block 2014-09-24 23:17:47 +00:00
Ray Speth
a3bba51f06 [ck2cti] Preserve comments in the REACTIONS section 2014-09-24 23:17:44 +00:00