Fix statements that called the assignment operator twice

include/cantera/thermo/MetalPhase.h

@@ -28,7 +28,7 @@ public:
     MetalPhase() {}
 
     MetalPhase(const MetalPhase& right) {
-        *this = operator=(right);
+        *this = right;
     }
 
     MetalPhase& operator=(const MetalPhase& right) {

include/cantera/thermo/SemiconductorPhase.h

@@ -33,7 +33,7 @@ public:
     SemiconductorPhase(std::string infile, std::string id="");
 
     SemiconductorPhase(const SemiconductorPhase& right) {
-        *this = operator=(right);
+        *this = right;
     }
 
     SemiconductorPhase& operator=(const SemiconductorPhase& right) {

include/cantera/thermo/SimpleThermo.h

@@ -72,7 +72,7 @@ public:
         /*
          * Call the assignment operator
          */
-        *this = operator=(right);
+        *this = right;
     }
 
     //! Assignment operator

include/cantera/thermo/SpeciesThermoMgr.h

@@ -63,7 +63,7 @@ public:
      * @param right Object to be copied
      */
     SpeciesThermoDuo(const SpeciesThermoDuo& right) {
-        *this = operator=(right);
+        *this = right;
     }
 
     //! Assignment operator

src/numerics/ResidJacEval.cpp

@@ -25,7 +25,7 @@ ResidJacEval::ResidJacEval(doublereal atol) :
 ResidJacEval::ResidJacEval(const ResidJacEval& right) :
     ResidEval()
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 ResidJacEval& ResidJacEval::operator=(const ResidJacEval& right)

src/thermo/ConstDensityThermo.cpp

@@ -22,7 +22,7 @@ ConstDensityThermo::ConstDensityThermo()
 
 ConstDensityThermo::ConstDensityThermo(const ConstDensityThermo& right)
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 ConstDensityThermo& ConstDensityThermo::operator=(const ConstDensityThermo& right)

src/thermo/Elements.cpp

@@ -233,7 +233,7 @@ Elements::Elements(const Elements& right) :
     m_elementsFrozen(false),
     numSubscribers(0)
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 Elements& Elements::operator=(const Elements& right)

src/thermo/FixedChemPotSSTP.cpp

@@ -126,7 +126,7 @@ FixedChemPotSSTP::FixedChemPotSSTP(const std::string& Ename, doublereal val) :
 FixedChemPotSSTP::FixedChemPotSSTP(const FixedChemPotSSTP&  right) :
     SingleSpeciesTP()
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 FixedChemPotSSTP&

src/thermo/LatticePhase.cpp

@@ -30,7 +30,7 @@ LatticePhase::LatticePhase(const LatticePhase& right) :
     m_speciesMolarVolume(0),
     m_site_density(0.0)
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 LatticePhase& LatticePhase::operator=(const LatticePhase& right)

src/thermo/LatticeSolidPhase.cpp

@@ -37,7 +37,7 @@ LatticeSolidPhase::LatticeSolidPhase(const LatticeSolidPhase& right) :
     theta_(0),
     tmpV_(0)
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 LatticeSolidPhase&

src/thermo/MineralEQ3.cpp

@@ -75,7 +75,7 @@ MineralEQ3::MineralEQ3(XML_Node& xmlphase, const std::string& id_) :
 MineralEQ3::MineralEQ3(const MineralEQ3&  right) :
     StoichSubstanceSSTP()
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 MineralEQ3&

src/thermo/MolalityVPSSTP.cpp

@@ -53,7 +53,7 @@ MolalityVPSSTP::MolalityVPSSTP(const MolalityVPSSTP& b) :
     m_Mnaught(b.m_Mnaught),
     m_molalities(b.m_molalities)
 {
-    *this = operator=(b);
+    *this = b;
 }
 
 MolalityVPSSTP& MolalityVPSSTP::operator=(const MolalityVPSSTP& b)

src/thermo/MolarityIonicVPSSTP.cpp

@@ -77,7 +77,7 @@ MolarityIonicVPSSTP::MolarityIonicVPSSTP(const MolarityIonicVPSSTP& b) :
     numPassThroughSpecies_(0),
     neutralPBindexStart(0)
 {
-    *this = operator=(b);
+    *this = b;
 }
 
 MolarityIonicVPSSTP& MolarityIonicVPSSTP::operator=(const MolarityIonicVPSSTP& b)

src/thermo/NasaThermo.cpp

@@ -24,7 +24,7 @@ NasaThermo::NasaThermo(const NasaThermo& right) :
     m_thigh_min(1.e30),
     m_p0(-1.0),
     m_ngroups(0) {
-    *this = operator=(right);
+    *this = right;
 }
 
 NasaThermo& NasaThermo::operator=(const NasaThermo& right)

src/thermo/PseudoBinaryVPSSTP.cpp

@@ -51,7 +51,7 @@ PseudoBinaryVPSSTP::PseudoBinaryVPSSTP(const PseudoBinaryVPSSTP& b) :
     cationPhase_(0),
     anionPhase_(0)
 {
-    *this = operator=(b);
+    *this = b;
 }
 
 PseudoBinaryVPSSTP& PseudoBinaryVPSSTP::operator=(const PseudoBinaryVPSSTP& b)

src/thermo/ShomateThermo.h

@@ -85,7 +85,7 @@ public:
         m_thigh_min(1.e30),
         m_p0(-1.0),
         m_ngroups(0) {
-        *this = operator=(right);
+        *this = right;
     }
 
     //! Assignment Operator

src/thermo/SingleSpeciesTP.cpp

@@ -30,7 +30,7 @@ SingleSpeciesTP::SingleSpeciesTP(const SingleSpeciesTP& right):
     m_press(OneAtm),
     m_p0(OneAtm)
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 SingleSpeciesTP& SingleSpeciesTP::operator=(const SingleSpeciesTP& right)

src/thermo/StoichSubstance.cpp

@@ -21,7 +21,7 @@ StoichSubstance::StoichSubstance(const StoichSubstance& right) :
     m_press(OneAtm),
     m_p0(OneAtm)
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 StoichSubstance& StoichSubstance::operator=(const StoichSubstance& right)

src/thermo/StoichSubstanceSSTP.cpp

@@ -73,7 +73,7 @@ StoichSubstanceSSTP::StoichSubstanceSSTP(XML_Node& xmlphase, const std::string&
 StoichSubstanceSSTP::StoichSubstanceSSTP(const StoichSubstanceSSTP&  right) :
     SingleSpeciesTP()
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 StoichSubstanceSSTP&
@@ -324,7 +324,7 @@ electrodeElectron::electrodeElectron(XML_Node& xmlphase, const std::string& id_)
 electrodeElectron::electrodeElectron(const electrodeElectron&  right) :
     StoichSubstanceSSTP()
 {
-    *this = operator=(right);
+    *this = right;
 }
 
 electrodeElectron&

src/thermo/SurfPhase.cpp

@@ -415,7 +415,7 @@ EdgePhase::EdgePhase(const EdgePhase& right) :
     SurfPhase(right.m_n0)
 {
     setNDim(1);
-    *this = operator=(right);
+    *this = right;
 }
 
 EdgePhase& EdgePhase::operator=(const EdgePhase& right)

src/thermo/ThermoPhase.cpp

@@ -51,7 +51,7 @@ ThermoPhase::ThermoPhase(const ThermoPhase& right)  :
     /*
      * Call the assignment operator
      */
-    *this = operator=(right);
+    *this = right;
 }
 
 ThermoPhase& ThermoPhase::operator=(const ThermoPhase& right)