Ray Speth
ee95c60813
Simplify error handling to eliminate need for global error stack
...
All of the functions for manipulating the global error stack
(CanteraError::save, setError, showErrors, etc.) are deprecated. The ability to
store an error is retained only for use in the C and Fortran interfaces so that
the last error message can be retrieved after a function returns an error code.
2015-11-16 19:50:55 -05:00
Ray Speth
4382ae6c85
Clean up comments in Thermo class source files
2015-11-09 17:34:46 -05:00
Ray Speth
71bb73b728
Eliminate unnecessary calles to std::string.c_str()
2015-10-14 18:45:22 -04:00
Ray Speth
caf9c6f062
Use cppformat in ThermoPhase::report and overrides
2015-10-14 18:45:22 -04:00
Ray Speth
7bcbbaafd9
[Thermo] Use consistent implementation for convenience constructors
...
The constructor with the signature (inputFile, [id]) just calls initThermoFile.
The constructor with the signature (phase XML node, [id]) just calls importPhase
(note that the id argument is unused, since the correct XML node must already be
given).
2015-08-05 12:34:22 -04:00
Ray Speth
ceefc5ecb0
Consistently use ThermoPhase::RT()
2015-08-02 23:06:16 -04:00
Ray Speth
acdf9cf0ed
Clean up interstitial whitespace
...
Remove extra space around operators, between words, etc.
2015-08-02 23:06:16 -04:00
Ray Speth
e4c45b6429
General whitespace cleanup
...
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
2015-08-02 23:06:15 -04:00
Ray Speth
f219b49e63
Remove unnecessary newlines in function signatures
2015-08-02 23:06:15 -04:00
Ray Speth
341b137766
[Doc] Capitalize proper nouns and acronyms
2015-05-25 20:58:44 -04:00
Ray Speth
09ce99dc83
[Thermo] Eliminate redundant assignment of m_kk
...
m_kk is automatically set as species are added to a phase.
2015-02-20 23:43:12 +00:00
Ray Speth
42e7061bd8
[Thermo] Remove unnecessary counter variables
...
These counter variables just stored the length of another std::vector
member variable.
2015-02-20 23:43:04 +00:00
Ray Speth
79cf2dcba7
Remove empty comment blocks
2015-02-20 00:11:05 +00:00
Ray Speth
7acf0378c6
[Thermo] Improve usage of local variables
...
Also eliminate some unnecessary temporary variables.
2015-02-12 04:04:18 +00:00
Ray Speth
b8a99b4b83
Remove unnecessary explicit calls to default constructors
2015-01-22 00:04:12 +00:00
Ray Speth
91f3a2b073
Fix statements that called the assignment operator twice
2014-10-03 01:45:41 +00:00
Ray Speth
ea3f74eb27
[Thermo] 'report' only prints species with non-trivial mole fractions
...
The threshold for printing species is a new, optional parameter to the
'report' function. If any species are excluded, the total number of
minor species and their aggregate mass and mole fraction are printed.
2014-06-03 16:54:15 +00:00
Ray Speth
54ded64e4b
Miscellaneous whitespace cleanup
2014-05-08 23:01:12 +00:00
Ray Speth
2a9ab96609
Use NotImplementedError instead of 'err' member functions
2014-05-06 14:39:13 +00:00
Ray Speth
3530050dc4
[Thermo] Remove redundant overrides of ThermoPhase::eosType()
2014-03-28 23:12:53 +00:00
Ray Speth
95eb7ab3ba
Remove newline after '::' in member function definitions
...
This inconsistency makes it hard to directly search the code for a specific
member function definition.
2014-03-24 04:03:09 +00:00
Ray Speth
d253fc0d63
Eliminate redundant standard library includes
2013-06-05 17:08:13 +00:00
Ray Speth
0a059d406a
Eliminated unnecessary empty destructors from derived classes
...
See http://www.parashift.com/c++-faq-lite/virtual-dtors.html
2013-04-29 18:04:23 +00:00
Ray Speth
ee74c80afc
Fixed a number of "shadowed variable" compiler warnings
2013-04-18 22:08:36 +00:00
Ray Speth
da33cc66c3
Cleaned up Doxygen docs for class VPStandardStateTP and descendants
2013-02-14 01:02:34 +00:00
Ray Speth
7da738d238
Re-applied consistent formatting to trunk
...
Applied using: astyle -n --style=kr --add-brackets --indent=spaces=4
--indent-col1-comments --unpad-paren --pad-header --align-pointer=type
--lineend=linux
2013-02-07 23:40:59 +00:00
Ray Speth
83097b3860
Consolidated definitions of repeatedly-used constants
...
"MIN_X" and "TINY" are replaced by "Tiny". "xxSmall" is replaced with
"SmallNumber".
2013-01-11 22:55:46 +00:00
Ray Speth
94d08f1d5e
Removed unnecessary casts from object duplication functions
2012-10-24 15:45:33 +00:00
Ray Speth
1d19803885
Pass "const std::string&" instead of "std::string" when possible
2012-10-24 15:42:51 +00:00
Ray Speth
f718caef91
Removed constructPhaseFile and constructPhaseXML methods from MolarityIonicVPSSTP
2012-08-08 22:16:42 +00:00
Ray Speth
0f04aaf0be
Updated documentation to resolve some Doxygen warnings
2012-06-14 21:06:30 +00:00
Ray Speth
d16f70ab44
Fixed some spelling issues
2012-04-04 18:44:24 +00:00
Ray Speth
8ea4ae728a
Moved a few standard library includes to more local scopes
2012-03-23 22:16:04 +00:00
Ray Speth
78a093b485
Folded class Constituents into class Phase
2012-03-09 22:56:11 +00:00
Ray Speth
3bff32dd55
Fixed problems that generated warnings with the Intel compiler
2012-03-07 00:51:13 +00:00
Ray Speth
54efbaa320
Rewrote exception handling to be more general and more explicit
...
CanteraError inerits from std:exception, so now it has a what() method
that is used to print a message describing the exception. Adding an
exception to the Cantera error stack now requires explicitly calling
the .save() method.
2012-03-05 20:45:56 +00:00
Ray Speth
236756fbf0
Removed rogue tabs in the C++ source code
2012-02-27 18:15:02 +00:00
Ray Speth
437294ae00
Removed previously-deprecated array_fp typedef
2012-02-22 00:16:22 +00:00
Ray Speth
35429de71c
Fixed a bunch of spelling errors in the documentation and comments
2012-02-21 16:04:09 +00:00
Ray Speth
fe8a5d49a8
Use std::min and std::max instead of homegrown alternatives
2012-02-21 16:03:32 +00:00
Ray Speth
e8b04fb2b4
Fixed numerous compiler warnings from MSVC
2012-02-17 20:29:10 +00:00
Ray Speth
9bc4a261c7
Fixed a bunch of GCC warnings
2012-02-15 20:28:08 +00:00
Ray Speth
a310345b9e
Updated #includes to reflect new header file locations
2012-02-12 02:44:14 +00:00
Ray Speth
2528df0f75
Reorganized source tree structure
...
These changes make it unnecessary to copy header files around during
the build process, which tends to confuse IDEs and debuggers. The
headers which comprise Cantera's external C++ interface are now in
the 'include' directory.
All of the samples and demos are now in the 'samples' subdirectory.
2012-02-12 02:27:14 +00:00