Ray Speth
d4f9717c1c
[Input] Fix handling of global Motz-Wise flag in cti2yaml
2019-11-09 11:53:16 -05:00
Bryan W. Weber
efb246d73a
[cti2yaml] Add failing test of Motz-Wise option
...
The global Motz-Wise option is not added to the phase specification
2019-11-09 11:53:16 -05:00
Ingmar Schoegl
21de00c549
[Kinetics] update unit tests to probe falloff type
2019-11-08 15:18:26 -05:00
Ingmar Schoegl
e2bfba328c
[Kinetics] deprecate magic numbers for falloff reactions
2019-11-08 15:18:26 -05:00
Ingmar Schoegl
58063b498a
[Kinetics] deprecate magic number types in RxnRates.h
2019-11-08 15:18:26 -05:00
Ingmar Schoegl
91c7bf14d7
[Base] finalize introduction of Solution object in C++ layer
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
cf315f7c5e
[oneD] change thermo type passed to StFlow constructor
...
- allow for 'ThermoPhase`, and cast to 'IdealGasPhase' internally
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
2a9554c134
[Base] consolidate shared_ptr access in Solution
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
58fc8f770c
Replace doublereal by double
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
d730b4c5e8
Deprecate (previously) used convenience wrapper classes
...
- IdealGasMix.h and Interface.h
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
eda3b2fbfb
Deprecate (previously) unused convenience wrapper classes
...
- Edge.h, IncompressibleSolid.h and Metal.h
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
9f6cba3c33
[samples] replace convenience wrapper classes by C++ Solution
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
a0350925a7
[test_problems] replace convenience wrapper classes by C++ Solution
...
- Remove dependence on IdealGasMix.h
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
40ae5b5fb5
[Base] implement initialization of C++ Solution from input files
...
- implement constructor that loads ThermoPhase, Kinetics, and Transport
from input files (wrapping factory class methods)
- logic for selection of transport manager follows Python object
- add convenience methods to type-cast frequently used classes
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
43d02e95e3
[Scons] prevent installation to source directory
2019-11-07 10:35:53 -05:00
Ray Speth
ce47733c42
[Test] Fix coverage consistency issue in getMixDiffCoeffsMole
2019-11-02 15:43:05 -04:00
Ray Speth
6dbcd94029
[Doc] Fix alphabetization of thermo and species thermo models
2019-11-02 10:42:35 -04:00
Ray Speth
71ba021467
Add sticking coefficients to CTI API docs
2019-11-02 10:42:35 -04:00
CyberDrudge
65f7b16f01
Implemented function to list data files
...
Update function to list data files
Follow Style Guidelines
Add doc for listing files
2019-11-01 22:18:59 -04:00
Ray Speth
a5b28ba799
[Input] Fix conversion of Ion transport in cti2yaml
2019-11-01 22:16:45 -04:00
Ray Speth
bddb339198
[Input] Fix handling of skip_undeclared_third_bodies in cti2yaml
2019-11-01 22:16:45 -04:00
Bryan W. Weber
69393e9307
[cti2yaml] Add failing ch4_ion test
2019-11-01 22:16:45 -04:00
Ingmar Schoegl
eb02fa9726
Update issue templates
...
Fixes #698 . Further:
- Add SUPPORT.md
- Move community help files to .github folder
2019-11-01 22:16:06 -04:00
Ingmar Schoegl
54c12fc59c
[Thermo] add support for concentration string in findIsomers
2019-10-29 21:26:57 -04:00
Ingmar Schoegl
4f42164443
[Thermo] add unit tests for add_species_alias and find_isomers
2019-10-29 21:26:57 -04:00
Ingmar Schoegl
3ef99f966c
[Thermo] add functions findIsomer/addSpeciesAlias
2019-10-29 21:26:57 -04:00
Ingmar Schoegl
a85396ef11
[Input/Scons] make gri30 consistent with latest online version
...
Updated version keeps input and thermo separate, which requires minor
changes in the build scripts.
2019-10-29 21:00:36 -04:00
Ingmar Schoegl
1e01054bf5
[Thermo] eliminate SolutionArray._extra_arrays
2019-10-25 15:06:31 -04:00
Ingmar Schoegl
cd67962004
[Thermo] add ability to sort SolutionArray objects
2019-10-25 15:06:31 -04:00
Steven DeCaluwe
f02ca90e2c
Updating citation info for li ion battery example.
2019-10-24 22:16:52 -04:00
Ingmar Schoegl
76901b7f50
[ReactorNet] improve handling of max_time_step
...
* implement ReactorNet::maxTimeStep to allow for external queries
* implement getter/setter for property ReactorNet.max_time_step
* deprecate ReactorNet.set_max_time_step
2019-10-24 20:31:54 -04:00
Ingmar Schoegl
3b7eb0dc8d
[Scons] use consistent phase names (CTI/XML vs YAML)
2019-10-23 21:39:53 -04:00
Ray Speth
a221c632f4
[Test] Add tests for ck2yaml
2019-10-23 13:54:59 -04:00
Ray Speth
5cca4f22df
[Input] Preserve comment after last reaction in ck2yaml
2019-10-23 13:54:59 -04:00
Ray Speth
8665eda3c1
[Input] Fix error message for unrecognized section in ck2yaml
2019-10-23 13:54:59 -04:00
Ray Speth
a085bc1f43
[Input] Check that all species have thermo before writing YAML file
2019-10-23 13:54:59 -04:00
Ray Speth
6c8adf47b3
[Input] Normalize YAML reaction equation for Chebyshev reactions
...
Fix the reaction equation to always include the (+M). Previously, if the (+M)
was omitted, an invalid reaction string was generated.
2019-10-23 13:54:59 -04:00
Ingmar Schoegl
ee41824b1e
[SpeciesThermo] address review comments
2019-10-23 13:53:56 -04:00
Ingmar Schoegl
650db397b2
[SpeciesThermo] load piecewise-Gibbs from YAML
2019-10-23 13:53:56 -04:00
Ingmar Schoegl
d43774e721
[SpeciesThermo] enable cython constructors for Nasa9PolyMultiTempRegion
...
Further:
* Add unit tests for ShomatePoly2 and Mu0Poly
2019-10-23 13:53:56 -04:00
Ingmar Schoegl
cb0e1f1509
[SpeciesThermo] add unit tests
2019-10-23 13:53:56 -04:00
Ingmar Schoegl
cf8d2efa09
[SpeciesThermo] assign nCoeffs in C++ layer
2019-10-23 13:53:56 -04:00
Ingmar Schoegl
5ab15e15ce
[SpeciesThermo] add initial Cython classes
...
- n_coeffs remains to be addressed (needed: number of zones)
2019-10-23 13:53:56 -04:00
Ingmar Schoegl
dc66407cf2
[Thermo] address code review comments
2019-10-23 13:45:29 -04:00
Ingmar Schoegl
63da219947
[Thermo] deprecate name/id support in Phase::speciesIndex
2019-10-23 13:45:29 -04:00
Ingmar Schoegl
7c08e17f08
[Thermo] deprecate Phase::id and Phase::setID
...
* Merge usage of 'id' and 'name' in the context of Phase objects
* Raise deprecation warnings for Phase::id and Phase::setID
2019-10-23 13:45:29 -04:00
Ingmar Schoegl
6e5d45273a
[Thermo] replace 'phase_id' by 'name'
...
* 'name' corresponds to the YAML entry
* rename Solution keyword 'phaseid' to 'name' (instead of 'phase_id')
* rename ck2yaml argument '--id' to '--name' (instead of '--phase-id')
* ensure that C++ Phase::m_id is always the same as Phase::m_name
2019-10-23 13:45:29 -04:00
Ingmar Schoegl
5928d63746
[Thermo] address discussion and review comments
...
* rename C++ object to 'Solution' (from 'SolutionBase')
* remove 'phaseID' from 'Solution' ('id' remains assigned to 'Phase')
* remove 'type' from C++ object (no polymorphism anticipated)
* assign 'name' to 'Solution' (link back from 'Phase' until deprecated)
* clarify 'phase' as 'phase_id' in Python interface
* address various feedback in review comments
2019-10-23 13:45:29 -04:00
Ingmar Schoegl
b5e4f25454
[Input] rename --id to --phase in ck2yaml options
...
The option --phase is consistent with the resulting yaml entry in 'phases'.
The --id option is still supported, with a warning being issued.
2019-10-23 13:45:29 -04:00
Ingmar Schoegl
3bf09fbd7f
[Base] rename Base.h/.cpp to SolutionBase.h/.cpp
2019-10-23 13:45:29 -04:00