Ray Speth
4887775109
Eliminate unnecessary counter member variables
2015-12-01 15:54:55 -05:00
Ray Speth
f5ff849b47
Replace std::copy with simpler direct assignment where possible
2015-11-12 17:35:30 -05:00
Ray Speth
34ff39e3df
Clean up Doxygen docs and comments in OneD classes
2015-11-12 11:41:34 -05:00
Ray Speth
0647823ada
Replace DATA_PTR macro with calls to data()
2015-10-17 18:58:50 -04:00
Ray Speth
a945ef2c23
Make use of initializer lists where appropriate
2015-10-17 18:58:50 -04:00
Ray Speth
c3a16ec1fb
Update AssertThrowMsg and AssertFinite to use cppformat
2015-10-14 18:45:23 -04:00
Ray Speth
fb4eece9f8
Use std::unique_ptr instead of raw pointers where appropriate
2015-10-14 18:45:23 -04:00
Ray Speth
3f6d8b0aca
Use cppformat instead of int2str and fp2str
2015-10-14 18:45:23 -04:00
Ray Speth
2589a27b6c
Use range-based for and auto to simplify some loops
2015-10-14 18:45:23 -04:00
Ray Speth
71bb73b728
Eliminate unnecessary calles to std::string.c_str()
2015-10-14 18:45:22 -04:00
Ray Speth
1411419b0f
[1D] Eliminate sprintf-style string formatting
2015-10-14 18:45:22 -04:00
Ray Speth
41527b1ea7
Rename two-argument version of writelog 'debuglog'
...
This is a prerequisite to allowing writelog to take an arbitrary number
of arguments.
2015-10-14 18:45:22 -04:00
Ray Speth
acdf9cf0ed
Clean up interstitial whitespace
...
Remove extra space around operators, between words, etc.
2015-08-02 23:06:16 -04:00
Ray Speth
6a04193646
Fix un-bracketed if, for, and else statements
2015-08-02 23:06:15 -04:00
Ray Speth
801334c84e
Merge nested if statements
2015-08-02 23:06:15 -04:00
Ray Speth
e4c45b6429
General whitespace cleanup
...
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
2015-08-02 23:06:15 -04:00
Ray Speth
619cd20f14
Fix badly-formatted else/else if/catch clauses
2015-08-02 23:06:15 -04:00
Ray Speth
a6e390dfc5
Standardize always-true while loop condition to "true"
2015-08-02 23:06:15 -04:00
Ray Speth
c3c80f79fb
Remove extraneous parentheses
2015-08-02 23:06:14 -04:00
Ray Speth
6cc5652de6
Remove commented-out code
2015-07-20 17:20:46 -04:00
Ray Speth
bf2ceed60e
Remove some leftover debugging ifdefs
2015-07-20 15:47:17 -04:00
Ray Speth
f1f10b6526
Remove unused, deprecated code marked for removal after Cantera 2.2
2015-07-15 12:08:50 -04:00
Ray Speth
217d780233
Fix calls to CanteraError with blank or incorrect first argument
...
The first argument should be the function name from which the exception was
thrown. Leaving this blank makes it difficult to track down the location of the
exception.
2015-06-09 12:03:57 -04:00
Ray Speth
5214672ab3
Merge namespace ctml with namespace Cantera
2015-05-27 18:09:07 -04:00
Ray Speth
fd659c09ea
[1D] Fix saving multiple flame profiles to a single XML file
...
Broken by the change in b0e5b13913 . Modify the save_restore test
to cover this case.
2015-05-02 21:24:51 -04:00
Ray Speth
ecb6242b79
Fix spelling errors
2015-04-08 19:36:55 -04:00
Ray Speth
2e53890adf
Minor cleanup of constructors and destructors
2015-02-26 21:58:42 +00:00
Ray Speth
b8a99b4b83
Remove unnecessary explicit calls to default constructors
2015-01-22 00:04:12 +00:00
Ray Speth
b63d759918
[1D] Remove unused members of class StFlow
2015-01-15 21:15:24 +00:00
Ray Speth
020f3e756c
[1D] Only update radiation flux for specified range grid points
2015-01-15 21:15:22 +00:00
Ray Speth
af447cb85f
[1D] Avoid repeated search for indices of radiating species
...
Also, look for both uppercase and lowercase species names
2015-01-15 21:15:20 +00:00
Ray Speth
bade514587
[1D] Fix up getters/setters/default values for radiation values
2015-01-15 21:15:18 +00:00
Andreas Rücker
49c963143e
[1D] Add simple radiation model for flames
...
Implements the radiation model of Liu & Rogg (1991). Optically thin limit,
gray-gas approximation using Planck mean absorption coefficients. Considers
emissions from CO2 and H2O, with the temperature-dependent absorption
coefficients calculated using polynomial fits to results from RADCAL
(Grosshandler, 1993).
2015-01-15 21:15:15 +00:00
Ray Speth
141e7d9b40
[1D] Make argument to Inlet1D::setMoleFractions const
...
Fixes Issue 246.
2015-01-06 23:37:31 +00:00
Ray Speth
7d19ee9488
Remove unneeded work array management from MultiNewton
2014-12-12 01:36:45 +00:00
Ray Speth
cdf764be4a
[Transport] Allow CK_Mix and CK_Multi transport models in 1D flames
2014-11-19 20:27:57 +00:00
Ray Speth
a208c54d1c
Add a version of XML_Node::getChildren with a simpler interface
2014-10-22 21:48:04 +00:00
Ray Speth
a5149ae665
[1D] Reduce default minimum grid size
...
The new value is OK even for high pressure flames - it is less than the mean
free path in air at 100 bar and 300 K.
2014-10-03 22:15:03 +00:00
Ray Speth
4081d41841
[1D] Change 'save' behavior to avoid endlessly appending solutions
...
Instead of changing the solution 'id' provided by the user to avoid
duplicates, replace the solution with the same id.
2014-09-15 18:04:54 +00:00
Ray Speth
2a69d99d83
[1D] Update thermo properties during Jacobian updates
...
In combination with the previous commit, this significantly improves the
convergence behavior of the solver when using multicomponent transport
properties. In many cases, the solver is now able to directly solve the
multicomponent problem directly from the mixture-averaged solution without any
timestepping.
2014-09-07 21:17:05 +00:00
Ray Speth
92f8fc4292
[1D] Change multicomponent diffusion calculation to improve convergence
...
Change the formulation of multicomponent diffusion fluxes to avoid using the
equivalent Fickian diffusion coefficient. That formulation leads to negative
diffusivities for some species at some grid points, which generate numerical
instabilities while timestepping. This formulation produces a more dense
Jacobian, but with a much better eigenvalue spectrum.
2014-09-07 21:17:03 +00:00
Ray Speth
a837dfdc6d
[1D] Add 'clearStats' function for clearing accumulated solver stats
2014-09-07 21:17:00 +00:00
Ray Speth
002c158761
Cleanup include statements
...
Move includes from header to implementation files where possible, and remove
unnecessary includes.
2014-08-28 16:54:13 +00:00
Ray Speth
56ccc667df
Fix some uninitialized member variables
2014-07-30 16:59:39 +00:00
Ray Speth
d5b873b697
[1D] Fix mass flux reported by Inlet1D for freely-propagating flames
2014-07-18 18:10:56 +00:00
Ray Speth
a2e3e97a1f
[1D] Check that specified grid is monotonically increasing
2014-07-10 22:34:05 +00:00
Ray Speth
b5396837b2
Make use of std::min, std::max, and clip
2014-06-03 16:52:43 +00:00
Ray Speth
6c0cea5ee4
Standardize function used for writing a line of repeated characters
2014-05-27 02:53:06 +00:00
Ray Speth
789574ac80
Remove commented-out code
2014-05-27 02:52:21 +00:00
Ray Speth
54ded64e4b
Miscellaneous whitespace cleanup
2014-05-08 23:01:12 +00:00