Fix some uninitialized member variables

include/cantera/base/ValueCache.h

@@ -30,7 +30,8 @@ struct CachedValue {
     CachedValue() :
         state1(std::numeric_limits<double>::quiet_NaN()),
         state2(std::numeric_limits<double>::quiet_NaN()),
-        stateNum(std::numeric_limits<int>::min())
+        stateNum(std::numeric_limits<int>::min()),
+        value(T())
     {
     }
 

include/cantera/kinetics/ReactionData.h

@@ -16,21 +16,28 @@ namespace Cantera
 class ReactionData
 {
 public:
-    ReactionData() {
-        reactionType = ELEMENTARY_RXN;
-        validate = false;
-        number = 0;
-        rxn_number = 0;
-        reversible = true;
-        rateCoeffType = ARRHENIUS_REACTION_RATECOEFF_TYPE;
-        falloffType = NONE;
-        error = 0;
-        equation = "";
-        default_3b_eff = 1.0;
-        global = false;
-        isReversibleWithFrac = false;
-        beta = 0.0;
-    }
+    ReactionData() :
+        reactionType(ELEMENTARY_RXN),
+        validate(false),
+        number(0),
+        rxn_number(0),
+        reversible(true),
+        duplicate(false),
+        rateCoeffType(ARRHENIUS_REACTION_RATECOEFF_TYPE),
+        falloffType(NONE),
+        error(0),
+        equation(""),
+        default_3b_eff(1.0),
+        global(false),
+        isReversibleWithFrac(false),
+        beta(0.0),
+        chebTmin(-1.0),
+        chebTmax(-1.0),
+        chebPmin(-1.0),
+        chebPmax(-1.0),
+        chebDegreeT(0),
+        chebDegreeP(0)
+    {}
 
     virtual ~ReactionData() {}
 

include/cantera/kinetics/RxnRates.h

@@ -380,8 +380,12 @@ public:
 
     //! Constructor from ReactionData.
     explicit Plog(const ReactionData& rdata) :
+        logP_(-1000),
         logP1_(1000),
         logP2_(-1000),
+        m1_(npos),
+        m2_(npos),
+        rDeltaP_(-1.0),
         maxRates_(1) {
         typedef std::multimap<double, vector_fp>::const_iterator iter_t;
 

src/kinetics/FalloffFactory.cpp

@@ -233,7 +233,7 @@ class SRI3 : public Falloff
 {
 public:
     //! Constructor
-    SRI3() {}
+    SRI3() : m_a(-1.0), m_b(-1.0), m_c(-1.0) {}
 
     //! Initialization of the object
     /*!
@@ -318,7 +318,7 @@ class SRI5 : public Falloff
 {
 public:
     //! Constructor
-    SRI5() {}
+    SRI5() : m_a(-1.0), m_b(-1.0), m_c(-1.0), m_d(-1.0), m_e(-1.0) {}
 
     //! Initialization of the object
     /*!

src/oneD/OneDim.cpp

@@ -19,7 +19,7 @@ OneDim::OneDim()
       m_jac(0), m_newt(0),
       m_rdt(0.0), m_jac_ok(false),
       m_nd(0), m_bw(0), m_size(0),
-      m_init(false),
+      m_init(false), m_pts(0), m_solve_time(0.0),
       m_ss_jac_age(10), m_ts_jac_age(20),
       m_interrupt(0), m_nevals(0), m_evaltime(0.0)
 {
@@ -31,7 +31,7 @@ OneDim::OneDim(vector<Domain1D*> domains) :
     m_jac(0), m_newt(0),
     m_rdt(0.0), m_jac_ok(false),
     m_nd(0), m_bw(0), m_size(0),
-    m_init(false),
+    m_init(false), m_solve_time(0.0),
     m_ss_jac_age(10), m_ts_jac_age(20),
     m_interrupt(0), m_nevals(0), m_evaltime(0.0)
 {

src/transport/SimpleTransport.cpp

@@ -22,6 +22,8 @@ SimpleTransport::SimpleTransport(thermo_t* thermo, int ndim) :
     doMigration_(0),
     m_iStateMF(-1),
     concTot_(0.0),
+    meanMolecularWeight_(-1.0),
+    dens_(-1.0),
     m_temp(-1.0),
     m_press(-1.0),
     m_lambda(-1.0),

src/zeroD/FlowReactor.cpp

@@ -13,9 +13,14 @@ namespace Cantera
 
 FlowReactor::FlowReactor() :
     Reactor(),
+    m_speed(0.0),
     m_dist(0.0),
+    m_T(0.0),
     m_fctr(1.0e10),
-    m_speed0(0.0)
+    m_rho0(0.0),
+    m_speed0(0.0),
+    m_P0(0.0),
+    m_h0(0.0)
 {
 }
 

src/zeroD/Reactor.cpp

@@ -21,8 +21,10 @@ Reactor::Reactor() : ReactorBase(),
     m_kin(0),
     m_vdot(0.0),
     m_Q(0.0),
+    m_mass(0.0),
     m_chem(false),
     m_energy(true),
+    m_nv(0),
     m_nsens(npos)
 {}