Ray Speth
51b0e46277
[Thermo] ThermoPhase::modifyOneHf298SS always invalidates cached data
2016-04-18 22:20:06 -04:00
Ray Speth
9c4a0baa55
[Thermo] Simplify adding species for most phase types
...
Where possible, extend arrays as species are added rather than requiring a
later call to initThermo(). For phases that do not require any data except
that which is included in the Species objects themselves (notably, this
includes IdealGasPhase), species can now be added dynamically without
affecting the phase state.
2016-04-15 20:56:24 -04:00
Ray Speth
f44b5fed57
Replace usage of int2str with cppformat and deprecate int2str
2016-02-04 19:11:49 -05:00
Ray Speth
4887775109
Eliminate unnecessary counter member variables
2015-12-01 15:54:55 -05:00
Ray Speth
e58bd09859
Eliminate debug_verbose option and DEBUG_MODE macro
...
Vebose printing can always be enabled at runtime by setting flags on various
classes.
2015-11-18 11:02:30 -05:00
Ray Speth
5e69a9949a
Use ThermoPhase::RT() where convenient
2015-11-12 15:36:17 -05:00
Ray Speth
4382ae6c85
Clean up comments in Thermo class source files
2015-11-09 17:34:46 -05:00
Ray Speth
0647823ada
Replace DATA_PTR macro with calls to data()
2015-10-17 18:58:50 -04:00
Ray Speth
bfb20e1f50
Consistently use vector_fp and vector_int typedefs
2015-08-02 23:06:16 -04:00
Ray Speth
acdf9cf0ed
Clean up interstitial whitespace
...
Remove extra space around operators, between words, etc.
2015-08-02 23:06:16 -04:00
Ray Speth
e4c45b6429
General whitespace cleanup
...
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
2015-08-02 23:06:15 -04:00
Ray Speth
f219b49e63
Remove unnecessary newlines in function signatures
2015-08-02 23:06:15 -04:00
Ray Speth
c3c80f79fb
Remove extraneous parentheses
2015-08-02 23:06:14 -04:00
Ray Speth
546289f737
Remove deprecated code with functional alternatives
2015-07-13 18:59:09 -04:00
Ray Speth
d373e0751e
Remove unnecessary explicit specification of namespace Cantera
2015-06-24 14:45:55 -04:00
Ray Speth
217d780233
Fix calls to CanteraError with blank or incorrect first argument
...
The first argument should be the function name from which the exception was
thrown. Leaving this blank makes it difficult to track down the location of the
exception.
2015-06-09 12:03:57 -04:00
Ray Speth
5214672ab3
Merge namespace ctml with namespace Cantera
2015-05-27 18:09:07 -04:00
Ray Speth
96cf312ec6
[Thermo] Always add species using Species objects
...
Deprecate the non-Species-based addSpecies and addUniqueSpecies
functions.
2015-04-20 18:34:38 -04:00
Ray Speth
7d170a9989
[Thermo] newSpeciesThermoInterpType argument is the 'thermo' XML node
...
No data from the outer 'species' node is needed to instantiate the
SpeciesThermoInterpType object, so this function can just take the 'thermo' node
directly.
2015-04-17 19:06:43 -04:00
Ray Speth
5195e4f9b8
[Thermo] Use shared_ptr to STIT objects in Species and SpeciesThermo
...
Exclusive ownership of the SpeciesThermoInterpType objects is no longer assumed.
2015-04-14 15:29:28 -04:00
Ray Speth
a1599ac921
[Thermo] Add 'index' argument to GeneralSpeciesThermo::install_STIT
...
This is a prerequisite to removing the species index as a property of the
SpeciesThermoInterpType object and making it independent of any specific
ThermoPhase object.
2015-04-14 15:29:28 -04:00
Ray Speth
7acf0378c6
[Thermo] Improve usage of local variables
...
Also eliminate some unnecessary temporary variables.
2015-02-12 04:04:18 +00:00
Ray Speth
b8a99b4b83
Remove unnecessary explicit calls to default constructors
2015-01-22 00:04:12 +00:00
Ray Speth
a208c54d1c
Add a version of XML_Node::getChildren with a simpler interface
2014-10-22 21:48:04 +00:00
Ray Speth
4dd3e1d2bc
Use Species objects when adding species from XML
2014-10-17 23:44:47 +00:00
Ray Speth
53abe2ee9a
[Thermo] Always use GeneralSpeciesThermo
...
The specialized SpeciesThermo derived types offer no performance benefit now
that GeneralSpeciesThermo manages calculation of the temperature terms
efficiently.
2014-10-15 02:03:06 +00:00
Ray Speth
91f3a2b073
Fix statements that called the assignment operator twice
2014-10-03 01:45:41 +00:00
Ray Speth
4baccc732c
[Thermo] Simplify interface for adding elements to a Phase
...
Phase::addElements(string name, ...) is the single entry point for adding
elements. It always perform the uniqueness check, and can do the extra
additional work required to add elements to a phase that already has species,
removing the need for "freezing" the phase's elements. Parsing the XML tree for
elements is now handled in "installElements". The variant element-adding methods
are deprecated.
2014-09-27 00:09:05 +00:00
Ray Speth
002c158761
Cleanup include statements
...
Move includes from header to implementation files where possible, and remove
unnecessary includes.
2014-08-28 16:54:13 +00:00
Ray Speth
45f6e84ebf
Improved error messages that just reported 'confused'
2014-07-10 22:36:43 +00:00
Ray Speth
712293e415
Change debug code to avoid ifdefs where possible
...
Use "if (DEBUG_MODE_ENABLED)" instead of "#ifdef DEBUG_MODE". This makes
it easier to see the flow control logic, and the compiler will optimize
out the always-false conditionals when DEBUG_MODE_ENABLED is 0, so there
isn't any speed penalty.
2014-05-27 02:53:22 +00:00
Ray Speth
789574ac80
Remove commented-out code
2014-05-27 02:52:21 +00:00
Ray Speth
2a9ab96609
Use NotImplementedError instead of 'err' member functions
2014-05-06 14:39:13 +00:00
Ray Speth
6a51eb88dc
[Thermo] Move modifyOneHf298SS and m_tlast to ThermoPhase
...
This eliminates many duplicate implementations of this function and
declarations of this variable.
2014-03-08 21:46:58 +00:00
Ray Speth
2ead29097c
[Thermo] Make signatures of overridden Hf298 functions consistent
2014-02-21 19:08:19 +00:00
Ray Speth
14b1bf093b
Remove option to disable 'h298modify_capability' at compile-time
2014-02-06 22:58:56 +00:00
Ray Speth
a6614b87bb
[Doxygen] Fix some incorrect/missing "@file" commands
2013-06-06 15:32:30 +00:00
Ray Speth
d253fc0d63
Eliminate redundant standard library includes
2013-06-05 17:08:13 +00:00
Ray Speth
934010136d
Removed unnecessary temporaries used for storing return values
2013-02-14 01:04:07 +00:00
Ray Speth
d59cac4ca0
Cleaned up Doxygen docs for other descendants of ThermoPhase
2013-02-14 01:02:58 +00:00
Ray Speth
7da738d238
Re-applied consistent formatting to trunk
...
Applied using: astyle -n --style=kr --add-brackets --indent=spaces=4
--indent-col1-comments --unpad-paren --pad-header --align-pointer=type
--lineend=linux
2013-02-07 23:40:59 +00:00
Victor Brunini
7c70568bb3
Clean up compiler warnings.
2012-11-07 21:08:56 +00:00
Ray Speth
120600c625
Removed some unused member variables from ThermoPhase classes
2012-10-24 15:46:31 +00:00
Ray Speth
94d08f1d5e
Removed unnecessary casts from object duplication functions
2012-10-24 15:45:33 +00:00
Ray Speth
1d19803885
Pass "const std::string&" instead of "std::string" when possible
2012-10-24 15:42:51 +00:00
Ray Speth
3fbf298a21
Removed redundant implementation of speciesThermo() from LatticeSolidPhase
2012-08-17 16:44:07 +00:00
Ray Speth
85d9d360c7
Fixed a bunch of spelling issues
2012-08-17 16:43:34 +00:00
Ray Speth
6011f24b38
Removed unnecessary WITH_FEATURE configuration options
2012-05-31 14:57:32 +00:00
Ray Speth
e41f43300f
Folded class State into class Phase
2012-03-09 22:55:34 +00:00
Ray Speth
3bff32dd55
Fixed problems that generated warnings with the Intel compiler
2012-03-07 00:51:13 +00:00