Commit graph

1444 commits

Author SHA1 Message Date
Harry Moffat
16c8a59ca5 Bugfix checkin to get the duplMyselfAsThermoPhase() routines working.
Bugs include quite a few errors in the copy constructors and
assignment operator functions, which, for most of them, have been
checked against a sample problem, HMW_dupl_test, for the very first time.

Note, the duplMyselfAsThermoPhase() routines are now working.
2007-06-01 23:44:24 +00:00
Harry Moffat
92c76dd5af Changed the copy() and copyUnion() functions to be const.
Declared the XML_Node copy constructor and assignment operators
to be private -> they don't work, so accidently invoking them is
an error. Now, a compilation error will occur.
Note, the copy() routine can be used instead to create copies
of XML trees.
2007-06-01 23:36:53 +00:00
Harry Moffat
a42ef08f9c Added copy constructors and assignment operators where they were
missing. Working towards getting the duplicate member functions
to work.
2007-06-01 19:12:18 +00:00
Harry Moffat
9773c9b23b Changed the duplMyselfAsThermoPhase function to be a const function
(trying to keep a unified view of what are const and non-const
functions within the ThermoPhase classes)
2007-06-01 15:31:02 +00:00
Harry Moffat
3ea77c5187 Fixed a UMR in Reaction.h that was causing optimized versions
of ck2cti to hang or seg fault sometimes.

Added some exceptions that captures cases where the thermo
parameters for a molecule were not found in the database.
Now, an error exit occurs, instead of before, where misc
garbage but written to the output file.
2007-05-31 23:51:49 +00:00
Dave Goodwin
a68e8f734d correcting recently-introduced bug 2007-05-29 10:38:07 +00:00
Dave Goodwin
14aa5baee8 *** empty log message *** 2007-05-25 14:17:38 +00:00
Harry Moffat
86a6070392 Added missing partial molar functions. 2007-05-24 21:09:52 +00:00
Dave Goodwin
dafd2ad411 *** empty log message *** 2007-05-22 20:16:47 +00:00
Harry Moffat
778347d6dc Change some input files to ensure that charge and the element
composition of E are in line with each other.
2007-05-20 22:22:28 +00:00
Harry Moffat
705d934080 Added a Check between the input charge and the composition of
the "E" element. At this point there doesn't seem to be
a reason to let meaning of the definition of charge() and the elemental
composition of E in each species to diverge.
2007-05-20 22:21:07 +00:00
Dave Goodwin
39d60dd2d1 EdgeKinetics now derives from InterfaceKinetics, and InterfaceKinetics has the beta parameter for electrochemistry 2007-05-18 10:54:54 +00:00
Dave Goodwin
5b75d6bae7 EdgeKinetics now derives from InterfaceKinetics, and InterfaceKinetics has the beta parameter for electrochemistry 2007-05-18 10:54:53 +00:00
Harry Moffat
6035a7c6d1 doxygen change
reformated some comments.
2007-05-17 21:17:16 +00:00
Harry Moffat
803b4f1803 Took out the ReactionData.h include. The kinetics class doesn't use it. 2007-05-17 21:16:09 +00:00
Harry Moffat
c391bae703 Added several missing thermodynamics routines to SurfPhase object.
Added error checking to make sure that a ThermoPhase object has
at least one species defined in it. Currently, it just won't work
if there are 0 species in the object, so we might as well throw
an error early to indicate this.

Added error checking to the SurfPhase object to indicate when
setCoverages is called with no coverages specified. This condition had
caused NaN's. Now, it throws a CanteraError.
2007-05-17 15:02:56 +00:00
Harry Moffat
9f895f47ab Added a dir.
Added more predefines.
2007-05-14 14:37:37 +00:00
Harry Moffat
4b406f06bf Doxygen updates -> worked on documenting functions
Changed a few functions from private to protected so that
they would be available to derived classes
2007-05-14 01:02:57 +00:00
Harry Moffat
4084343fcf Doxygen update -> Eliminating warning messages. 2007-05-14 01:00:27 +00:00
Dave Goodwin
36d53fdb42 *** empty log message *** 2007-05-12 17:16:15 +00:00
Dave Goodwin
7183da1ad4 *** empty log message *** 2007-05-12 14:49:12 +00:00
Dave Goodwin
a5ddeea733 support for cmake 2007-05-12 14:42:15 +00:00
Dave Goodwin
7f570c79ca bug fixes 2007-05-12 12:55:25 +00:00
Harry Moffat
6e64d22031 Doxygen update of some kinetics classes. Have a ways to go
before these are documented.
2007-05-11 23:11:11 +00:00
Harry Moffat
4178af28fe Added doxygen documentation. still needs work to get all the
new stuff covered.
2007-05-11 21:44:05 +00:00
Dave Goodwin
95d150071d bug fixes 2007-05-11 20:58:19 +00:00
Harry Moffat
240e0fc78e Added PREDEFINES. Apparently, the current config.h setup doesn't get
passed through doxygen's predefines. Therefore, modules aren't being
read into the doxygen documentation. The solution is to
artificially define PREDEFINES, so that doxygen can operate
correctly.
2007-05-11 19:56:03 +00:00
Harry Moffat
a21d3715cc Took out config.h include. Doxygen preprocessing is at fault,
and it can be fixed through the doxygen input file.
2007-05-11 19:54:18 +00:00
Dave Goodwin
b571729262 bug fixes 2007-05-11 19:29:35 +00:00
Harry Moffat
8161cebeec Added an IntEnergy calculation routine. 2007-05-11 17:40:16 +00:00
Harry Moffat
e3a04abeea Added a namespace declaration to Assert commands, that's needed
in applications.
2007-05-11 17:37:40 +00:00
Harry Moffat
aa7bf0421b Fixed a bug in the calculation of reference state values, for
thermophase objects that derive from VPStandardStateTP
2007-05-11 17:34:44 +00:00
Harry Moffat
77bb1baa7e Took out bad documentation statements. 2007-05-11 17:31:33 +00:00
Harry Moffat
8f2124fa5d Added a :chargeNeutralityNecessary() function and boolean.
If charge neutrality is necessary for the proper specification
of thermo functions, this is true. If not it's set to false.
Currently, it's true for molality based formulations, and false
otherwise. It's false for Ideal gases.
2007-05-11 17:30:31 +00:00
Harry Moffat
ea97be3421 Added a specific include config.h command, because doxygen wasn't
recognizing it.
2007-05-11 17:21:33 +00:00
Harry Moffat
b098a9ec8d Added additional directories so that doxygen can find the files. 2007-05-11 17:19:14 +00:00
Dave Goodwin
01b70682e3 *** empty log message *** 2007-05-11 17:17:30 +00:00
Dave Goodwin
b53efe5159 *** empty log message *** 2007-05-10 20:34:58 +00:00
Dave Goodwin
9ec5f81be1 minor bug fixes 2007-05-10 20:22:36 +00:00
Dave Goodwin
9a13b924d8 added FactoryBase.h 2007-05-10 18:39:09 +00:00
Dave Goodwin
52af3dd76d adding support for cmake. 2007-05-10 17:59:11 +00:00
Dave Goodwin
39183733f0 *** empty log message *** 2007-05-10 03:38:38 +00:00
Dave Goodwin
ba5928083f added thread safety option 2007-05-10 03:28:30 +00:00
Dave Goodwin
1b3da91d15 *** empty log message *** 2007-05-09 20:44:25 +00:00
Dave Goodwin
9bb4295a5c *** empty log message *** 2007-05-09 14:55:45 +00:00
Dave Goodwin
c1fc4ef78d *** empty log message *** 2007-05-09 14:05:12 +00:00
Harry Moffat
79cdac83b9 Fixed the make clean rule. 2007-05-06 17:16:43 +00:00
Harry Moffat
9029f8b979 Fixed the Make clean rule. Have to eliminate .depends before make is
called, because the rule to 'make .depends' was being called on invocation
if .depends exists.
2007-05-06 17:15:53 +00:00
Harry Moffat
8068945ce7 forgot a file. 2007-05-05 00:30:57 +00:00
Harry Moffat
910a2abf86 Fixed an error that occurred during linking of applications.
There were multiple definitions of importPhase(string, string),
one per application file.
I moved the definition of importPhase to libctxx.a as it had
to be in an object file, and I retained the declaration within
importPhase.h. I also added declarations for the other
functions in libctxx.a into importPhase.h, as they weren't
declared anywhere in the interface.
2007-05-05 00:29:49 +00:00