Ray Speth
1cd82d40af
Remove 'SQUARE' and 'DSIGN' macros
2014-07-25 18:32:29 +00:00
Ray Speth
8aab7f527a
Use std::max_element instead of reimplementing it
2014-07-25 18:32:26 +00:00
Ray Speth
5ebdb7e924
Use execeptions to simplify usage of ElemRearrange
2014-07-10 22:36:36 +00:00
Ray Speth
3349a28d38
Update some deprecation warnings.
2014-06-20 18:44:39 +00:00
Ray Speth
e778afad32
Remove deprecated functions
2014-06-20 18:44:33 +00:00
Ray Speth
83e38480d6
Throw exceptions instead of calling std::exit after an error
...
By throwing an exception, Cantera is better behaved when used within other
applications, e.g. as in the case of the Matlab and Python interfaces.
2014-06-06 00:17:58 +00:00
Harry Moffat
f3a0092b42
Fixed a error introduced by Speth that caused the brine phase pop problems to fail.
2014-06-05 22:40:20 +00:00
Ray Speth
dbfe428437
Fix compiler warnings
...
These were mostly related to changes from r2957.
2014-06-03 16:53:40 +00:00
Ray Speth
d38e4553ec
Eliminate 'goto' in VCS_SOLVE::vcs_inest
2014-06-03 16:53:34 +00:00
Ray Speth
b5396837b2
Make use of std::min, std::max, and clip
2014-06-03 16:52:43 +00:00
Ray Speth
46a36c11cb
Eliminate redundant VCS vector functions
...
These functions just duplicated features of the standard library.
2014-05-30 19:23:25 +00:00
Ray Speth
c6cefd6df8
Replace IntStarStar with Array2D
2014-05-30 19:23:16 +00:00
Ray Speth
b569b842d0
Replace DoubleStarStar with Array2D
2014-05-30 19:23:03 +00:00
Ray Speth
f80db6c08d
Make function signatures independent of DEBUG_MODE
2014-05-27 02:54:34 +00:00
Ray Speth
ddfc7db080
Make helper functions for pieces of vcs_solve_TP main loop
2014-05-27 02:54:24 +00:00
Ray Speth
ad12f392ce
Some cleanup of vcs_solve_TP
...
Use local variables where possible. Remove unreachable code.
Move repeated code out of if/else blocks. Flatten nested if statements.
2014-05-27 02:54:11 +00:00
Ray Speth
32276b1fda
Refactor vcs_solve_TP to eliminate goto
...
This contains just the changes to the flow control to give the same
behavior as the original implementation. Additional refactoring
still to come.
2014-05-27 02:54:07 +00:00
Ray Speth
40e748a2d1
Set printLvl = loglevel for VCS solver since it doesn't use loglevel
2014-05-27 02:53:47 +00:00
Ray Speth
373e4ae565
Remove goto and manual memory management from MultiPhase::equilibrate
2014-05-27 02:53:42 +00:00
Ray Speth
4b9e4da822
Fix some compiler warnings
2014-05-27 02:53:35 +00:00
Ray Speth
712293e415
Change debug code to avoid ifdefs where possible
...
Use "if (DEBUG_MODE_ENABLED)" instead of "#ifdef DEBUG_MODE". This makes
it easier to see the flow control logic, and the compiler will optimize
out the always-false conditionals when DEBUG_MODE_ENABLED is 0, so there
isn't any speed penalty.
2014-05-27 02:53:22 +00:00
Ray Speth
7ec4531ae0
Removed debugging code that didn't actually do anything
2014-05-27 02:53:16 +00:00
Ray Speth
6c0cea5ee4
Standardize function used for writing a line of repeated characters
2014-05-27 02:53:06 +00:00
Ray Speth
789574ac80
Remove commented-out code
2014-05-27 02:52:21 +00:00
Ray Speth
4dcdc01fb8
[VCS] Use local variable declarations where possible
2014-05-23 22:47:03 +00:00
Ray Speth
90a821caf6
Eliminate 'goto' from ChemEquil::estimateEP_Brinkley
2014-05-21 16:35:09 +00:00
Ray Speth
44e7dd91ad
[Equil] Eliminate 'mlequ' and 'gaussj' in favor of using LAPACK
2014-05-21 16:35:02 +00:00
Ray Speth
ef781b44e6
Restructure ChemEquil::equilibrate to eliminate 'goto' statements
2014-05-21 16:34:57 +00:00
Ray Speth
54ded64e4b
Miscellaneous whitespace cleanup
2014-05-08 23:01:12 +00:00
Ray Speth
588728addc
[Equil] Make vcs_MultiPhaseEquil::m_vprob a normal member variable
2014-04-14 18:37:06 +00:00
Ray Speth
818a22be05
[Equil] Make vcs_MultiPhaseEquil::m_vsolvePtr a normal member variable
...
There is no reason for this to be a pointer.
2014-04-14 18:36:58 +00:00
Ray Speth
14ea7e64c6
[Thermo] make compositonMap a const argument
2014-04-08 16:26:20 +00:00
Ray Speth
95eb7ab3ba
Remove newline after '::' in member function definitions
...
This inconsistency makes it hard to directly search the code for a specific
member function definition.
2014-03-24 04:03:09 +00:00
Ray Speth
c7ba8bfb84
Remove abandoned autotools build system
2014-03-04 17:38:53 +00:00
Ray Speth
6f8da1a27e
Fix 'unused variable' warnings
2014-02-21 19:08:33 +00:00
Ray Speth
dfc542be76
Fix some issues identified by compiler warnings
2014-01-09 23:12:11 +00:00
Ray Speth
607955b9f2
Remove unnecessary conditional surrounding 'delete' statements
2014-01-06 18:45:19 +00:00
Ray Speth
f63f8ae57e
Remove deprecated HTML logging functionality
2013-12-09 01:36:11 +00:00
Harry Moffat
5720d7cf90
Fixed an error where the users data was changed before it was used.
...
Eliminated some deprecations which were not sanctioned.
Worked on Cantera.mak. There is a problem with scons eliminating $ from strings.
2013-09-06 22:52:59 +00:00
Ray Speth
2ac98393bd
[Equil] Remove a calculation with an unused result
2013-09-30 01:53:48 +00:00
Ray Speth
f61cbeafcb
[Equil] Fix infinite loop in VCS equilibrium solver
...
The threshold being removed here was introduced in r714, which was merged into
trunk in r1115.
Fixes Issue 113.
2013-08-23 17:43:44 +00:00
Ray Speth
35aed42fbd
[Equil] Raise exceptions instead of aborting execution
2013-07-26 21:33:57 +00:00
Ray Speth
123544e4f7
[VCS Equil] Eliminate unnecessary calls to reportParams
2013-06-24 15:21:51 +00:00
Ray Speth
89664920e8
Eliminated use of PrintCtrl in ChemEquil debug mode
2013-06-24 15:21:40 +00:00
Ray Speth
a6614b87bb
[Doxygen] Fix some incorrect/missing "@file" commands
2013-06-06 15:32:30 +00:00
Ray Speth
d253fc0d63
Eliminate redundant standard library includes
2013-06-05 17:08:13 +00:00
Ray Speth
7d79b30c27
Removed unnecessary MIN and MAX macros
2013-04-29 18:05:10 +00:00
Ray Speth
ea8eca5bde
Cleaned up Doxygen documentation for miscellaneous VCS classes
2013-04-18 22:08:27 +00:00
Ray Speth
fc7067b63d
Cleaned up Doxygen documentation for class vcs_MultiPhaseEquil
2013-04-18 22:08:22 +00:00
Ray Speth
ba5115fe64
Cleaned up Doxygen documentation for class VCS_PROB
2013-04-18 22:08:16 +00:00