a641992960
To both check and update the cached state values. Reduces a lot of code duplication in the use of CachedValues. I'd like to make state1, state2, and stateNum private so that they can only be accessed with one of the validate functions, and also add some asserts to the validate functions that do not use all of the state variables to ensure that the unused ones are set to their default values to prevent the case where the wrong validate() function is called and incorrectly determines that the cached state is valid. First pass at making the state variables private caused a test failure for test_problems/statmech. The m_spthermo->update() call in IdealGasPhase::_updateThermo() throws an exception for this test right now that gets caught in equilibrate(). When using validate() the cached state variable is updated before the m_spthermo->update() call and subsequently it thinks that the thermo does not need to be updated, whereas when cached.state1 is being set after the m_spthermo->update() call it does not get set. The current blessed output for that test is just the text of the exception that gets caught, so I suspect the test may not work as is. |
||
|---|---|---|
| .. | ||
| cantera | ||