Commit graph

81 commits

Author SHA1 Message Date
Ingmar Schoegl
7c08e17f08 [Thermo] deprecate Phase::id and Phase::setID
* Merge usage of 'id' and 'name' in the context of Phase objects
* Raise deprecation warnings for Phase::id and Phase::setID
2019-10-23 13:45:29 -04:00
Paul
c4aff04418 Updated URL in references to Cantera's license. 2019-09-23 22:02:33 -04:00
Ray Speth
0b04881b8d [Input] Handle "declared-species" option for adding reactions from YAML 2019-06-25 22:30:59 -04:00
Ray Speth
9aa507a098 [Kinetics] Make some member functions const 2018-12-02 23:54:04 -05:00
Ray Speth
e4362d37e7 [Kinetics] Check for non-existent species in reaction orders
When the nonreactant_orders option was enabled, specifying reactant orders for
species which were not present in the phase previously resulted in out-of-bounds
memory access.
2018-08-28 16:40:43 -04:00
Ray Speth
4c489c175d [Kinetics] Fix duplicate reaction check to handle unchanged species 2017-08-02 16:46:24 -04:00
Ray Speth
513b43200c [Kinetics] Fix indexing error in Kinetics::checkDuplicates 2017-08-02 16:46:24 -04:00
Ray Speth
7673f7cb52 Remove code deprecated in Cantera 2.3.0 2017-02-12 19:22:33 -05:00
Ray Speth
0fd2f7c4d0 [Kinetics] Check for unmatched duplicate reactions
Reactions which are marked as duplicates but have no matching reactions are
considered errors.

Fixes #389
2017-01-23 14:34:18 -05:00
g3bk47
e83b095c3a [Kinetics] added const version of Kinetics::reaction 2016-10-15 18:24:35 -04:00
Ray Speth
0b5e209b40 [Kinetics] Remove unused private members of class Kinetics 2016-10-13 18:40:03 -04:00
Ray Speth
ecbfecd7fd Replace existing copyright notices with uniform copyright/license info 2016-10-10 22:19:01 -04:00
Ray Speth
ac7a9bd238 Deprecate copy constructors for eventually-noncopyable objects
The following classes (and their children) will be non-copyable and
non-assignable after Cantera 2.3:
  - ThermoPhase
  - Kinetics
  - Transport
  - Species
  - SpeciesThermoInterpType
  - MultiSpeciesThermo
  - VPSSMgr
  - PDSS
  - ResidJacEval
  - RootFind
2016-07-29 18:57:29 -04:00
Ray Speth
7f21aa0f45 [Kinetics] Replace numerical constants for Kinetics types with strings 2016-07-07 21:36:11 -04:00
Ray Speth
0f71bbcec5 [Thermo] Replace numerical constants for ThermoPhase types with strings
Deprecate ThermoPhase::eosType and related methods
2016-07-07 21:36:11 -04:00
Ray Speth
920ff1d897 [Kinetics] Make better use of local variables 2016-05-12 16:33:33 -04:00
Ray Speth
1ba5f6b879 [Kinetics] Allow adding species after reactions for homogeneous kinetics
This enables incremental mechanism construction for gas phase kinetics. For
surface kinetics, adding new species changes the kinetics species index of
existing species in other phases, so this feature is disabled.
2016-04-16 11:52:08 -04:00
Ray Speth
1f231d1dd0 [Kinetics] Eliminate need for 'finalize' method
All reaction-sized arrays are now allocated as reactions are added, which means
that the finalize() method is unnecessary and reactions can be continuously
added, even after the Kinetics object has been used for rate calculations.
2016-04-15 17:05:10 -04:00
Ray Speth
13fa0c7a4f Add invalidateCache() function to ThermoPhase and Kinetics
This can be used to invalidate cached data after a change to underlying data
such as species thermo coefficients or reaction rate coefficients. Needs to be
user-accessible so that dependent objects can be updated manually.
2016-04-15 15:32:38 -04:00
Ray Speth
75b0c71044 Clean up comments in Kinetics 2015-11-09 17:59:22 -05:00
Ray Speth
a945ef2c23 Make use of initializer lists where appropriate 2015-10-17 18:58:50 -04:00
Ray Speth
a03f370cfd Make use of emplace and emplace_back methods 2015-10-14 18:45:23 -04:00
Ray Speth
c3a16ec1fb Update AssertThrowMsg and AssertFinite to use cppformat 2015-10-14 18:45:23 -04:00
Ray Speth
3f6d8b0aca Use cppformat instead of int2str and fp2str 2015-10-14 18:45:23 -04:00
Ray Speth
78e2d13da7 Eliminate some special cases by using std::vector.data()
Unlike &vec[0], vec.data() is a valid operation even when vec is empty,
removing the need to allocate space in vectors just so we can get an
address that won't be used.
2015-10-14 18:45:23 -04:00
Ray Speth
2589a27b6c Use range-based for and auto to simplify some loops 2015-10-14 18:45:23 -04:00
Ray Speth
acdf9cf0ed Clean up interstitial whitespace
Remove extra space around operators, between words, etc.
2015-08-02 23:06:16 -04:00
Ray Speth
e4c45b6429 General whitespace cleanup
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
2015-08-02 23:06:15 -04:00
Ray Speth
619cd20f14 Fix badly-formatted else/else if/catch clauses 2015-08-02 23:06:15 -04:00
Ray Speth
c49c969184 [Kinetics] Remove unused code for reactant and product "groups" 2015-07-20 14:04:53 -04:00
Ray Speth
4f1250ef53 [Kinetics] Remove unneeded variables for reaction equation
Extract this data from the reaction objects directly as needed.
2015-07-20 13:53:47 -04:00
Ray Speth
62f2af5534 [Kinetics] Eliminate unnecessary variable m_rxntype 2015-07-20 13:01:05 -04:00
Ray Speth
f623e44d32 [Kinetics] Eliminate unnecessary m_rrxn and m_prxn variables
This information can be extracted from the Reaction objects as-needed.
2015-07-20 12:56:56 -04:00
Ray Speth
761f54f241 Eliminate unnecessary counter variable Kinetics::m_ii 2015-07-16 15:37:41 -04:00
Ray Speth
f1f10b6526 Remove unused, deprecated code marked for removal after Cantera 2.2 2015-07-15 12:08:50 -04:00
Ray Speth
546289f737 Remove deprecated code with functional alternatives 2015-07-13 18:59:09 -04:00
Ray Speth
1c878c16de Fix issues indicated by compiler warnings 2015-05-26 11:42:20 -04:00
Ray Speth
ba9c9c768f [Kinetics] Use the name 'ThreeBodyReaction' consistently 2015-05-11 16:35:46 -04:00
Ray Speth
62cd325036 [Kinetics] Implement modifyReaction for gas-phase reactions 2015-05-07 18:31:40 -04:00
Ray Speth
14b2e8f5cf [Kinetics] Fix 'skip_undeclared_species' behavior 2015-05-06 21:14:58 -04:00
Ray Speth
bbe2e1c79b [Python] Add access to properties of simple reaction types
This includes ElementaryReaction and ThirdBodyReaction
2015-04-23 18:10:15 -04:00
Ray Speth
70b51c797c Fix function named specified in checkReactionBalance exception message 2015-02-20 00:11:16 +00:00
Ray Speth
e545d123c2 [Kinetics] Relax tolerance on reaction element balance
This allows use of some mechanisms with imprecise fractional product
stoichiometries.
2015-02-20 00:11:12 +00:00
Ray Speth
5958578c40 [Kinetics] Check for negative and non-reactant reaction orders
Allow non-reactant orders for electrochemical reactions

Allow negative orders specifically requested, e.g. by setting the
'negative_orders' option in the CTI definition of the reaction.
2014-11-15 00:47:25 +00:00
Ray Speth
7438e791b5 Update comments in Kinetics::addReaction 2014-11-15 00:47:18 +00:00
Ray Speth
e3022a8057 [Kinetics] Check Reaction objects for orders on reversible reactions 2014-11-15 00:47:13 +00:00
Ray Speth
82fbff7a05 [Kinetics] Validate rate coefficient data for Reaction objects 2014-11-15 00:47:09 +00:00
Ray Speth
6727902c3f [Kinetics] Allow skipping third-body efficiencies when using Reaction 2014-11-15 00:47:04 +00:00
Ray Speth
ffe3eb5e5a [Kinetics] Check for undeclared species when using Reaction objects
Skip the reaction or raise an exception based on the
'm_skipUndeclaredSpecies' flag
2014-11-15 00:46:59 +00:00
Ray Speth
d72c2e7132 [Kinetics] Add reaction balance check to Kinetics
This applies to reactions added using Reaction objects. Previously, the
check would only be performed for reactions added from an XML tree.
2014-11-15 00:46:57 +00:00