Commit graph

1421 commits

Author SHA1 Message Date
John Hewson
1dad7e320a LiquidTransport.h LiquidTransport.cpp
Removed a number of variables relevant only to the gas-phase transport
coefficient models.  These include the following:
-    vector_fp  m_cond;
-    vector_fp                    m_polytempvec;
-    vector<vector_fp>            m_condcoeffs;
-    std::vector<vector_fp> viscCoeffsVector_;
-    vector_fp m_sqvisc;
-    vector_fp viscSpecies_;
-    DenseMatrix m_wratkj1;
-    DenseMatrix m_phi;
-    DenseMatrix m_wratjk;

Removed much code related to these variables.

Added a number of variables relevant to the liquid-phase transport
models including: 
+    vector_fp  m_condSpecies;
+    vector_fp m_viscSpecies;
+    vector_fp  m_visc_A;
+    vector_fp  m_visc_n;
+    vector_fp  m_visc_Tact;
+    vector_fp  m_thermCond_A;
+    vector_fp  m_thermCond_n;
+    vector_fp  m_thermCond_Tact;

Changed some of the relevant comments to
pertain to the liquid-phase models.
2009-09-24 20:46:26 +00:00
Harry Moffat
b093f02473 Moved the cstring include around so that it will compile under gcc 4.3.3. 2009-09-22 22:13:33 +00:00
Harry Moffat
bdac70a563 Moved the cstring include around in order to compile under gcc 4.3.3 2009-09-22 22:09:36 +00:00
John Hewson
330e7666aa Renaming TransportParams member variables nsp_ and mode_. 2009-09-22 18:32:45 +00:00
John Hewson
baa60182c3 Renaming TransportParams member variables nsp_ and mode_. 2009-09-22 18:22:38 +00:00
Harry Moffat
15c9ca0294 Merged Revisision_1.8.0 changes into the trunk. 2009-09-22 17:26:18 +00:00
Harry Moffat
55bd4a766a Sundials 2.4 compatibility.
Added compatibility for sundials 2.4 along the 1.8.0 branch. I'll
add it to the main trunk as well shortly. This hasn't been fully tested
except for the cxx_examples problem.
2009-09-22 16:57:14 +00:00
John Hewson
a76b99e6ff for all of the kinetic-theory-of-gases-related methods supporting the
gas-phase transport, we needed to pass the GasTransportParams rather
than TransportParams.  

We made new methods to initialize liquid transport including
  TransportFactory::setupLiquidTransport()
  TransportFactory::initLiquidTransport()
  TransportFactory::getLiquidTransportData()

Added new struct LiquidTransportData.

Added getArrhenius method copied from kinetics directory to parse
Arrhenius form XML.
2009-09-19 00:35:27 +00:00
John Hewson
ecfc9a71f5 Changed MixTransport::init(TransportParams& tr) to
MixTransport::initGas( GasTransportParams& tr )
2009-09-19 00:26:33 +00:00
John Hewson
00c36ac250 Split the TransportParams class into three entities. The base class
of the same name holds core components including the thermo object,
XML nodes, species names and molecular weights.  

A derived class GasTransportParams holds
kinetic-theory-of-gases-related parameters.  

LiquidTransportParams in LiquidTransportParams.h now derives from
TransportParams class. Removed kinetic-theory-of-gases-related
parameters.
2009-09-19 00:25:57 +00:00
John Hewson
eaeefd4f47 Added forward declarations references to
class LiquidTransportParams;

Changed the init(TransportParams& tr) method to 
initLiquid( LiquidTransportParams& tr ) 

Removed a number of gas-related transport parameters from the
init/initLiquid() method including m_poly, m_diam, m_eps, m_alpha

In AqueousTransport.cpp there was a method to return a struct to a
GasTransportData.  This now returns LiquidTransportData struct, but is
not yet working.

In LiquidTransport.cpp removed all references to m_polytempvec, a
vector of 5 entries of the form
-    m_polytempvec[0] = 1.0;
-    m_polytempvec[1] = m_logt;
-    m_polytempvec[2] = m_logt*m_logt;
-    m_polytempvec[3] = m_logt*m_logt*m_logt;
-    m_polytempvec[4] = m_logt*m_logt*m_logt*m_logt;
We might want these back soon.  This allowed up to comment out the
code in the methods that evaluate the temperature dependence of the
viscosity, thermal conductivity and diffusivity using polynomials in
these variables.  --This line, and those below, will be ignored--

M    AqueousTransport.h
M    LiquidTransport.h
M    AqueousTransport.cpp
M    LiquidTransport.cpp
2009-09-19 00:24:47 +00:00
John Hewson
53e1c8fd78 Added method getSpeciesFluxesES(int ndim,
const doublereal* grad_T, 
				  int ldx, 
				  const doublereal* grad_X,
				  int ldf, 
				  const doublereal* grad_Phi,
				  doublereal* fluxes) 
after passing electrostatic potentialgradient as well as the rest of
the gradients.  

Added initGas( GasTransportParams& tr ) and 
initLiquid( LiquidTransportParams& tr ) because of the different
TranportParams subclasses.  There might be a better way to do this.
2009-09-19 00:21:46 +00:00
Harry Moffat
fc3c2630a3 Fleshing out liquid transport 2009-09-16 22:04:16 +00:00
Harry Moffat
ce79948739 Starting to rough in aqueous transport. 2009-09-16 19:57:45 +00:00
Harry Moffat
2bd7816b65 Added in a model for the thermal conductivity of pure water
at all T and P.
Added in a test for the new model.
2009-09-16 02:13:43 +00:00
Harry Moffat
5009a3817f Added a viscosity model into WaterTransport.cpp for pure water
Added a test problem for the viscosity model.
Updated WaterSSTP object to support the use of WaterTransport 
with the object.
2009-09-15 21:46:44 +00:00
Harry Moffat
53d21aaf7e Moved WaterPropsIAPWS inside the Cantera namespace. I can't remember why it wasn't in the first place.
Added a WaterProps object to PDSS_Water. This object will be worked into all of the other objects , and also used within the transport directory.
2009-09-15 17:32:20 +00:00
Harry Moffat
276602af3a Moved the water viscosity calculation to WaterProps.cpp.
Changed calcDensity to be a virtual function started at VPStandardStateTP().
   It's a protected function as well.
   At the VPStandardStateTP level, calcDensity() produces an error when called, because the EOS isn't specified. Derived classes must define this function, supplying the EOS.

WaterPropsIAPW: I added documentation to this routine, defining what functions changes the state of the object.

IdealMolalSoln: I had forgotten to update this object to employ the newer setState_TP() strategy that I had used in VPStandardStateTP().
2009-09-15 15:01:39 +00:00
Harry Moffat
584ec18c6d Started working in Water transport properties. 2009-09-11 23:37:20 +00:00
Harry Moffat
4c0407870f Fixed an error pointed out by Greg Jackson, concerning
ints vs doubles
2009-09-11 23:36:47 +00:00
Harry Moffat
7e6f2a1775 Latest version of the IonsFromNeutral object. Hopefully, this
clears up the linking errors that VC9 was experiencing.
2009-09-10 22:51:40 +00:00
Harry Moffat
8b728ad95c Specified the standard concentration for this
system so that I can do kinetics with the ThermoPhase object.
For molten salts, we're going with a standard concentration
of 1.0, until there is an argument otherwise. This means
that the kinetics objects, homogeneous and heterogeneous,
 will treat the molten salts as unitless.
2009-09-02 22:45:21 +00:00
Harry Moffat
bf97d0f90a Added the concept of a reference mole fraction vector.
This is a vector that is a baseline "safe" mole fraction
vector that can be applied anywhere. I was running into problems
with specifying this for molten salts, because just setting
the first component to a mole fraction of 1 causes
charge imbalance.

M    thermo/ThermoPhase.h
M    thermo/ThermoPhase.cpp
2009-09-02 22:03:46 +00:00
Harry Moffat
f7e48f0068 Updates for thermoFactory.
IonsFromNeutralMolecule needs special handling.
2009-09-02 19:20:22 +00:00
Harry Moffat
95b94a7a57 Added IonsFromNeutraVPSSTP to the ThermoFactory. 2009-09-02 19:03:26 +00:00
Harry Moffat
06276fba6d Added a new thermo object in.
IonsFromNeutralVPSSTP : This is initially used for molten salts.
        Molten salt thermo is treated via the neutral molecule
        molten salt expressions. However, ions migrate by themselves.
        therefore, you must treat ions within the transport equations.
        This thermophase object treats the ions as species, and is
        made to be consistent with the neutral molecules thermophase
        object that is used to express the non-ideal thermodynamics
        of the molten salt solution. Currently, MargulesVPSSTP
        is used for this as the LiKCl system is parameterized using
        this excess Gibbs free energy formulation.

    MargulesVPSSTP
        Various upgrades and fillers. It now reads and is initiated
        from the input file.

    setState_TP(), setTemperature(), and setPressure() within 
    VPStandardStateTP() formulations
        There was some circular logic, previously. Now setTemperature() and setPressure()
        are subserviant to setState_TP(). Basically, it doesn't make
        sense to calculate the standard state without first getting
        both the temperature and pressure (not just one and then the other)
        before you calculate the standard state for VPStandardStateTP derivatives.
        Think about the water EOS, which is a real fluid. You don't want
        to be trying to calculate the standard state within the enveloppe where
        neither gas nor liquid is stable.

     PseudoBinaryVPSSTP
        Deprecated.
2009-09-02 17:17:52 +00:00
Harry Moffat
6d903bd549 Changed the interface to use an enum quantity. Our namespace is getting
full, and using enums will help us not step on ourselves.
2009-08-19 14:34:22 +00:00
Harry Moffat
ba5852f786 Moved some data to protected status 2009-08-19 14:33:06 +00:00
Harry Moffat
4340e7089e Changed some defines into const variables and put them
within the Cantera namespace. This is needed to 
avoid namespace issues. For example the define BAND interfered
with an mpi variable of the same name.
2009-08-17 01:39:19 +00:00
Harry Moffat
d27a1bc9c5 Added a file that was left out. 2009-08-17 01:35:43 +00:00
Harry Moffat
0c624e5286 Made the data protected in this file.
This is a fairly obvious change to help with modularity.
2009-08-15 17:18:59 +00:00
Harry Moffat
0445c5ec59 Added ifdef's around DATA_PTR. 2009-08-11 20:13:50 +00:00
Harry Moffat
38c73aa215 Added guards against predefinitions of AssertThrows 2009-08-11 18:38:48 +00:00
Harry Moffat
755318323d Took out a warning message on vc++ 2009-08-01 01:34:07 +00:00
Harry Moffat
0f419a7a7a Fixed an error that showed up in the flamespeed demo.
The error was in the file Sim1D:setFixedTemperature().
The error involved an array overwrite.
2009-07-31 23:53:34 +00:00
Harry Moffat
86ea2414d9 Took out .cvsignore file 2009-07-28 16:26:53 +00:00
Harry Moffat
a6a8f6e45b Delete .cvsignore 2009-07-27 23:46:16 +00:00
Harry Moffat
70647c85ed Initial Import 2009-07-27 23:17:19 +00:00
Harry Moffat
98fb3fb998 Fixed a warning message on solaris 2009-07-23 14:41:40 +00:00
Harry Moffat
e7078147b3 Changed xml constructors to make them simpler with less implicit
conversion routines. Trying to figure out what the issue is with
the pc interface's /MD vs /MDd problems.
2009-07-22 01:21:35 +00:00
Harry Moffat
454cfeafc5 Changed CVode.o CVodeInt.o
There was a problem with the sierra port to the mac. Apparently,
the mac doesn't distinguish between cases.
2009-07-17 15:32:50 +00:00
Harry Moffat
16e84c9a5b Took out some debugging stuff that was still in the main distribution 2009-07-13 16:47:40 +00:00
Harry Moffat
ea6a7e9e34 Fixed spacing 2009-07-11 17:35:05 +00:00
Harry Moffat
f697ad4850 Added more namespace information for ReactorNet. There is still something going on here
that causes problems with linking applications.
2009-07-11 17:22:52 +00:00
Harry Moffat
c407243581 suppressed a windows warning 2009-07-11 17:21:20 +00:00
Harry Moffat
86ff7e9314 General commit
- nothing has changed really. just added commented-out writes that I was using
    during the debug process
2009-07-11 17:20:19 +00:00
Harry Moffat
cd16354fd0 Fixed a glaring error concerning the situation where the cti file is
not in the current directory. THe xml file is always written to the
current directory. And the subsequent reading of the xml file must
reflect that. The xml file was trying to be read from the directory
where the cti file was located. Now, the xml file will be read from
the current directory.
2009-07-08 02:54:39 +00:00
Harry Moffat
0badf5e19c Got rid of the matlab write.cpp routine. It was causing linking problems
on the pc.
Cleaned up the comments on loggers and interfaces.
2009-07-06 23:52:40 +00:00
Harry Moffat
60c6fd5c28 Fixed a warning message. 2009-07-06 22:30:58 +00:00
Harry Moffat
14881787d0 Fixed the name of a routine in an error statement. 2009-07-05 23:32:29 +00:00