Ray Speth
201043e98c
[Kinetics] Fix reaction path output when arrow_width > 0
...
Fixes Issue 197.
2013-12-20 19:21:45 +00:00
Ray Speth
28dbcf072e
[Kinetics] Remove the deprecated 'WF93' Falloff function
2013-12-16 23:22:09 +00:00
Ray Speth
e1a49487b7
[Kinetics] Remove deprecated getActivationEnergies function
...
Resolves Issue 147.
2013-12-16 23:21:52 +00:00
Ray Speth
1215f05da7
[Kinetics] Remove deprecated GRI30 class
...
Resolves Issue 134.
2013-12-14 00:17:54 +00:00
Harry Moffat
5720d7cf90
Fixed an error where the users data was changed before it was used.
...
Eliminated some deprecations which were not sanctioned.
Worked on Cantera.mak. There is a problem with scons eliminating $ from strings.
2013-09-06 22:52:59 +00:00
Ray Speth
10aa8ba060
[Kinetics] Allow negative Troe parameters
2013-08-01 18:57:33 +00:00
Ray Speth
77ccab92bd
[Kinetics] Implement evaluation of "chemically activated" reaction rates
2013-07-06 21:44:02 +00:00
Ray Speth
8b87087e41
[Kinetics] Populate m_rxntype
2013-07-06 21:43:56 +00:00
Ray Speth
ef6479f58d
Eliminate special case for default falloff function
2013-07-06 21:43:53 +00:00
Ray Speth
8ded648bf4
Speed up duplicate reaction check in installReactions
...
This version of the "participants" key is more likely to have collisions, but
having the key be a simple scalar speeds things up quite a bit.
2013-06-28 21:24:44 +00:00
Ray Speth
94ac608adb
[Kinetics] Consider third-body efficiencies in duplicate reaction checks
2013-06-21 20:58:02 +00:00
Ray Speth
ac0ccec7f5
Use ReactionData struct to store info in class rxninfo
...
This eliminates the need the data members of class rxninfo that were
just duplicates of what is in the ReactionData struct.
2013-06-21 20:57:53 +00:00
Ray Speth
b3708cdab5
[Kinetics] Allow reactions with A = 0.0
2013-06-17 14:20:30 +00:00
Ray Speth
77ed000090
Deprecate WF93 falloff parameterization
2013-06-13 22:50:30 +00:00
Ray Speth
112d9b5093
Remove unusable KINETICS_WITH_INTERMEDIATE_ZEROED_PHASES macro
2013-06-13 22:50:26 +00:00
Ray Speth
9740980c5d
Deprecate class GRI_30_Kinetics
2013-06-13 22:50:14 +00:00
Ray Speth
305e4eec54
Deprecate Kinetics::activationEnergies
2013-06-06 15:33:00 +00:00
Ray Speth
a6614b87bb
[Doxygen] Fix some incorrect/missing "@file" commands
2013-06-06 15:32:30 +00:00
Ray Speth
11170a0e32
Deprecate class AqueousKinetics
2013-06-05 17:09:59 +00:00
Ray Speth
d253fc0d63
Eliminate redundant standard library includes
2013-06-05 17:08:13 +00:00
Ray Speth
be1e95576e
Resolve some Doxygen warnings
2013-06-05 03:09:13 +00:00
Ray Speth
e43a4a8b3c
Remove unnecessary "APPROACH" macro
2013-05-31 15:55:43 +00:00
Ray Speth
1ed172a4d4
[Kinetics] Lazy evaluation of temperature-dependent terms in rate expression
...
This interacts well with the new formulations for the Reactor governing
equations where T is an independent variable, which means that the
temperature-dependent terms do not need to be updated when computing the
Jacobian terms involving derivative with respect to composition.
2013-05-29 00:11:52 +00:00
Ray Speth
2e26abd4f9
[Kinetics] Fixed a NaN result in falloff reaction rates
...
A NaN result could be caused by an underflow in the high-pressure rate
expression.
2013-05-06 20:05:57 +00:00
Ray Speth
259ceaa9a6
Added assertions to check that some variables remain finite
2013-05-06 20:05:53 +00:00
Ray Speth
0a059d406a
Eliminated unnecessary empty destructors from derived classes
...
See http://www.parashift.com/c++-faq-lite/virtual-dtors.html
2013-04-29 18:04:23 +00:00
Ray Speth
09e873b3bf
[Kinetics] Allow coverage dependencies for edge reactions
2013-04-24 22:49:17 +00:00
Ray Speth
acdf1e3900
Cleaned up Doxygen docs for Stoichiometry Manager classes
2013-04-12 23:06:36 +00:00
Ray Speth
41a23e44d2
Cleaned up Doxygen docs for Reaction path related classes
2013-04-12 23:06:28 +00:00
Ray Speth
c43b02e130
Cleaned up Doxygen docs for KineticsFactory and ImportKinetics
2013-04-12 23:06:20 +00:00
Ray Speth
1909526ba7
Cleaned up Doxygen docs for class solveSP
2013-04-12 23:05:53 +00:00
Ray Speth
68c0270958
Cleaned up Doxygen docs for class ImplicitSurfChem
2013-04-12 23:05:46 +00:00
Ray Speth
76d3a03921
Updated Doxygen documentation for falloff-related classes
2013-04-12 23:05:38 +00:00
Ray Speth
d103ec8d2f
Cleaned up Doxygen documentation for class Kinetics and descendants
2013-04-12 23:05:20 +00:00
Ray Speth
7b7d3ac0d4
Fixed locale-dependent processing of XML files
...
Floating point values are read using a std::stringstream imbued with the "C"
locale to avoid problems with using std::atof when the user's locale uses a
character other than "." as the decimal separator.
Patch provided by Phillip Berndt.
Fixes Issue 153.
2013-04-03 23:10:18 +00:00
Ray Speth
229ef825f0
[Kinetics] Refactored GasKinetics to more easily support derived classes
2013-03-04 17:31:32 +00:00
Ray Speth
8847b5abac
[Kinetics] Ensure that equilibrium constants are not zero
...
This prevents reverse rate constants from becoming NaN when the forward rate
constant underflows.
2013-02-15 17:31:15 +00:00
Ray Speth
934010136d
Removed unnecessary temporaries used for storing return values
2013-02-14 01:04:07 +00:00
Ray Speth
e04e59cdd3
Removed extraneous parentheses around arguments to 'return'
...
'return' is a keyword, not a function, so these parens are unnecessary.
2013-02-14 01:03:48 +00:00
Ray Speth
6d6e237f07
Removed unnecessary checks surrounding delete operations
2013-02-14 01:03:32 +00:00
Ray Speth
a25c1a43b3
[Kinetics] Fixed crashes when reaction mechanism contains no reactions
...
Make sure several arrays are never of length zero so that taking &v[0]
is always well-defined.
2013-02-14 01:02:18 +00:00
Ray Speth
7da738d238
Re-applied consistent formatting to trunk
...
Applied using: astyle -n --style=kr --add-brackets --indent=spaces=4
--indent-col1-comments --unpad-paren --pad-header --align-pointer=type
--lineend=linux
2013-02-07 23:40:59 +00:00
Victor Brunini
a709d5f816
Revert "Removed unused member variable ReactionData.rxn_number"
...
This variable is used in some applications we build against
cantera.
This reverts commit 7d7b6dd39d12c2e2bdd2a9d2a959c0aee3c0c4c5.
2013-01-15 20:16:42 +00:00
Ray Speth
50327a665f
Moved some function implementations out of InterfaceKinetics.h
...
This gets rid of some (mostly spurious) warnings generated by MSVC
2013-01-11 22:56:33 +00:00
Ray Speth
33653e7f43
Removed unused member variable ReactionData.rxn_number
2013-01-11 22:56:30 +00:00
Ray Speth
46a8b3052f
Use size_t instead of int in InterfaceKinetics
2012-12-26 23:56:07 +00:00
Harry Moffat
ea25de7fe7
Continuing transfering LiquidTransport changes, doing bugfixes, and
...
qualifying against our testsuite.
2012-12-15 00:49:14 +00:00
Harry Moffat
c6f7abbf2f
Fixed a serious error in InterfaceKinetics that had crept into this branch.
...
Started upgrade/update of equilibrium solver
- Fixed numerical jacobian calculation of the ln activity coefficients.
2012-11-29 02:18:05 +00:00
Ray Speth
94d08f1d5e
Removed unnecessary casts from object duplication functions
2012-10-24 15:45:33 +00:00
Ray Speth
1d19803885
Pass "const std::string&" instead of "std::string" when possible
2012-10-24 15:42:51 +00:00