Commit graph

699 commits

Author SHA1 Message Date
Ray Speth
aee6cc14ac [Transport] Remove 'name' variable from TransportData
This was used only for validation error messages, but in that case we can just
use the Species object which is available during validation.
2015-04-17 19:06:43 -04:00
Ray Speth
7d170a9989 [Thermo] newSpeciesThermoInterpType argument is the 'thermo' XML node
No data from the outer 'species' node is needed to instantiate the
SpeciesThermoInterpType object, so this function can just take the 'thermo' node
directly.
2015-04-17 19:06:43 -04:00
Ray Speth
1b0970a494 [Thermo] Remove species name argument from STIT factory functions
This argument was used only in error messages, which can be reported more
uniformly if implemented at a higher level.
2015-04-17 19:06:43 -04:00
Ray Speth
ec1d7d7382 Fix compilier warnings about unused variables 2015-04-14 16:08:10 -04:00
Ray Speth
d1cda15f42 Improve performance of importing phases
Replace the O(k) implementation of Phase::speciesIndex with one that is
O(log(k)). This function is called frequently as part of Kinetics object
initialization. Optimize for the more common case where the species name is not
qualified with a phase name.
2015-04-14 15:29:28 -04:00
Ray Speth
bde0f1466d [Thermo] Add index-based accessor for Species objects 2015-04-14 15:29:28 -04:00
Ray Speth
882a4986da Remove 'thermo' argument from Species constructor
Since the Species object now stores its SpeciesThermoInterpType contents as a
shared_ptr, it is undesirable to have the Species constructor take this as a raw
pointer argument.
2015-04-14 15:29:28 -04:00
Ray Speth
43952b30fc [Thermo] Use shared_ptr<Species> in ThermoPhase 2015-04-14 15:29:28 -04:00
Ray Speth
8f36e524fe Do species indexing in GeneralSpeciesThermo instead of STIT
This means that GeneralSpeciesThermo no longer modifies the
SpeciesThermoInterpType objects, permitting them to be shared between
ThermoPhase objects.
2015-04-14 15:29:28 -04:00
Ray Speth
5195e4f9b8 [Thermo] Use shared_ptr to STIT objects in Species and SpeciesThermo
Exclusive ownership of the SpeciesThermoInterpType objects is no longer assumed.
2015-04-14 15:29:28 -04:00
Ray Speth
35dbe37bf7 [Thermo] Deprecate SpeciesThermo::install
The install_STIT method should be used instead.
2015-04-14 15:29:28 -04:00
Ray Speth
a1599ac921 [Thermo] Add 'index' argument to GeneralSpeciesThermo::install_STIT
This is a prerequisite to removing the species index as a property of the
SpeciesThermoInterpType object and making it independent of any specific
ThermoPhase object.
2015-04-14 15:29:28 -04:00
Ray Speth
1dd7b214b5 [Thermo] Deprecate unused method 'getUnitsStandardConc'
First step in resolving Issue #96
2015-04-14 15:18:20 -04:00
Ray Speth
c540e67d50 [Thermo] Deprecate non-functional 'testProb' constructors
These "test problem" constructors don't actually do anything, and most of them
can't be used because the corresponding input files don't exist.
2015-04-09 19:04:08 -04:00
Ray Speth
23ad04f882 [Transport] Deprecate non-functional AqueousTransport class
This class has been broken since 2009. Note the vectors m_visccoeffs,
m_condcoeffs, and m_diffcoeffs, which are used but never initialized.
2015-04-09 18:54:05 -04:00
Ray Speth
f59bcdf057 [Thermo/Doc] Fix incorrect SurfPhase docstrings
These docstrings were just copied from unimplemented virtual methods in class
ThermoPhase.
2015-04-08 19:44:16 -04:00
Ray Speth
ecb6242b79 Fix spelling errors 2015-04-08 19:36:55 -04:00
Ray Speth
c757c3bc76 Add include guard to smart_ptr.h 2015-03-10 22:41:53 +00:00
Ray Speth
838f435ca9 [Kinetics] Deprecate class ExchangeCurrent
Unused duplicate of class Arrhenius
2015-03-10 22:41:29 +00:00
Ray Speth
603e321a37 [Cython] Fix treatment of writelogendl()
Both writelog and writelogendl should be passed through PySys_WriteStdout to
ensure that they are printed in the correct order. Problems with this were
identified in the 1D solver log when using Python 3.
2015-02-28 00:24:29 +00:00
Ray Speth
7cdeedb91b [Transport] Provide transitional 'TransportFactory::initTransport'
There are user-provided classes derived from GasTransport which still call this
method, so a version of it that calls the new method for initializing
GasTransport objects needs to be provided until after Cantera 2.2.
2015-02-26 21:59:37 +00:00
Ray Speth
2e53890adf Minor cleanup of constructors and destructors 2015-02-26 21:58:42 +00:00
Ray Speth
5592a52e0f Remove unnecessary use of 'extern' 2015-02-26 21:54:11 +00:00
Ray Speth
cf3ad30537 [Kinetics] Changing a rate multiplier invalidates existing ROPs 2015-02-26 21:54:04 +00:00
Ray Speth
cc17716182 Cleanup trailing whitespace 2015-02-26 21:52:52 +00:00
Ray Speth
60c221c845 [Kinetics] Combine ThirdBodyMgr and Enhanced3BConc as ThirdBodyCalc
The old classes are now deprecated. The name change was needed to avoid
collisions with no-longer-necessary template parameter.
2015-02-20 23:44:41 +00:00
Ray Speth
dab74d2d10 [Thermo] Deprecate mean_Y and sum_xlogQ methods of class Phase 2015-02-20 23:44:36 +00:00
Ray Speth
2ed8552939 [Thermo] Add a version of Phase::mean_X that takes vector_fp
This simplifies all internal calls to this function
2015-02-20 23:44:21 +00:00
Ray Speth
0ad8d45baf [Thermo] Deprecate classes PseudoBinaryVPSSTP and electrodeElectron 2015-02-20 23:43:29 +00:00
Ray Speth
09ce99dc83 [Thermo] Eliminate redundant assignment of m_kk
m_kk is automatically set as species are added to a phase.
2015-02-20 23:43:12 +00:00
Ray Speth
42e7061bd8 [Thermo] Remove unnecessary counter variables
These counter variables just stored the length of another std::vector
member variable.
2015-02-20 23:43:04 +00:00
Ray Speth
17bb09a2da [Equil] Remove unused member variables from VCS_SPECIES_THERMO 2015-02-20 23:42:54 +00:00
Ray Speth
b4492cb8a3 [Thermo] Whitespace cleanup in MaskellSolidSolnPhase 2015-02-20 00:11:30 +00:00
Thomas Fiala
4bc4fda90c Add C++ and Cython support for computing elemental mass/mole fractions 2015-02-17 23:23:51 +00:00
Ray Speth
170d50676a [Doc] Document definition of the sensitivity coefficient 2015-02-12 04:04:55 +00:00
Ray Speth
71d57330b6 [Thermo] Deprecate methods of IdealGasPhase that only worked for StatMech 2015-02-12 04:04:51 +00:00
Ray Speth
efb80dfe05 Remove unnecessary delimiter lines between functions
A single line of white space is sufficient and consistent. Also moved a couple
Doxygen strings out of source files.
2015-01-22 00:04:24 +00:00
Ray Speth
0a3332aa43 [Thermo] Add simpler constructors for SpeciesThermoInterpType objects
These objects do not need to know the index of the species within the phase, so
the new constructors do not take that as an argument.

For the NASA polynomial constructors, the order of the coefficients arrays in
the new constructors has been modified to match the conventional ordering of the
coefficients as written in thermo database files.
2015-01-22 00:04:06 +00:00
Ray Speth
598e47d644 [Thermo] NasaPoly1 stores coefficients in the conventional order 2015-01-22 00:04:03 +00:00
Ray Speth
b63d759918 [1D] Remove unused members of class StFlow 2015-01-15 21:15:24 +00:00
Ray Speth
af447cb85f [1D] Avoid repeated search for indices of radiating species
Also, look for both uppercase and lowercase species names
2015-01-15 21:15:20 +00:00
Ray Speth
bade514587 [1D] Fix up getters/setters/default values for radiation values 2015-01-15 21:15:18 +00:00
Andreas Rücker
49c963143e [1D] Add simple radiation model for flames
Implements the radiation model of Liu & Rogg (1991). Optically thin limit,
gray-gas approximation using Planck mean absorption coefficients. Considers
emissions from CO2 and H2O, with the temperature-dependent absorption
coefficients calculated using polynomial fits to results from RADCAL
(Grosshandler, 1993).
2015-01-15 21:15:15 +00:00
Ray Speth
217a001a08 [Doc] Correct title of "Chemically Reacting Flow" 2015-01-15 21:15:12 +00:00
Ray Speth
ad1cd8c7bb Remove unnecessary numerical constants 2015-01-15 21:15:07 +00:00
Ray Speth
fdf7db716e [Transport] Construct gas phase Transport without GasTransportParams
Since most of the members of class GasTransportParams were copied to
MixTransport or MultiTransport, they have instead been made members of
GasTransport and populated directly, making class GasTransportParams
unnecessary.
2015-01-13 23:07:00 +00:00
Ray Speth
bdc568d416 [Transport] Make constructors for MixTransport and MultiTransport public 2015-01-13 23:06:57 +00:00
Ray Speth
94d924e32d [Transport] Use gas transport data from Species objects
This makes initialization of GasTransport objectsindependent of the XML input
format.
2015-01-08 23:36:26 +00:00
Ray Speth
2a50dc50f7 [Thermo] Add accessor for Species objects 2015-01-08 23:36:24 +00:00
Ray Speth
8022e9e01e [Transport] Add gas phase transport parameters to Species objects 2015-01-08 23:36:22 +00:00