research/cantera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
5998 commits 2 branches 16 tags 37 MiB
Commit graph

49 commits

Author SHA1 Message Date
Ray Speth
bec0c88e32 [Thermo] Remove unnecessary overloads of getElectrochemPotentials 2016-03-27 23:18:26 -04:00
Ray Speth
4382ae6c85 Clean up comments in Thermo class source files 2015-11-09 17:34:46 -05:00
Ray Speth
3f6d8b0aca Use cppformat instead of int2str and fp2str 2015-10-14 18:45:23 -04:00
Ray Speth
7bcbbaafd9 [Thermo] Use consistent implementation for convenience constructors 
The constructor with the signature (inputFile, [id]) just calls initThermoFile.
The constructor with the signature (phase XML node, [id]) just calls importPhase
(note that the id argument is unused, since the correct XML node must already be
given).
 2015-08-05 12:34:22 -04:00
Ray Speth
ceefc5ecb0 Consistently use ThermoPhase::RT() 2015-08-02 23:06:16 -04:00
Ray Speth
acdf9cf0ed Clean up interstitial whitespace 
Remove extra space around operators, between words, etc.
 2015-08-02 23:06:16 -04:00
Ray Speth
e4c45b6429 General whitespace cleanup 
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
 2015-08-02 23:06:15 -04:00
Ray Speth
f219b49e63 Remove unnecessary newlines in function signatures 2015-08-02 23:06:15 -04:00
Ray Speth
c3c80f79fb Remove extraneous parentheses 2015-08-02 23:06:14 -04:00
Ray Speth
d4299fc6da [Test] Fix VCS-LiSi test to not use deprecated "testProb" constructor 2015-07-15 11:35:22 -04:00
Ray Speth
5214672ab3 Merge namespace ctml with namespace Cantera 2015-05-27 18:09:07 -04:00
Ray Speth
341b137766 [Doc] Capitalize proper nouns and acronyms 2015-05-25 20:58:44 -04:00
Ray Speth
c540e67d50 [Thermo] Deprecate non-functional 'testProb' constructors 
These "test problem" constructors don't actually do anything, and most of them
can't be used because the corresponding input files don't exist.
 2015-04-09 19:04:08 -04:00
Ray Speth
cc17716182 Cleanup trailing whitespace 2015-02-26 21:52:52 +00:00
Ray Speth
09ce99dc83 [Thermo] Eliminate redundant assignment of m_kk 
m_kk is automatically set as species are added to a phase.
 2015-02-20 23:43:12 +00:00
Ray Speth
7acf0378c6 [Thermo] Improve usage of local variables 
Also eliminate some unnecessary temporary variables.
 2015-02-12 04:04:18 +00:00
Ray Speth
efb80dfe05 Remove unnecessary delimiter lines between functions 
A single line of white space is sufficient and consistent. Also moved a couple
Doxygen strings out of source files.
 2015-01-22 00:04:24 +00:00
Ray Speth
b8a99b4b83 Remove unnecessary explicit calls to default constructors 2015-01-22 00:04:12 +00:00
Ray Speth
002c158761 Cleanup include statements 
Move includes from header to implementation files where possible, and remove
unnecessary includes.
 2014-08-28 16:54:13 +00:00
Ray Speth
789574ac80 Remove commented-out code 2014-05-27 02:52:21 +00:00
Ray Speth
2a9ab96609 Use NotImplementedError instead of 'err' member functions 2014-05-06 14:39:13 +00:00
Harry Moffat
96b01a6c79 Added better error handling for the XML routine. 
Added a couple of TODOs
 2014-04-19 01:31:21 +00:00
Ray Speth
3530050dc4 [Thermo] Remove redundant overrides of ThermoPhase::eosType() 2014-03-28 23:12:53 +00:00
Ray Speth
95eb7ab3ba Remove newline after '::' in member function definitions 
This inconsistency makes it hard to directly search the code for a specific
member function definition.
 2014-03-24 04:03:09 +00:00
Ray Speth
6f8da1a27e Fix 'unused variable' warnings 2014-02-21 19:08:33 +00:00
Ray Speth
0a059d406a Eliminated unnecessary empty destructors from derived classes 
See http://www.parashift.com/c++-faq-lite/virtual-dtors.html
 2013-04-29 18:04:23 +00:00
Ray Speth
af55ec5557 [Thermo] Fixed an error in MargulesVPSSTP::s_update_dlnActCoeff_dT 
This error was introduced in r1968, but it was masked by an issue with the code
used to compare test results.
 2013-04-24 21:47:45 +00:00
Ray Speth
4e3a79394b Eliminated some shadowing of member variables by function arguments 2013-02-14 01:03:19 +00:00
Ray Speth
8a17523715 Use the "charge" member function consistently to access species charges 
Eliminated local alias to array of charges in some functions. Inlined the
"charge" function to mitigate any performance impact. Fixes a number of shadowed
variable warnings.
 2013-02-14 01:03:09 +00:00
Ray Speth
da33cc66c3 Cleaned up Doxygen docs for class VPStandardStateTP and descendants 2013-02-14 01:02:34 +00:00
Ray Speth
7da738d238 Re-applied consistent formatting to trunk 
Applied using: astyle -n --style=kr --add-brackets --indent=spaces=4
--indent-col1-comments --unpad-paren --pad-header --align-pointer=type
--lineend=linux
 2013-02-07 23:40:59 +00:00
Ray Speth
d4525f0db7 Removed unused local variables from MargulesVPSSTP 2013-01-11 22:56:37 +00:00
Ray Speth
83097b3860 Consolidated definitions of repeatedly-used constants 
"MIN_X" and "TINY" are replaced by "Tiny". "xxSmall" is replaced with
"SmallNumber".
 2013-01-11 22:55:46 +00:00
Victor Brunini
d4d1093957 Performance improvements focused on Stefan-Maxwell liquid transport 
model for molten salts.

Summary:
- Division is expensive, replace repeated division with multiplication
  by stored 1/x.
- New and delete are expensive, make working vectors in some functions
  static so that they are not repeatedly instantiated and deleted.
- Reorder a few loops to reduce computation and hopefully cache misses.
 2012-12-13 22:14:36 +00:00
Ray Speth
94d08f1d5e Removed unnecessary casts from object duplication functions 2012-10-24 15:45:33 +00:00
Ray Speth
1d19803885 Pass "const std::string&" instead of "std::string" when possible 2012-10-24 15:42:51 +00:00
Ray Speth
577f3c28f7 Removed constructPhaseFile and constructPhaseXML methods from MargulesVPSSTP 2012-08-08 22:16:33 +00:00
Ray Speth
d16f70ab44 Fixed some spelling issues 2012-04-04 18:44:24 +00:00
Ray Speth
8ea4ae728a Moved a few standard library includes to more local scopes 2012-03-23 22:16:04 +00:00
Ray Speth
78a093b485 Folded class Constituents into class Phase 2012-03-09 22:56:11 +00:00
Ray Speth
3bff32dd55 Fixed problems that generated warnings with the Intel compiler 2012-03-07 00:51:13 +00:00
Ray Speth
236756fbf0 Removed rogue tabs in the C++ source code 2012-02-27 18:15:02 +00:00
Ray Speth
35429de71c Fixed a bunch of spelling errors in the documentation and comments 2012-02-21 16:04:09 +00:00
Ray Speth
fe8a5d49a8 Use std::min and std::max instead of homegrown alternatives 2012-02-21 16:03:32 +00:00
Ray Speth
e8b04fb2b4 Fixed numerous compiler warnings from MSVC 2012-02-17 20:29:10 +00:00
Ray Speth
9bc4a261c7 Fixed a bunch of GCC warnings 2012-02-15 20:28:08 +00:00
Ray Speth
c31e48cfb3 Variable-size arrays are not part of the C++ standard 2012-02-12 02:46:57 +00:00
Ray Speth
a310345b9e Updated #includes to reflect new header file locations 2012-02-12 02:44:14 +00:00
Ray Speth
2528df0f75 Reorganized source tree structure 
These changes make it unnecessary to copy header files around during
the build process, which tends to confuse IDEs and debuggers. The
headers which comprise Cantera's external C++ interface are now in
the 'include' directory.

All of the samples and demos are now in the 'samples' subdirectory.
 2012-02-12 02:27:14 +00:00
Renamed from Cantera/src/thermo/MargulesVPSSTP.cpp (Browse further)