Commit graph

1401 commits

Author SHA1 Message Date
Harry Moffat
7e6f2a1775 Latest version of the IonsFromNeutral object. Hopefully, this
clears up the linking errors that VC9 was experiencing.
2009-09-10 22:51:40 +00:00
Harry Moffat
8b728ad95c Specified the standard concentration for this
system so that I can do kinetics with the ThermoPhase object.
For molten salts, we're going with a standard concentration
of 1.0, until there is an argument otherwise. This means
that the kinetics objects, homogeneous and heterogeneous,
 will treat the molten salts as unitless.
2009-09-02 22:45:21 +00:00
Harry Moffat
bf97d0f90a Added the concept of a reference mole fraction vector.
This is a vector that is a baseline "safe" mole fraction
vector that can be applied anywhere. I was running into problems
with specifying this for molten salts, because just setting
the first component to a mole fraction of 1 causes
charge imbalance.

M    thermo/ThermoPhase.h
M    thermo/ThermoPhase.cpp
2009-09-02 22:03:46 +00:00
Harry Moffat
f7e48f0068 Updates for thermoFactory.
IonsFromNeutralMolecule needs special handling.
2009-09-02 19:20:22 +00:00
Harry Moffat
95b94a7a57 Added IonsFromNeutraVPSSTP to the ThermoFactory. 2009-09-02 19:03:26 +00:00
Harry Moffat
06276fba6d Added a new thermo object in.
IonsFromNeutralVPSSTP : This is initially used for molten salts.
        Molten salt thermo is treated via the neutral molecule
        molten salt expressions. However, ions migrate by themselves.
        therefore, you must treat ions within the transport equations.
        This thermophase object treats the ions as species, and is
        made to be consistent with the neutral molecules thermophase
        object that is used to express the non-ideal thermodynamics
        of the molten salt solution. Currently, MargulesVPSSTP
        is used for this as the LiKCl system is parameterized using
        this excess Gibbs free energy formulation.

    MargulesVPSSTP
        Various upgrades and fillers. It now reads and is initiated
        from the input file.

    setState_TP(), setTemperature(), and setPressure() within 
    VPStandardStateTP() formulations
        There was some circular logic, previously. Now setTemperature() and setPressure()
        are subserviant to setState_TP(). Basically, it doesn't make
        sense to calculate the standard state without first getting
        both the temperature and pressure (not just one and then the other)
        before you calculate the standard state for VPStandardStateTP derivatives.
        Think about the water EOS, which is a real fluid. You don't want
        to be trying to calculate the standard state within the enveloppe where
        neither gas nor liquid is stable.

     PseudoBinaryVPSSTP
        Deprecated.
2009-09-02 17:17:52 +00:00
Harry Moffat
6d903bd549 Changed the interface to use an enum quantity. Our namespace is getting
full, and using enums will help us not step on ourselves.
2009-08-19 14:34:22 +00:00
Harry Moffat
ba5852f786 Moved some data to protected status 2009-08-19 14:33:06 +00:00
Harry Moffat
4340e7089e Changed some defines into const variables and put them
within the Cantera namespace. This is needed to 
avoid namespace issues. For example the define BAND interfered
with an mpi variable of the same name.
2009-08-17 01:39:19 +00:00
Harry Moffat
d27a1bc9c5 Added a file that was left out. 2009-08-17 01:35:43 +00:00
Harry Moffat
0c624e5286 Made the data protected in this file.
This is a fairly obvious change to help with modularity.
2009-08-15 17:18:59 +00:00
Harry Moffat
0445c5ec59 Added ifdef's around DATA_PTR. 2009-08-11 20:13:50 +00:00
Harry Moffat
38c73aa215 Added guards against predefinitions of AssertThrows 2009-08-11 18:38:48 +00:00
Harry Moffat
755318323d Took out a warning message on vc++ 2009-08-01 01:34:07 +00:00
Harry Moffat
0f419a7a7a Fixed an error that showed up in the flamespeed demo.
The error was in the file Sim1D:setFixedTemperature().
The error involved an array overwrite.
2009-07-31 23:53:34 +00:00
Harry Moffat
86ea2414d9 Took out .cvsignore file 2009-07-28 16:26:53 +00:00
Harry Moffat
a6a8f6e45b Delete .cvsignore 2009-07-27 23:46:16 +00:00
Harry Moffat
70647c85ed Initial Import 2009-07-27 23:17:19 +00:00
Harry Moffat
98fb3fb998 Fixed a warning message on solaris 2009-07-23 14:41:40 +00:00
Harry Moffat
e7078147b3 Changed xml constructors to make them simpler with less implicit
conversion routines. Trying to figure out what the issue is with
the pc interface's /MD vs /MDd problems.
2009-07-22 01:21:35 +00:00
Harry Moffat
454cfeafc5 Changed CVode.o CVodeInt.o
There was a problem with the sierra port to the mac. Apparently,
the mac doesn't distinguish between cases.
2009-07-17 15:32:50 +00:00
Harry Moffat
16e84c9a5b Took out some debugging stuff that was still in the main distribution 2009-07-13 16:47:40 +00:00
Harry Moffat
ea6a7e9e34 Fixed spacing 2009-07-11 17:35:05 +00:00
Harry Moffat
f697ad4850 Added more namespace information for ReactorNet. There is still something going on here
that causes problems with linking applications.
2009-07-11 17:22:52 +00:00
Harry Moffat
c407243581 suppressed a windows warning 2009-07-11 17:21:20 +00:00
Harry Moffat
86ff7e9314 General commit
- nothing has changed really. just added commented-out writes that I was using
    during the debug process
2009-07-11 17:20:19 +00:00
Harry Moffat
cd16354fd0 Fixed a glaring error concerning the situation where the cti file is
not in the current directory. THe xml file is always written to the
current directory. And the subsequent reading of the xml file must
reflect that. The xml file was trying to be read from the directory
where the cti file was located. Now, the xml file will be read from
the current directory.
2009-07-08 02:54:39 +00:00
Harry Moffat
0badf5e19c Got rid of the matlab write.cpp routine. It was causing linking problems
on the pc.
Cleaned up the comments on loggers and interfaces.
2009-07-06 23:52:40 +00:00
Harry Moffat
60c6fd5c28 Fixed a warning message. 2009-07-06 22:30:58 +00:00
Harry Moffat
14881787d0 Fixed the name of a routine in an error statement. 2009-07-05 23:32:29 +00:00
Harry Moffat
e324daa193 Added another way to set the tmp dir. 2009-07-05 23:18:01 +00:00
Harry Moffat
800e557f6f Reformatted comments. 2009-07-05 18:07:18 +00:00
Harry Moffat
1e056e1274 Added doxygen comments. 2009-05-31 16:24:35 +00:00
Harry Moffat
e44b49ecae Added some doxygen commentary.
Changed a param to a const param
2009-05-28 23:08:06 +00:00
Harry Moffat
86e0e08154 Eliminated a definate memory leak in the ReactorNet object 2009-05-13 21:49:11 +00:00
Harry Moffat
7f5d7efd87 Eliminated a possible source of leaks. not sure about this one. 2009-05-13 21:47:45 +00:00
Harry Moffat
9d3980324f Changed one member function to a const member function 2009-04-22 00:33:35 +00:00
Harry Moffat
a5103167dd Algorithm improvements in the equilibrium solver. 2009-04-18 00:42:47 +00:00
Harry Moffat
973d12f864 Working towards fixing an algorithm bug 2009-04-17 01:08:44 +00:00
Harry Moffat
d560ccd175 Working towards fixing an algorithm bug. 2009-04-17 00:40:48 +00:00
Harry Moffat
a78e0d5e6f Added 2 h's 2009-04-04 03:08:28 +00:00
Harry Moffat
215cea0d1b Fixed silly error that didn't show up on linux, but did show up on
ubuntu.
2009-04-02 14:24:05 +00:00
Harry Moffat
167502481e reduced the printout acc. 2009-04-01 01:16:40 +00:00
Harry Moffat
89d8691747 General commit
Making some progress on the windows version, but not finished.
2009-03-28 03:07:23 +00:00
Harry Moffat
5bea0f92cc A couple of changes in code that isn't turned on atm. 2009-03-27 23:39:26 +00:00
Harry Moffat
36cdd708a1 Updated some variables that were in an indef block. 2009-03-27 22:36:20 +00:00
Harry Moffat
7d7a9315fa General commit due to windows port. 2009-03-27 21:32:32 +00:00
Harry Moffat
b0884a7bad Modified files to get a better agreement with const. 2009-03-27 18:24:39 +00:00
Harry Moffat
2de448e90f Fixed a windows error. 2009-03-27 01:08:55 +00:00
Harry Moffat
c4631a9836 Removed some WIN32 warnings. 2009-03-27 00:51:38 +00:00