research/cantera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
5699 commits 2 branches 16 tags 37 MiB
Commit graph

46 commits

Author SHA1 Message Date
Ray Speth
6cc5652de6 Remove commented-out code 2015-07-20 17:20:46 -04:00
Ray Speth
bf2ceed60e Remove some leftover debugging ifdefs 2015-07-20 15:47:17 -04:00
Ray Speth
217d780233 Fix calls to CanteraError with blank or incorrect first argument 
The first argument should be the function name from which the exception was
thrown. Leaving this blank makes it difficult to track down the location of the
exception.
 2015-06-09 12:03:57 -04:00
Ray Speth
341b137766 [Doc] Capitalize proper nouns and acronyms 2015-05-25 20:58:44 -04:00
Ray Speth
2ed8552939 [Thermo] Add a version of Phase::mean_X that takes vector_fp 
This simplifies all internal calls to this function
 2015-02-20 23:44:21 +00:00
Ray Speth
09ce99dc83 [Thermo] Eliminate redundant assignment of m_kk 
m_kk is automatically set as species are added to a phase.
 2015-02-20 23:43:12 +00:00
Ray Speth
42e7061bd8 [Thermo] Remove unnecessary counter variables 
These counter variables just stored the length of another std::vector
member variable.
 2015-02-20 23:43:04 +00:00
Ray Speth
7acf0378c6 [Thermo] Improve usage of local variables 
Also eliminate some unnecessary temporary variables.
 2015-02-12 04:04:18 +00:00
Ray Speth
b8a99b4b83 Remove unnecessary explicit calls to default constructors 2015-01-22 00:04:12 +00:00
Ray Speth
55fab6ca83 Deprecate unused return value of importPhase 2014-10-03 22:15:08 +00:00
Ray Speth
712293e415 Change debug code to avoid ifdefs where possible 
Use "if (DEBUG_MODE_ENABLED)" instead of "#ifdef DEBUG_MODE". This makes
it easier to see the flow control logic, and the compiler will optimize
out the always-false conditionals when DEBUG_MODE_ENABLED is 0, so there
isn't any speed penalty.
 2014-05-27 02:53:22 +00:00
Ray Speth
789574ac80 Remove commented-out code 2014-05-27 02:52:21 +00:00
Harry Moffat
675df76b1c Fixed a long standing problem with the combination of storred XML files and duplicator functions. 
Now the complete XML file is storred within the ThermPhase object starting with the root node.
This is needed for later processing of kinetics and transport mechanisms when the ThermoPhase
file is duplicated and the original file is deleted.

xml() is now a const function, and still returns the same pointer.
setXMLdata() is a new function will stores the xml data.
 2014-05-20 19:02:20 +00:00
Ray Speth
2a9ab96609 Use NotImplementedError instead of 'err' member functions 2014-05-06 14:39:13 +00:00
Ray Speth
f1066aa072 [Thermo] Remove redundant versions of intEnergy_mole and gibbs_mole 2014-03-27 01:29:13 +00:00
Ray Speth
95eb7ab3ba Remove newline after '::' in member function definitions 
This inconsistency makes it hard to directly search the code for a specific
member function definition.
 2014-03-24 04:03:09 +00:00
Ray Speth
d253fc0d63 Eliminate redundant standard library includes 2013-06-05 17:08:13 +00:00
Ray Speth
934010136d Removed unnecessary temporaries used for storing return values 2013-02-14 01:04:07 +00:00
Ray Speth
6d6e237f07 Removed unnecessary checks surrounding delete operations 2013-02-14 01:03:32 +00:00
Ray Speth
4e3a79394b Eliminated some shadowing of member variables by function arguments 2013-02-14 01:03:19 +00:00
Ray Speth
70b08a6891 Eliminated some local variable shadowing 2013-02-14 01:03:13 +00:00
Ray Speth
da33cc66c3 Cleaned up Doxygen docs for class VPStandardStateTP and descendants 2013-02-14 01:02:34 +00:00
Ray Speth
7da738d238 Re-applied consistent formatting to trunk 
Applied using: astyle -n --style=kr --add-brackets --indent=spaces=4
--indent-col1-comments --unpad-paren --pad-header --align-pointer=type
--lineend=linux
 2013-02-07 23:40:59 +00:00
Ray Speth
83097b3860 Consolidated definitions of repeatedly-used constants 
"MIN_X" and "TINY" are replaced by "Tiny". "xxSmall" is replaced with
"SmallNumber".
 2013-01-11 22:55:46 +00:00
Harry Moffat
eab8781ea7 Added back ability to get transport parameters from transport objects. 
Added back read and write of named XML array blocks.
Fixed an error in IonsFromNeutralVPSSTP.
 2012-12-21 01:18:28 +00:00
Victor Brunini
95e66cd5ff Get rid of static variables in member functions. 2012-12-17 16:14:14 +00:00
Harry Moffat
ea25de7fe7 Continuing transfering LiquidTransport changes, doing bugfixes, and 
qualifying against our testsuite.
 2012-12-15 00:49:14 +00:00
Victor Brunini
d4d1093957 Performance improvements focused on Stefan-Maxwell liquid transport 
model for molten salts.

Summary:
- Division is expensive, replace repeated division with multiplication
  by stored 1/x.
- New and delete are expensive, make working vectors in some functions
  static so that they are not repeatedly instantiated and deleted.
- Reorder a few loops to reduce computation and hopefully cache misses.
 2012-12-13 22:14:36 +00:00
Harry Moffat
08a41f191c Added back constructPhaseFile() and constructPhaseXML(). 
All molten salt problems were broken and some brine problems were broken.
 2012-11-07 23:51:30 +00:00
Victor Brunini
7c70568bb3 Clean up compiler warnings. 2012-11-07 21:08:56 +00:00
Ray Speth
94d08f1d5e Removed unnecessary casts from object duplication functions 2012-10-24 15:45:33 +00:00
Ray Speth
1d19803885 Pass "const std::string&" instead of "std::string" when possible 2012-10-24 15:42:51 +00:00
Ray Speth
b860262fae Removed constructPhaseFile and constructPhaseXML methods from IonsFromNeutralVPSSTP 2012-08-08 22:16:16 +00:00
Harry Moffat
25ba149aab Sorry for monolithic commit. Will break it up in the future. 
Moved the external libraries to separate library files so that libcantera.a just contains its own namespace externals.

Fixed several errors in the equilibrium program that occurred during the port. (int to size_t issues).

Moved some equilibrium program headers to the include file system, so that it can link with equilibrium program.

Worked on Cantera.mak. Needs more work.

Fixed an issue with the Residual virtual base classes within numerics. They didn't inherit due to int to size_t migration. This caused numerous test problems to fail (issue with backwards compatibility - do we want it and how much do we want?).

Added csvdiff back so that it's available for shell environment runtests.
 2012-04-05 00:24:31 +00:00
Ray Speth
d16f70ab44 Fixed some spelling issues 2012-04-04 18:44:24 +00:00
Ray Speth
8ea4ae728a Moved a few standard library includes to more local scopes 2012-03-23 22:16:04 +00:00
Ray Speth
78a093b485 Folded class Constituents into class Phase 2012-03-09 22:56:11 +00:00
Ray Speth
e41f43300f Folded class State into class Phase 2012-03-09 22:55:34 +00:00
Ray Speth
3bff32dd55 Fixed problems that generated warnings with the Intel compiler 2012-03-07 00:51:13 +00:00
Ray Speth
35429de71c Fixed a bunch of spelling errors in the documentation and comments 2012-02-21 16:04:09 +00:00
Ray Speth
fe8a5d49a8 Use std::min and std::max instead of homegrown alternatives 2012-02-21 16:03:32 +00:00
Ray Speth
30d233474a Use std::min and std::max instead of preprocessor macros 2012-02-21 16:03:09 +00:00
Ray Speth
e8b04fb2b4 Fixed numerous compiler warnings from MSVC 2012-02-17 20:29:10 +00:00
Ray Speth
9bc4a261c7 Fixed a bunch of GCC warnings 2012-02-15 20:28:08 +00:00
Ray Speth
a310345b9e Updated #includes to reflect new header file locations 2012-02-12 02:44:14 +00:00
Ray Speth
2528df0f75 Reorganized source tree structure 
These changes make it unnecessary to copy header files around during
the build process, which tends to confuse IDEs and debuggers. The
headers which comprise Cantera's external C++ interface are now in
the 'include' directory.

All of the samples and demos are now in the 'samples' subdirectory.
 2012-02-12 02:27:14 +00:00
Renamed from Cantera/src/thermo/IonsFromNeutralVPSSTP.cpp (Browse further)