research/cantera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
5166 commits 2 branches 16 tags 37 MiB
Commit graph

36 commits

Author SHA1 Message Date
Harry Moffat
6741d8f7c6 InterfaceKinetics rewrite -> addition of general BV reactions and affinity formulation. 2014-08-12 23:02:47 +00:00
Harry Moffat
199cd4ceba Changes in InterfaceKinetics to allow for downstream hooks to add in the capability to model 
arbitrarily fit open circuit potentials for intercalating electrodes.
 2014-06-05 22:43:41 +00:00
Ray Speth
b5396837b2 Make use of std::min, std::max, and clip 2014-06-03 16:52:43 +00:00
Ray Speth
789574ac80 Remove commented-out code 2014-05-27 02:52:21 +00:00
Harry Moffat
675df76b1c Fixed a long standing problem with the combination of storred XML files and duplicator functions. 
Now the complete XML file is storred within the ThermPhase object starting with the root node.
This is needed for later processing of kinetics and transport mechanisms when the ThermoPhase
file is duplicated and the original file is deleted.

xml() is now a const function, and still returns the same pointer.
setXMLdata() is a new function will stores the xml data.
 2014-05-20 19:02:20 +00:00
John Hewson
b84f19c439 In InterfaceKinetics added some comments and clarified function names. 
Formerly getExchangeCurrentQuantities() is now
updateExchangeCurrentQuantities().  This method updates things like
m_StandardConc for computing reaction rates.

Formerly applyExchangeCurrentDensityFormulation() is now
convertExchangeCurrentDensityFormulation().  This method converts
rate expressions from A/m2 to kmol/m2/s.
 2014-04-22 22:25:59 +00:00
Ray Speth
95eb7ab3ba Remove newline after '::' in member function definitions 
This inconsistency makes it hard to directly search the code for a specific
member function definition.
 2014-03-24 04:03:09 +00:00
Ray Speth
e1a49487b7 [Kinetics] Remove deprecated getActivationEnergies function 
Resolves Issue 147.
 2013-12-16 23:21:52 +00:00
Ray Speth
112d9b5093 Remove unusable KINETICS_WITH_INTERMEDIATE_ZEROED_PHASES macro 2013-06-13 22:50:26 +00:00
Ray Speth
305e4eec54 Deprecate Kinetics::activationEnergies 2013-06-06 15:33:00 +00:00
Ray Speth
d253fc0d63 Eliminate redundant standard library includes 2013-06-05 17:08:13 +00:00
Ray Speth
d103ec8d2f Cleaned up Doxygen documentation for class Kinetics and descendants 2013-04-12 23:05:20 +00:00
Ray Speth
e04e59cdd3 Removed extraneous parentheses around arguments to 'return' 
'return' is a keyword, not a function, so these parens are unnecessary.
 2013-02-14 01:03:48 +00:00
Ray Speth
6d6e237f07 Removed unnecessary checks surrounding delete operations 2013-02-14 01:03:32 +00:00
Ray Speth
a25c1a43b3 [Kinetics] Fixed crashes when reaction mechanism contains no reactions 
Make sure several arrays are never of length zero so that taking &v[0]
is always well-defined.
 2013-02-14 01:02:18 +00:00
Ray Speth
7da738d238 Re-applied consistent formatting to trunk 
Applied using: astyle -n --style=kr --add-brackets --indent=spaces=4
--indent-col1-comments --unpad-paren --pad-header --align-pointer=type
--lineend=linux
 2013-02-07 23:40:59 +00:00
Ray Speth
50327a665f Moved some function implementations out of InterfaceKinetics.h 
This gets rid of some (mostly spurious) warnings generated by MSVC
 2013-01-11 22:56:33 +00:00
Ray Speth
46a8b3052f Use size_t instead of int in InterfaceKinetics 2012-12-26 23:56:07 +00:00
Harry Moffat
ea25de7fe7 Continuing transfering LiquidTransport changes, doing bugfixes, and 
qualifying against our testsuite.
 2012-12-15 00:49:14 +00:00
Harry Moffat
c6f7abbf2f Fixed a serious error in InterfaceKinetics that had crept into this branch. 
Started upgrade/update of equilibrium solver
       - Fixed numerical jacobian calculation of the ln activity coefficients.
 2012-11-29 02:18:05 +00:00
Ray Speth
94d08f1d5e Removed unnecessary casts from object duplication functions 2012-10-24 15:45:33 +00:00
Ray Speth
cde96e5191 Folded InterfaceKineticsData into InterfaceKinetics 2012-08-08 22:17:10 +00:00
Ray Speth
d25cb04713 Removed unnecessary manual memory management from InterfaceKinetics 
Converted m_rxnPhaseIsReactant and m_rxnPhaseIsProduct from
vector<bool*> to vector<vector<bool> >.
 2012-07-20 18:26:57 +00:00
Ray Speth
3ce3da1fa2 Fixed code formatting 2012-07-18 18:32:29 +00:00
Ray Speth
8b6c9a0bf7 Removed some deprecated functions 2012-07-16 22:18:11 +00:00
Ray Speth
d3e98fe5a8 Corrected a bunch of spelling errors 2012-05-29 21:21:47 +00:00
Harry Moffat
9c06d1e07c Fixed an error with the instanteation of electrode reactions using 
the exchange current density formulation.
Electrode object test problems now all work.
 2012-04-05 22:50:51 +00:00
Ray Speth
234439d10f Make use of the ReactionData struct when installing reactions 2012-03-30 23:47:38 +00:00
Ray Speth
1e8870191d Moved m_kk up to the base Kinetics class 2012-03-15 19:51:16 +00:00
Ray Speth
b955395ed1 Skip cast from size_t to int when calling int2str 2012-02-27 18:14:17 +00:00
Ray Speth
437294ae00 Removed previously-deprecated array_fp typedef 2012-02-22 00:16:22 +00:00
Ray Speth
18bce3bc62 Fixed lines ending with doubled semicolon. 2012-02-22 00:16:10 +00:00
Ray Speth
35429de71c Fixed a bunch of spelling errors in the documentation and comments 2012-02-21 16:04:09 +00:00
Ray Speth
e8b04fb2b4 Fixed numerous compiler warnings from MSVC 2012-02-17 20:29:10 +00:00
Ray Speth
a310345b9e Updated #includes to reflect new header file locations 2012-02-12 02:44:14 +00:00
Ray Speth
2528df0f75 Reorganized source tree structure 
These changes make it unnecessary to copy header files around during
the build process, which tends to confuse IDEs and debuggers. The
headers which comprise Cantera's external C++ interface are now in
the 'include' directory.

All of the samples and demos are now in the 'samples' subdirectory.
 2012-02-12 02:27:14 +00:00
Renamed from Cantera/src/kinetics/InterfaceKinetics.cpp (Browse further)