Commit graph

50 commits

Author SHA1 Message Date
Ray Speth
7a24dc3817 Replace lowercase with boost string algorithms 2016-10-28 18:20:11 -04:00
Ray Speth
3f3b96587b [Thermo] Fix finite-difference properties in two-phase region
These properties are actually infinite in the two-phase region, but attempting
to compute them by finite difference would incorrectly give a finite result, so
they need to be treated as a special case.
2016-10-21 13:28:51 -04:00
Ray Speth
a92245f683 [Thermo] Fix calculation of derivative properties of pure fluids
Calculating specific heat capacities (cp or cv) for states near the saturation
curve would give incorrect results if the finite difference method used points
within the saturation region. To avoid this, we now check the points used for
computing the properties and use values outside the saturation region to compute
the derivatives.

Fixes #273
2016-10-21 13:28:51 -04:00
Ray Speth
b1a1ce6e23 [Thermo] Fix pure fluid thermal expansion coefficient calculation 2016-10-19 19:51:31 -04:00
Ray Speth
f6df8f31b3 [TPX] Move function implementations out of Sub.h 2016-10-19 17:40:50 -04:00
Ray Speth
ae6e7fdff7 Add license/copyright info to files that were missing it 2016-10-10 22:48:23 -04:00
Ray Speth
668634c969 [Thermo] Deprecate classes tpx::leekesler and tpx::RedlichKwong
These are implementations of tpx::Substance which cannot actually be
instantiated from within the PureFluidPhase wrapper class.

The broken implementation of a CTML class for redlich_kwong is removed here.

A functional implementation of the Redlich-Kwong equation of state remains in
class RedlichKwongMFTP.

Resolves #263
2016-06-26 20:31:48 -04:00
Ray Speth
fc33778451 Use correct value for gas constant
Even if it's just for part of an initial guess
2016-05-10 22:16:46 -04:00
Ray Speth
b55c8fe813 Replace overly-specific exception types with CanteraError
Deprecate exception types which are now unused.
2016-02-04 19:34:26 -05:00
Ray Speth
f44b5fed57 Replace usage of int2str with cppformat and deprecate int2str 2016-02-04 19:11:49 -05:00
Ray Speth
f91afda8cb Replace usage of fp2str with cppformat and deprecate fp2str 2016-02-04 19:11:45 -05:00
Bryan W. Weber
50a97063b7 Reduce relative tolerance of state setter in Substance
Reduce the relative tolerance from 3.e-8 to 1.e-8.
2016-01-25 13:07:34 -05:00
Ray Speth
66a3b5b48a Remove unnecessary and bogus 'inline' declarations 2015-11-12 12:22:09 -05:00
Ray Speth
acdf9cf0ed Clean up interstitial whitespace
Remove extra space around operators, between words, etc.
2015-08-02 23:06:16 -04:00
Ray Speth
f90bf978df Use += and -= where appropriate 2015-08-02 23:06:15 -04:00
Ray Speth
e4c45b6429 General whitespace cleanup
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
2015-08-02 23:06:15 -04:00
Ray Speth
d086be8d3d Eliminate do-while loops in favor of regular while loops 2015-08-02 23:06:15 -04:00
Ray Speth
6cc5652de6 Remove commented-out code 2015-07-20 17:20:46 -04:00
Ray Speth
78f60e2d5f [Thermo] Improve error message generated by Substance::set_xy 2015-05-29 12:45:17 -04:00
Ray Speth
b8a99b4b83 Remove unnecessary explicit calls to default constructors 2015-01-22 00:04:12 +00:00
Ray Speth
a22a767be1 Fix some compiler warnings 2014-07-30 16:59:45 +00:00
Ray Speth
789574ac80 Remove commented-out code 2014-05-27 02:52:21 +00:00
Ray Speth
fcf7edf694 Implement Sub::name and Sub::formula in the base class
Eliminates the need for redundant implementations in all the derived
classes. Also, make the return value a "const char*" to eliminate the dangerous
cast.
2014-04-14 18:36:32 +00:00
Ray Speth
c7ba8bfb84 Remove abandoned autotools build system 2014-03-04 17:38:53 +00:00
Ray Speth
681a08fc8d Fix issues with pure fluids near temperature limits
Fixes Issue 186.
2013-11-12 23:44:51 +00:00
Ray Speth
a6614b87bb [Doxygen] Fix some incorrect/missing "@file" commands 2013-06-06 15:32:30 +00:00
Ray Speth
d253fc0d63 Eliminate redundant standard library includes 2013-06-05 17:08:13 +00:00
Ray Speth
0a059d406a Eliminated unnecessary empty destructors from derived classes
See http://www.parashift.com/c++-faq-lite/virtual-dtors.html
2013-04-29 18:04:23 +00:00
Ray Speth
fde4a33908 Removed duplicate 'lowercase' function from tpx/utils.cpp 2013-04-18 22:07:32 +00:00
Ray Speth
e261fd8ef1 Removed the unnecessary tpx/subs.h file 2013-04-18 22:07:27 +00:00
Ray Speth
5be3edbd5f Cleaned up Doxygen documentation for pure fluid classes 2013-04-18 22:07:17 +00:00
Ray Speth
934010136d Removed unnecessary temporaries used for storing return values 2013-02-14 01:04:07 +00:00
Ray Speth
3f17786c01 Removed some commented-out includes 2012-10-12 20:34:48 +00:00
Ray Speth
3e71897a9c Use actual enums for the pure fluid constants 2012-08-08 22:17:57 +00:00
Ray Speth
b7ee30aa04 Simplified error handling in pure fluid (tpx) calculations
TPX_Error is now derived from CanteraError, and errors in the tpx calculations
propagate automatically without requiring explicit checks for an error
condition.
2012-08-08 22:17:48 +00:00
Nicholas Malaya
77bb5e15ce removing several deprecated header files from the makefile.ams. In addition, headers should now be properly installed by the make install step 2012-07-18 22:54:54 +00:00
Ray Speth
3ce3da1fa2 Fixed code formatting 2012-07-18 18:32:29 +00:00
Ray Speth
c7af9ddf81 Improved convergence when solving for pure fluid saturated states 2012-05-11 15:27:33 +00:00
Ray Speth
3af22be158 Modified hydrogen equation of state to fix reference state
This makes the reference state for enthalpy and entropy agree with the
book from which the equation of state is taken (Reynolds, Thermodynamic
Properties in SI).
2012-05-07 18:20:23 +00:00
Ray Speth
eb12c611db Fixed errors in implementation of carbon dioxide equation of state
The sign error in computing the entroy term proportional to G[0]
introduced errors in the entropy of about 3 percent.
2012-05-07 18:20:20 +00:00
Ray Speth
a4520bfe85 Added reference for the HFC-134a equation of state 2012-05-07 18:20:18 +00:00
Ray Speth
4ab7da72f7 Corrected entropy calculations for HFC-134a 2012-05-07 18:20:15 +00:00
Nicholas Malaya
79b29300a6 [cantera]: updating autotools build system. Library building, need to fix another test. Additionally, adding hypersonic flow transport model-- need to add hypersonic thermodynamics as well. 2012-04-25 13:18:25 +00:00
Ray Speth
b4d0f37fc4 Removed unused file: mix.h 2012-03-30 23:48:50 +00:00
Ray Speth
3bff32dd55 Fixed problems that generated warnings with the Intel compiler 2012-03-07 00:51:13 +00:00
Ray Speth
1e5d4d50e1 Fixed an array indexing error in tpx::Water::ldens 2012-02-27 18:15:27 +00:00
Ray Speth
236756fbf0 Removed rogue tabs in the C++ source code 2012-02-27 18:15:02 +00:00
Ray Speth
f1e807d314 Moved global variables from tpx namespace into class Substance
This fixes failures in the pureFluid test on OSX with certain
compilier optimizations enabled.
2012-02-27 18:11:28 +00:00
Ray Speth
a310345b9e Updated #includes to reflect new header file locations 2012-02-12 02:44:14 +00:00
Ray Speth
2528df0f75 Reorganized source tree structure
These changes make it unnecessary to copy header files around during
the build process, which tends to confuse IDEs and debuggers. The
headers which comprise Cantera's external C++ interface are now in
the 'include' directory.

All of the samples and demos are now in the 'samples' subdirectory.
2012-02-12 02:27:14 +00:00