research/cantera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3155 commits 2 branches 16 tags 37 MiB
Commit graph

3155 commits

This branch
This branch
All branches
Author SHA1 Message Date
Harry Moffat
d96464f0c2 Fixed an error in the assignment and copy constructor. 
The VPSSMgr object needed to be resynced at the end of the
assignment. This wasn't being done.
 2009-12-22 22:27:01 +00:00
Harry Moffat
a7a59b84b8 Fixed an error in the assignment operator. 
The internal state of the VPSSMgr object must be resynced
by calling stateState_TP() after the new VMSSMgr object is set up.
 2009-12-22 22:23:53 +00:00
Harry Moffat
acf0c3f7c3 Fixed a typo that was causing sundials version 2.3 builds to fail. 
The define variable was spelled incorrectly.
 2009-12-21 21:02:28 +00:00
Harry Moffat
b8ee78fc24 Modified the example installs 
The minor version number is now included in the install directory.
 2009-12-21 20:53:24 +00:00
Harry Moffat
4420038d29 Fixed an error that caused sundials version 2.3 not to work as intended. 
There was an error in the ifdef variable's spelling.
 2009-12-21 20:27:18 +00:00
Harry Moffat
ec3c7e37c7 Fixed an error that caused sundials version 2.3 not to work as intended. 2009-12-21 20:21:40 +00:00
Harry Moffat
c865e0e4d7 Changes to allow the program to compile! 
visc_Eij and visc_Sij seem to have been taken out. And, the code no longer needs to resize them.
    Also took out some warning messages
 2009-12-21 18:15:15 +00:00
Harry Moffat
ee68428951 Added parenthesis to avoid warning messages. 2009-12-21 17:56:40 +00:00
Harry Moffat
44dc8c9084 Added parentheses to avind warning messages. 2009-12-21 17:53:44 +00:00
Harry Moffat
5c644ca58f Adding parenthesis to reduce warnings 2009-12-21 17:45:29 +00:00
Harry Moffat
a7fd7aa131 Added parenthesis to reduce warning levels. 2009-12-21 17:41:37 +00:00
Harry Moffat
24f94885c4 Added parenthesis to reduce warning messages 2009-12-21 17:34:13 +00:00
Harry Moffat
0708f2b942 Added parenthesis to reduce warning messages. || logical element always takes the least precedence. 2009-12-21 17:31:52 +00:00
Harry Moffat
7bf73c7db2 Reduced warning messages by adding operator precedence parenthesis. 2009-12-21 17:29:11 +00:00
John Hewson
cb5e85ed5c Removed parsing for old Liquid Transport Interaction models 2009-12-18 21:30:24 +00:00
John Hewson
b4032c9d9a Updating Doxygen comments 2009-12-18 21:28:25 +00:00
Harry Moffat
39ea7fdeab Doxygen update. 
Worked on general information for the Transport classes.
 2009-12-18 16:43:20 +00:00
Harry Moffat
1ab5f6725a Utility commit 
- doxygen updates
   - started filling in copy constructors, assignment operator, and dupl function.
 2009-12-17 22:13:14 +00:00
John Hewson
d38eea717a Updating Doxygen comments 2009-12-17 19:07:53 +00:00
John Hewson
9782ac76e8 Minor edits 2009-12-16 00:29:32 +00:00
John Hewson
8e8c7ec38f Added methods to compute current and conductivity. 
Fixed bug in Stefan_Maxwell_Solve

Adding lots of comments to LiquidTransport
 2009-12-16 00:27:39 +00:00
John Hewson
debcff82d9 Added a pointer to a Transport object to the 
Phase class.  This allows a ThermoPhase object
to know what Transport object it is associated with.
 2009-12-15 21:43:34 +00:00
Harry Moffat
0d6e6bd10b Doxygen update 
- No code changes were made.
 2009-12-13 18:03:53 +00:00
Harry Moffat
ccd01f5125 Doxygen update 
-> no source code changed.
 2009-12-13 17:30:36 +00:00
Harry Moffat
d99352f3d1 Doxygen Updates - no changes to the code 2009-12-12 00:15:00 +00:00
Harry Moffat
6b1a1ac27f Merged changes from the trunk. 2009-12-11 15:27:02 +00:00
Harry Moffat
321d387930 MetalSHEelectrons 
Added a built-in type to handle electrons in metals that
    follow the SHE convention.

    Took out electrodeElectron, since it was hidden and not used.

    MetalSHEelectrons have a standard concentration of 1, instead
    of the previous treatment where SHE electrons had a standard
    concentration equal to the concentration of an ideal gas.
 2009-12-11 01:32:26 +00:00
Harry Moffat
204f6bff33 Made the destructor virtual 2009-12-11 01:19:09 +00:00
Harry Moffat
9b90beb0e0 Merged changes from LiquidTransportDevelopment 
There were two changes:

Additions to support some reversible reactions which have fractional
stoichiometries. These were not allowed previously. However, if
the species with fractional stoichiometries are in single-species
phases, this is ok, and actually necessary for some solid-phase
reactions.

Removed comments from DEBUG_MODE about about too high or low an activation
for electrode reactions.
 2009-12-10 23:20:44 +00:00
Harry Moffat
9c6080e3c9 Turned on keyword substitution in the cpp files. 2009-12-09 17:50:27 +00:00
Harry Moffat
6d02467b7e Added the change for the bugfix to HMWSoln to the static branch 
The function getActivityConcentration in the HMWSoln object had
a bug in it that caused it to be incompatible with standardConcentration()
and getActivities(). This meant that the ROP in kinetics managers
for this object was being calculated incorrectly.

This is now fixed.
 2009-12-09 17:34:13 +00:00
Harry Moffat
20c74f21af Added the change for the bugfix to HMWSoln to the main branch. 
The function getActivityConcentration in the HMWSoln object had
a bug in it that caused it to be incompatible with standardConcentration
and getActivities(). This meant that the ROP in kinetics managers
for this object was being calculated incorrectly.
 2009-12-09 17:29:23 +00:00
Harry Moffat
1687ecaf1b Bug fix involving kinetics operators that use HMWSoln. 
The member function getActivityConcentration() calculated the
   standard concentrations for solute species incorrectly. This
   caused the reaction rates of progress for kinetics operations 
   involving HMWSoln to be calculated incorrectly. In particular,
   equilibrium constants (which were and are correct) 
   were not compatible with forward vs.
   reverse ROP's.

   I fixed this error, and worked on more documentation of 
   generalized activity concentrations.
 2009-12-09 16:52:16 +00:00
Harry Moffat
392683283a An initial implemention of a string representation of the 
phase eos type.  We've not had this until now. 

The idea here is to have a 1 to 1 mapping between an
eosType int and a string, which can be used for writing output.
 2009-12-08 17:36:40 +00:00
Harry Moffat
0e85b295cc An initial implementation of a string function that returns 
the eosType(). This is something that we've been lacking.
 2009-12-08 17:33:06 +00:00
Harry Moffat
47aba7b3fd Took out the FtnTransport.h file. It's no longer used 2009-12-07 17:36:29 +00:00
Harry Moffat
2c712b8c56 Merges from the Trunk. 2009-12-06 19:25:59 +00:00
Harry Moffat
da0cb495c2 Merging trunk changes into the branch 2009-12-06 19:04:54 +00:00
Harry Moffat
443ccf0af5 Added ignore files. 2009-12-06 18:14:40 +00:00
Harry Moffat
6842b761db Added more ignore files. 2009-12-06 18:13:11 +00:00
Harry Moffat
380a10a863 Added another function 
initAllPts() 
to handle shallow pointer concerns.
 2009-12-06 18:03:35 +00:00
Harry Moffat
a6a6761eae added another function 2009-12-06 18:02:24 +00:00
Harry Moffat
1756f4a65e changes in comments. 2009-12-06 18:01:43 +00:00
Harry Moffat
fe6f8a29d0 Fixed error in the assignment operator. 2009-12-06 18:00:18 +00:00
Harry Moffat
646d31f8be Fixed an error in the assignment operator. 2009-12-06 17:59:27 +00:00
Harry Moffat
05753b6ef1 Fixed an Error in the assignment operator. 2009-12-06 17:58:08 +00:00
Harry Moffat
4f66d852b5 Added more expressive comments. 2009-12-06 17:56:45 +00:00
Harry Moffat
1a3af47eb9 took out checkMFSum() which is inappropriate in that context. 2009-12-06 17:55:43 +00:00
Harry Moffat
ae22fd8aca Added more initializations 2009-12-06 17:54:24 +00:00
Harry Moffat
55a743c2c0 Added more initializations 2009-12-06 17:53:44 +00:00