Ray Speth
e58bd09859
Eliminate debug_verbose option and DEBUG_MODE macro
...
Vebose printing can always be enabled at runtime by setting flags on various
classes.
2015-11-18 11:02:30 -05:00
Ray Speth
ee95c60813
Simplify error handling to eliminate need for global error stack
...
All of the functions for manipulating the global error stack
(CanteraError::save, setError, showErrors, etc.) are deprecated. The ability to
store an error is retained only for use in the C and Fortran interfaces so that
the last error message can be retrieved after a function returns an error code.
2015-11-16 19:50:55 -05:00
Ray Speth
eb8695dffa
Remove unnecessary overrides of cv_mole
2015-11-15 17:00:46 -05:00
Ray Speth
8a5bad1e70
Eliminate lowercase 'l' as a variable name
2015-11-13 21:38:43 -05:00
Ray Speth
f5ff849b47
Replace std::copy with simpler direct assignment where possible
2015-11-12 17:35:30 -05:00
Ray Speth
69eeb20283
Remove duplicate check for thermo node
2015-11-12 15:50:31 -05:00
Ray Speth
5e69a9949a
Use ThermoPhase::RT() where convenient
2015-11-12 15:36:17 -05:00
Ray Speth
0d0c96257b
[Thermo] Remove unnecessary override of getChemPotentials_RT
2015-11-12 15:15:48 -05:00
Ray Speth
f6d19ccd59
[Thermo] Remove unnecessary overrides of VPStandardStateTP methods
...
setPressure, setTemperature, and setState_TP are all implemented generally in
VPStandardStateTP. The specialization in child classes is always handled in
calcDensity().
2015-11-12 15:04:45 -05:00
Ray Speth
a9379e6f71
[Thermo] Remove unimplemented versions of setToEquilState
2015-11-12 12:42:46 -05:00
Ray Speth
66a3b5b48a
Remove unnecessary and bogus 'inline' declarations
2015-11-12 12:22:09 -05:00
Ray Speth
fe4035647f
Clean up remaining Thermo comments
2015-11-12 11:41:34 -05:00
Ray Speth
cd1f1fd5ac
[Doc] Clean up Doxygen documentation for ThermoPhase classes
...
Remove redundant documentation from overloaded methods which does not add any
additional information.
Reformat to to make indentation and line lengths more consistent.
2015-11-09 17:59:22 -05:00
Ray Speth
4382ae6c85
Clean up comments in Thermo class source files
2015-11-09 17:34:46 -05:00
Ray Speth
0542e694a9
[Thermo] Merge classes StoichSubstance and StoichSubstanceSSTP
...
Use the implementation of StoichSubstanceSSTP (descended from
SingleSpeciesTP) but change the name to StoichSubstance.
2015-10-19 00:17:40 -04:00
Ray Speth
0647823ada
Replace DATA_PTR macro with calls to data()
2015-10-17 18:58:50 -04:00
Ray Speth
8b16eb489f
Eliminate unnecessary aliases for member variables in HMWSoln
2015-10-17 18:58:50 -04:00
Ray Speth
91d3002df1
Make use of "make_shared" where possible
2015-10-17 18:58:50 -04:00
Ray Speth
a945ef2c23
Make use of initializer lists where appropriate
2015-10-17 18:58:50 -04:00
Ray Speth
f9375e1a09
Use locks/mutexes from the standard library instead of Boost.Thread
...
This eliminates the need to link against any of the compiled Boost libraries,
and means that we can always build in thread-safe mode
2015-10-17 18:58:50 -04:00
Ray Speth
a03f370cfd
Make use of emplace and emplace_back methods
2015-10-14 18:45:23 -04:00
Ray Speth
c3a16ec1fb
Update AssertThrowMsg and AssertFinite to use cppformat
2015-10-14 18:45:23 -04:00
Ray Speth
fb4eece9f8
Use std::unique_ptr instead of raw pointers where appropriate
2015-10-14 18:45:23 -04:00
Ray Speth
0690626ab8
Make m_sub a regular member of WaterSSTP instead of a pointer
2015-10-14 18:45:23 -04:00
Ray Speth
ffc4ba07da
Make m_phi a regular member of WaterPropsIAPWS instead of a pointer
2015-10-14 18:45:23 -04:00
Ray Speth
3c05e801a4
Remove unused variable MetalSHEelectrons::xdef_
2015-10-14 18:45:23 -04:00
Ray Speth
3f6d8b0aca
Use cppformat instead of int2str and fp2str
2015-10-14 18:45:23 -04:00
Ray Speth
2589a27b6c
Use range-based for and auto to simplify some loops
2015-10-14 18:45:23 -04:00
Ray Speth
c2ba24c0c2
Fix possible memory leak in newPhase
...
If importPhase threw an exception, then the ThermoPhase object allocated here
would not be deleted. Switching to a smart pointer fixes this problem.
2015-10-14 18:45:23 -04:00
Ray Speth
0b2c7b59b8
Replace printf with writelogf in all library code
2015-10-14 18:45:23 -04:00
Ray Speth
71bb73b728
Eliminate unnecessary calles to std::string.c_str()
2015-10-14 18:45:22 -04:00
Ray Speth
e669f912a5
Use cppformat in Phase and ThermoPhase
2015-10-14 18:45:22 -04:00
Ray Speth
41527b1ea7
Rename two-argument version of writelog 'debuglog'
...
This is a prerequisite to allowing writelog to take an arbitrary number
of arguments.
2015-10-14 18:45:22 -04:00
Ray Speth
caf9c6f062
Use cppformat in ThermoPhase::report and overrides
2015-10-14 18:45:22 -04:00
Ray Speth
a956f3904a
[Thermo] Deprecate get/setReferenceComposition and xMol_Ref
2015-10-05 15:25:05 -04:00
Ray Speth
86835a5eeb
[Thermo] Show large negative species concentrations in phase report
...
Non-trivial negative concentrations generally indicate a problem, and shouldn't
be hidden.
2015-08-23 19:35:23 -04:00
Ray Speth
7bcbbaafd9
[Thermo] Use consistent implementation for convenience constructors
...
The constructor with the signature (inputFile, [id]) just calls initThermoFile.
The constructor with the signature (phase XML node, [id]) just calls importPhase
(note that the id argument is unused, since the correct XML node must already be
given).
2015-08-05 12:34:22 -04:00
Ray Speth
7fe8f0f3b7
[Thermo] Refactor common initialization out of constructors
2015-08-05 12:09:02 -04:00
Ray Speth
ff60328ecd
[Thermo] Fix IdealGasPhase constructor from XML_Node
2015-08-04 12:01:45 -04:00
Ray Speth
ea1f7c015b
Deprecate PDSS construction directly from XML files
...
The constructors from existing XML_Nodes are the ones that are actually used.
2015-08-03 17:16:38 -04:00
Ray Speth
bfb20e1f50
Consistently use vector_fp and vector_int typedefs
2015-08-02 23:06:16 -04:00
Ray Speth
ceefc5ecb0
Consistently use ThermoPhase::RT()
2015-08-02 23:06:16 -04:00
Ray Speth
acdf9cf0ed
Clean up interstitial whitespace
...
Remove extra space around operators, between words, etc.
2015-08-02 23:06:16 -04:00
Ray Speth
6a04193646
Fix un-bracketed if, for, and else statements
2015-08-02 23:06:15 -04:00
Ray Speth
02f9497b20
Remove functions which just explicitly call base class functions
2015-08-02 23:06:15 -04:00
Ray Speth
801334c84e
Merge nested if statements
2015-08-02 23:06:15 -04:00
Ray Speth
546eede80c
Fix pointer logic errors in initThermoXML
...
Affects DebyeHuckel and HMWSoln
2015-08-02 23:06:15 -04:00
Ray Speth
f90bf978df
Use += and -= where appropriate
2015-08-02 23:06:15 -04:00
Ray Speth
e4c45b6429
General whitespace cleanup
...
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
2015-08-02 23:06:15 -04:00
Ray Speth
619cd20f14
Fix badly-formatted else/else if/catch clauses
2015-08-02 23:06:15 -04:00