research/cantera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
5775 commits 2 branches 16 tags 37 MiB
Commit graph

803 commits

Author SHA1 Message Date
Ray Speth
59b14724ed Allow writelog to do string formatting 
If multiple arguments are supplied, the string is treated as a Python-style
format string and the extra arguments are used to populate the format string.
 2015-10-14 18:45:22 -04:00
Ray Speth
41527b1ea7 Rename two-argument version of writelog 'debuglog' 
This is a prerequisite to allowing writelog to take an arbitrary number
of arguments.
 2015-10-14 18:45:22 -04:00
Ray Speth
61a755ff51 Use cppformat to implement writelogf 
This represents the first use of variadic templates in Cantera.
 2015-10-14 18:45:22 -04:00
Ray Speth
caf9c6f062 Use cppformat in ThermoPhase::report and overrides 2015-10-14 18:45:22 -04:00
Ray Speth
fbf93bf270 [Doc] Add Doxygen docstrings for wrapper classes 
Without at least a basic docstring, these classes are excluded from the Doxygen
documentation.
 2015-10-07 13:54:47 -04:00
Ray Speth
3d27dfa1a1 [Reactor] Eliminate unused variable ReactorNet::m_iown 2015-10-05 18:48:14 -04:00
Ray Speth
a956f3904a [Thermo] Deprecate get/setReferenceComposition and xMol_Ref 2015-10-05 15:25:05 -04:00
Ray Speth
62730b1ff7 Remove unimplemented derivative calculation functions 2015-08-28 15:51:13 -04:00
Ray Speth
6e138d0ae4 [Reactor] Always check that input/output are finite 
This causes problems to be caught early, where they can at least sometimes be
handled as recoverable intergrator errors, rather than letting NaN values
propagate through the solution.
 2015-08-24 12:27:07 -04:00
Ray Speth
60b98b362c [Kinetics] Prevent positive feedback in negative species concentrations 
For binary (or higher order) reactions, multiple negative (but small, i.e. with
respect to integration tolerances) species concentrations should not produce
positive reaction rates that would drive those concentrations to even more
negative values.
 2015-08-23 19:29:49 -04:00
Ray Speth
bb2d1c0993 [Thermo] Prevent setting thermodynamic state variables to NaN 
Throwing an exception when a state variable is being set to NaN transforms some
reactor network integration errors from unrecoverable errors into recoverable
errors.
 2015-08-23 17:09:17 -04:00
Ray Speth
7bcbbaafd9 [Thermo] Use consistent implementation for convenience constructors 
The constructor with the signature (inputFile, [id]) just calls initThermoFile.
The constructor with the signature (phase XML node, [id]) just calls importPhase
(note that the id argument is unused, since the correct XML node must already be
given).
 2015-08-05 12:34:22 -04:00
Ray Speth
ea1f7c015b Deprecate PDSS construction directly from XML files 
The constructors from existing XML_Nodes are the ones that are actually used.
 2015-08-03 17:16:38 -04:00
Bryan W. Weber
0b5a46fe03 Remove execute bit from files that don't need it 2015-08-02 23:06:16 -04:00
Ray Speth
bfb20e1f50 Consistently use vector_fp and vector_int typedefs 2015-08-02 23:06:16 -04:00
Ray Speth
ceefc5ecb0 Consistently use ThermoPhase::RT() 2015-08-02 23:06:16 -04:00
Ray Speth
acdf9cf0ed Clean up interstitial whitespace 
Remove extra space around operators, between words, etc.
 2015-08-02 23:06:16 -04:00
Ray Speth
6a04193646 Fix un-bracketed if, for, and else statements 2015-08-02 23:06:15 -04:00
Ray Speth
02f9497b20 Remove functions which just explicitly call base class functions 2015-08-02 23:06:15 -04:00
Ray Speth
e4c45b6429 General whitespace cleanup 
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
 2015-08-02 23:06:15 -04:00
Ray Speth
d24dfea036 Remove unnecessary public/private/protected labels 2015-08-02 23:06:15 -04:00
Ray Speth
187fd27cef Remove unnecessary use of (void) 2015-08-02 23:06:14 -04:00
Ray Speth
09207eacfb Eliminate use of 'memset' 2015-08-02 23:06:14 -04:00
Ray Speth
c3c80f79fb Remove extraneous parentheses 2015-08-02 23:06:14 -04:00
Ray Speth
6cc5652de6 Remove commented-out code 2015-07-20 17:20:46 -04:00
Ray Speth
de005c083e Eliminate VCS_DATA_PTR macro 2015-07-20 16:17:31 -04:00
Ray Speth
bf2ceed60e Remove some leftover debugging ifdefs 2015-07-20 15:47:17 -04:00
Ray Speth
c49c969184 [Kinetics] Remove unused code for reactant and product "groups" 2015-07-20 14:04:53 -04:00
Ray Speth
4f1250ef53 [Kinetics] Remove unneeded variables for reaction equation 
Extract this data from the reaction objects directly as needed.
 2015-07-20 13:53:47 -04:00
Ray Speth
62f2af5534 [Kinetics] Eliminate unnecessary variable m_rxntype 2015-07-20 13:01:05 -04:00
Ray Speth
f623e44d32 [Kinetics] Eliminate unnecessary m_rrxn and m_prxn variables 
This information can be extracted from the Reaction objects as-needed.
 2015-07-20 12:56:56 -04:00
Ray Speth
ca90c671ac [Thermo/Doc] Fix description of Shomate temperature polynomial 
The docstring for this function was incorrectly copied from NasaPoly1.
 2015-07-17 18:21:25 -04:00
Ray Speth
b7a5aff900 [Thermo] Convert Shomate coefficients when creating objects 
Do conversion to nondimensional units once when creating the ShomatePoly object,
instead of every time that properties are calculated.
 2015-07-17 18:18:03 -04:00
Ray Speth
761f54f241 Eliminate unnecessary counter variable Kinetics::m_ii 2015-07-16 15:37:41 -04:00
Ray Speth
c08c365ebb Remove unimplemented option to use QR factorization in BandMatrix 2015-07-16 10:52:42 -04:00
Ray Speth
e8292d387e Fix definition of elemental mole fraction 
The elemental mole fractions should be invariant under composition changes which
conserve atoms.
 2015-07-16 10:41:39 -04:00
Ray Speth
97b32069cf Remove leftover "fenv" cruft 2015-07-15 12:46:48 -04:00
Ray Speth
f1f10b6526 Remove unused, deprecated code marked for removal after Cantera 2.2 2015-07-15 12:08:50 -04:00
Ray Speth
d4299fc6da [Test] Fix VCS-LiSi test to not use deprecated "testProb" constructor 2015-07-15 11:35:22 -04:00
Ray Speth
546289f737 Remove deprecated code with functional alternatives 2015-07-13 18:59:09 -04:00
Ray Speth
d44f46aab8 [Reactor] Add bounds check on sensitivity parameter index 2015-07-07 21:00:16 -04:00
Ray Speth
d373e0751e Remove unnecessary explicit specification of namespace Cantera 2015-06-24 14:45:55 -04:00
Ray Speth
079ef0caf9 Update comments regarding critical / saturation properties 2015-06-24 13:26:47 -04:00
Ray Speth
0590b2cda8 [Reactor] Deprecate possibly-ambiguous names in componentIndex 
Resolves #274.
 2015-06-22 18:12:05 -04:00
Ray Speth
4efad93a6d [Kinetics] Fix handling of integral, explicit reaction orders 
If any of the reaction orders differ from the corresponding stoichiometric
coefficients, the reaction needs to be handled as the general case, instead of
just when the orders are non-integral.
 2015-06-22 11:56:56 -04:00
Ray Speth
be24e9daf1 [Reactor] Move reactor contents check into ReactorBase::contents 
The check introduced in f6f868fe28 takes place too late, as the pointer to
ReactorBase.m_thermo has already been dereferenced at this point. Most compilers
let this pass, but it is techincally incorrect.
 2015-06-18 17:51:46 -04:00
Ray Speth
c0fa589b8c [Reactor] Fix segfaults in updateMassFlowRate due to unset parameters 
The downstream and upstream Reactors, the "master" flow controller, and the
coefficient arrays were being read without checking that they had been
initialized.

Fixes #278.
 2015-06-18 12:18:59 -04:00
Bryan W. Weber
ca6e228e22 Move setPressure to a more logical location 2015-06-15 17:47:37 -04:00
Bryan W. Weber
8e58a45edb Overload setState_RP for IdealGasPhase 
Use the ideal gas law to compute the temperature corresponding to the
given density and pressure.
 2015-06-15 17:47:37 -04:00
Bryan W. Weber
5d215b7e86 Add base class functions to set density and pressure simultaneously 
They have the names setState_RP, setState_RPX, and setState_RPY. These
base class functions mirror the TP, TPX, TPY set, except that RP is not
implemented, because it depends on the EOS of the system. We cannot use
the normal setPressure because it sets the state by calculating the
density, but RP will specify the density.
 2015-06-15 17:46:51 -04:00