Commit graph

223 commits

Author SHA1 Message Date
Ray Speth
4c58f11dd8 Improve use of local variables in src/base 2016-02-04 14:45:36 -05:00
Ray Speth
484da253da Use cppformat instead of stringstream in some places 2016-02-04 14:45:21 -05:00
Ray Speth
8b64b6f4f7 [Matlab] Fix printing of error messages 2016-01-29 15:38:13 -05:00
Ray Speth
7562d79bad Remove unnecessary calls to ostream.close() 2015-11-23 18:06:54 -05:00
Trevor Hickey
b751087859 Removes uneeded .close() calls
These calls are not needed. ofstream's destructor will close the file.

Resolves #298.
2015-11-23 18:03:01 -05:00
Ray Speth
e58bd09859 Eliminate debug_verbose option and DEBUG_MODE macro
Vebose printing can always be enabled at runtime by setting flags on various
classes.
2015-11-18 11:02:30 -05:00
Ray Speth
ee95c60813 Simplify error handling to eliminate need for global error stack
All of the functions for manipulating the global error stack
(CanteraError::save, setError, showErrors, etc.) are deprecated. The ability to
store an error is retained only for use in the C and Fortran interfaces so that
the last error message can be retrieved after a function returns an error code.
2015-11-16 19:50:55 -05:00
Ray Speth
f8b12adef4 Clean up comments in 'base' source and header files 2015-11-09 19:35:52 -05:00
Ray Speth
87aaa6ad1e Use math functions from C++11 standard library 2015-10-19 13:14:40 -04:00
Ray Speth
90b0ee152b Fix compilation with GCC 4.6 and 4.7
The standard libraries for these versions of GCC do not have 'emplace'
methods for associative containers.
2015-10-17 18:58:50 -04:00
Ray Speth
a945ef2c23 Make use of initializer lists where appropriate 2015-10-17 18:58:50 -04:00
Ray Speth
f9375e1a09 Use locks/mutexes from the standard library instead of Boost.Thread
This eliminates the need to link against any of the compiled Boost libraries,
and means that we can always build in thread-safe mode
2015-10-17 18:58:50 -04:00
Ray Speth
a03f370cfd Make use of emplace and emplace_back methods 2015-10-14 18:45:23 -04:00
Ray Speth
fb4eece9f8 Use std::unique_ptr instead of raw pointers where appropriate 2015-10-14 18:45:23 -04:00
Ray Speth
3f6d8b0aca Use cppformat instead of int2str and fp2str 2015-10-14 18:45:23 -04:00
Ray Speth
2589a27b6c Use range-based for and auto to simplify some loops 2015-10-14 18:45:23 -04:00
Ray Speth
f335350c35 Always use std::shared_ptr
Since we compile as c++11, std::shared_ptr is guaranteed to exist.
2015-10-14 18:45:23 -04:00
Ray Speth
e131766b71 Replace auto_ptr with unique_ptr
auto_ptr is deprecated in c++11
2015-10-14 18:45:23 -04:00
Ray Speth
0b2c7b59b8 Replace printf with writelogf in all library code 2015-10-14 18:45:23 -04:00
Ray Speth
71bb73b728 Eliminate unnecessary calles to std::string.c_str() 2015-10-14 18:45:22 -04:00
Ray Speth
745db409a6 Add a constructor for CanteraError that uses format strings 2015-10-14 18:45:22 -04:00
Ray Speth
1411419b0f [1D] Eliminate sprintf-style string formatting 2015-10-14 18:45:22 -04:00
Ray Speth
61a755ff51 Use cppformat to implement writelogf
This represents the first use of variadic templates in Cantera.
2015-10-14 18:45:22 -04:00
Ray Speth
b38a9332e2 Treat duplicate keys in composition strings as errors
For example, 'H2:0.5, O2:0.5, H2:0.1', which would previously have been treated
as equivalent to 'O2:0.5, H2:0.1'.
2015-10-05 13:02:16 -04:00
Ray Speth
567a854377 Fix a compilation error when using '-std=c++11' 2015-09-04 18:37:55 -04:00
Ray Speth
6e138d0ae4 [Reactor] Always check that input/output are finite
This causes problems to be caught early, where they can at least sometimes be
handled as recoverable intergrator errors, rather than letting NaN values
propagate through the solution.
2015-08-24 12:27:07 -04:00
Ray Speth
bfb20e1f50 Consistently use vector_fp and vector_int typedefs 2015-08-02 23:06:16 -04:00
Ray Speth
acdf9cf0ed Clean up interstitial whitespace
Remove extra space around operators, between words, etc.
2015-08-02 23:06:16 -04:00
Ray Speth
6a04193646 Fix un-bracketed if, for, and else statements 2015-08-02 23:06:15 -04:00
Ray Speth
801334c84e Merge nested if statements 2015-08-02 23:06:15 -04:00
Ray Speth
e4c45b6429 General whitespace cleanup
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
2015-08-02 23:06:15 -04:00
Ray Speth
619cd20f14 Fix badly-formatted else/else if/catch clauses 2015-08-02 23:06:15 -04:00
Ray Speth
d24dfea036 Remove unnecessary public/private/protected labels 2015-08-02 23:06:15 -04:00
Ray Speth
a6e390dfc5 Standardize always-true while loop condition to "true" 2015-08-02 23:06:15 -04:00
Ray Speth
187fd27cef Remove unnecessary use of (void) 2015-08-02 23:06:14 -04:00
Ray Speth
c3c80f79fb Remove extraneous parentheses 2015-08-02 23:06:14 -04:00
Ray Speth
97b32069cf Remove leftover "fenv" cruft 2015-07-15 12:46:48 -04:00
Ray Speth
f1f10b6526 Remove unused, deprecated code marked for removal after Cantera 2.2 2015-07-15 12:08:50 -04:00
Ray Speth
546289f737 Remove deprecated code with functional alternatives 2015-07-13 18:59:09 -04:00
Ray Speth
6f7241b08b Remove dead code from class Application 2015-06-21 19:01:15 -04:00
Ray Speth
484eff996b Use short form of cantera_version when looking for data directory 2015-06-14 19:51:00 -04:00
Ray Speth
8dcde36d20 Fix invalid iterator usage in Application::close_XML_File
The iterator 'b' is invalidated by calling erase(b), which means that the
subsequent call to ++b results in undefined behavior. This was identified by
segfaults in the Matlab unit test on OS X.
2015-06-08 17:20:54 -04:00
Ray Speth
911c2f180d Remove unused, redundant 'g_DEBUG_MODE' variable
This is exactly the same as the DEBUG_MODE_ENABLED macro
2015-05-29 16:29:57 -04:00
Ray Speth
5214672ab3 Merge namespace ctml with namespace Cantera 2015-05-27 18:09:07 -04:00
Ray Speth
1c878c16de Fix issues indicated by compiler warnings 2015-05-26 11:42:20 -04:00
Ray Speth
341b137766 [Doc] Capitalize proper nouns and acronyms 2015-05-25 20:58:44 -04:00
Ray Speth
aa2b732954 Fix directories searched for input files on Windows
Update to use the registry key for Cantera 2.2. The 'templates'
subdirectory no longer exists.

Fix documentation to not incorrectly claim that COMMONPROGRAMFILES
will be searched for input files.
2015-05-24 18:23:24 -04:00
Ray Speth
decf251a8b Improve error messages generated by XML_NoChild and XML_TagMismatch 2015-05-02 20:07:46 -04:00
Ray Speth
f3eaef1675 [CTI] Strip leading whitespace when converting CTI strings
Leading whitespace would normally result in a Python IndentationError.
2015-04-20 18:34:39 -04:00
Ray Speth
b0e5b13913 Remove redundant, unnamed root XML node from parsed documents
XML_Node::build will make that node the root node (i.e. the 'ctml' node)
of the tree, instead of giving that node a child node containing the actual
root node.
2015-04-20 18:34:39 -04:00