Ingmar Schoegl
e2bfba328c
[Kinetics] deprecate magic numbers for falloff reactions
2019-11-08 15:18:26 -05:00
Ingmar Schoegl
2a9554c134
[Base] consolidate shared_ptr access in Solution
2019-11-08 15:12:36 -05:00
Ingmar Schoegl
40ae5b5fb5
[Base] implement initialization of C++ Solution from input files
...
- implement constructor that loads ThermoPhase, Kinetics, and Transport
from input files (wrapping factory class methods)
- logic for selection of transport manager follows Python object
- add convenience methods to type-cast frequently used classes
2019-11-08 15:12:36 -05:00
Bryan W. Weber
ded50547f9
Update test results changed by constants and elements
...
Update reference values and blessed files in regression tests.
2019-08-09 15:15:30 -04:00
Ray Speth
44c5094bb2
[Input] Implement 'skip-undeclared-third-bodies' option in YAML format
2019-06-25 22:30:59 -04:00
Ray Speth
8eb52a7afb
[Input] Create ElectrochemicalReaction objects from YAML definitions
2019-06-25 22:30:59 -04:00
Ray Speth
672b55a72f
Add AnyValue::getMapWhere function
2019-06-25 22:30:59 -04:00
Ray Speth
0d1196bd46
[Input] Create InterfaceKinetics and InterfaceReaction objects from YAML
2019-06-25 22:30:59 -04:00
Ray Speth
b0209bdf37
[Input] Store additional reaction data in 'input' map
2019-06-25 22:30:59 -04:00
Ray Speth
6dac1b0409
[Input] Allow mapping for Arrhenius parameters, and use this as the default
...
Pressure-dependent Arrhenius reactions now use a list of mappings instead
of a more complicated nested list structure.
2019-06-25 22:30:59 -04:00
Ray Speth
d7734e3f19
[Input] Allow "=" as a delimiter for reversible reactions in YAML
2019-06-25 22:30:59 -04:00
Ray Speth
f0dc990764
Create a complete Kinetics object from a YAML input file
2019-06-25 22:30:59 -04:00
Ray Speth
84fa231ea2
[Input] Read local 'units' definitions in reaction and thermo entries
...
Move 'convert' functions that work with missing keys to AnyMap class.
2019-06-25 22:30:59 -04:00
Ray Speth
aef101fee7
[Input] Parse YAML entries for Chebyshev reactions
2019-06-25 22:30:59 -04:00
Ray Speth
b54ea8bd82
[Input] Parse YAML entries for Plog reactions
2019-06-25 22:30:59 -04:00
Ray Speth
cb31c297cf
[Input] Parse YAML entries for falloff and chemically activated reactions
2019-06-25 22:30:59 -04:00
Ray Speth
8b502d4065
[Input] Parse YAML entries for three body reactions
2019-06-25 22:30:59 -04:00
Ray Speth
de80f06887
[Input] Parse YAML entries for elementary reactions
2019-06-25 22:30:59 -04:00
Ray Speth
5ad656e342
[ck2cti] Fix Chebyshev rate constant when using local quantity units
...
Since the leading Chebyshev coefficient has effective units like
log(cm^3/kmol), it needs to be converted directly to the default units of
the CTI file.
Analogous to the fix for PLOG reactions in #435 .
2019-02-28 22:37:38 -05:00
Bryan W. Weber
16fd18315c
Remove HAS_NO_PYTHON configuration variable
...
This variable is not needed since in the two places its used we do a
runtime check of the presence of the Python interface anyways
2017-11-26 16:48:40 -05:00
Ray Speth
d035557531
[Thermo] Make adding undefined elements the default behavior
...
(except when importing a phase from a CTI or XML input file)
2017-08-13 23:59:49 -04:00
Ray Speth
a02753ae79
[Test/ck2cti] Test pdep reactions with custom units
2017-02-20 19:14:12 -05:00
Ray Speth
ac5337130a
[Kinetics] Validate balance of surface sites for interface reactions
...
The number of surface sites should be the same for the reactants and products.
Fixes #412
2017-01-20 17:40:34 -05:00
Ray Speth
0d241fd64a
Use toSI instead of explicit constant for unit conversions
2016-11-13 22:58:15 -05:00
Ray Speth
50d0f9913f
[Test] Make reaction rate comparisons more granular
2016-10-15 13:36:38 -04:00
Ray Speth
e90dbcb27e
Remove unnecessary reaction from ptcombust.cti
...
The current methods for handling negative species do not have the problem
described.
2016-07-28 22:38:05 -04:00
Ray Speth
14b9454819
[C++] Clean up of top-level headers
...
These headers should only include general functionality, i.e. base classes and
factory methods. Users working directly with derived types can include the
relevant headers directly.
Deprecate some top-level headers which are not really useful.
2016-05-14 16:10:10 -04:00
Ray Speth
1ba5f6b879
[Kinetics] Allow adding species after reactions for homogeneous kinetics
...
This enables incremental mechanism construction for gas phase kinetics. For
surface kinetics, adding new species changes the kinetics species index of
existing species in other phases, so this feature is disabled.
2016-04-16 11:52:08 -04:00
Ray Speth
7ee47585ae
[Test] Fix compiler warnings in tests
2016-04-15 17:33:11 -04:00
Ray Speth
1f231d1dd0
[Kinetics] Eliminate need for 'finalize' method
...
All reaction-sized arrays are now allocated as reactions are added, which means
that the finalize() method is unnecessary and reactions can be continuously
added, even after the Kinetics object has been used for rate calculations.
2016-04-15 17:05:10 -04:00
Ray Speth
7124385292
[Test] Make deprecation warnings fatal in test suites
...
This ensures that deprecated methods aren't being called anywhere in the test
suite, without having to manually scan the test output for warning messages.
2016-04-15 12:04:08 -04:00
Ray Speth
91d3002df1
Make use of "make_shared" where possible
2015-10-17 18:58:50 -04:00
Ray Speth
a945ef2c23
Make use of initializer lists where appropriate
2015-10-17 18:58:50 -04:00
Ray Speth
ceefc5ecb0
Consistently use ThermoPhase::RT()
2015-08-02 23:06:16 -04:00
Ray Speth
e34b2739b2
[Test] Move "negATest" to GTest suite
2015-06-16 16:16:21 -04:00
Ray Speth
1c878c16de
Fix issues indicated by compiler warnings
2015-05-26 11:42:20 -04:00
Ray Speth
ba9c9c768f
[Kinetics] Use the name 'ThreeBodyReaction' consistently
2015-05-11 16:35:46 -04:00
Ray Speth
7a21855574
[Kinetics] Switch parameter order in ChebyshevRate constructor
...
The usual order of arguments is temperature then pressure.
2015-04-30 22:34:25 -04:00
Ray Speth
27e05d72f7
[Test] Add a test which includes a coverage-dependent rate constant
2015-04-26 11:44:19 -04:00
Ray Speth
9d4a3e0f75
[Kinetics] Reaction objects have Falloff objects
...
This approach actually makes use of the fact that we have a Falloff type.
2015-04-23 18:10:15 -04:00
Ray Speth
5958578c40
[Kinetics] Check for negative and non-reactant reaction orders
...
Allow non-reactant orders for electrochemical reactions
Allow negative orders specifically requested, e.g. by setting the
'negative_orders' option in the CTI definition of the reaction.
2014-11-15 00:47:25 +00:00
Ray Speth
e3022a8057
[Kinetics] Check Reaction objects for orders on reversible reactions
2014-11-15 00:47:13 +00:00
Ray Speth
82fbff7a05
[Kinetics] Validate rate coefficient data for Reaction objects
2014-11-15 00:47:09 +00:00
Ray Speth
6727902c3f
[Kinetics] Allow skipping third-body efficiencies when using Reaction
2014-11-15 00:47:04 +00:00
Ray Speth
ffe3eb5e5a
[Kinetics] Check for undeclared species when using Reaction objects
...
Skip the reaction or raise an exception based on the
'm_skipUndeclaredSpecies' flag
2014-11-15 00:46:59 +00:00
Ray Speth
69650b8ec2
[Kinetics] InterfaceReaction supports sticking coefficients
2014-11-11 00:12:13 +00:00
Ray Speth
c4e6790fda
[Kinetics] Implement addReaction from Reaction for InterfaceKinetics
2014-11-11 00:12:08 +00:00
Ray Speth
be585aab3e
[Kinetics] Implement direct constructor for ChebyshevRate
2014-11-11 00:11:33 +00:00
Ray Speth
191e9bcc42
[Kinetics] Implement direct constructor for P-log reactions
2014-11-11 00:11:31 +00:00
Ray Speth
b4afcd3e8e
[Kinetics] Implement addReaction using Reaction objects for GasKinetics
...
This covers elementary, third-body, and falloff reaction types
2014-11-11 00:11:25 +00:00