Ray Speth
3f6d8b0aca
Use cppformat instead of int2str and fp2str
2015-10-14 18:45:23 -04:00
Ray Speth
0b2c7b59b8
Replace printf with writelogf in all library code
2015-10-14 18:45:23 -04:00
Ray Speth
71bb73b728
Eliminate unnecessary calles to std::string.c_str()
2015-10-14 18:45:22 -04:00
Ray Speth
bfb20e1f50
Consistently use vector_fp and vector_int typedefs
2015-08-02 23:06:16 -04:00
Ray Speth
acdf9cf0ed
Clean up interstitial whitespace
...
Remove extra space around operators, between words, etc.
2015-08-02 23:06:16 -04:00
Ray Speth
801334c84e
Merge nested if statements
2015-08-02 23:06:15 -04:00
Ray Speth
e4c45b6429
General whitespace cleanup
...
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
2015-08-02 23:06:15 -04:00
Ray Speth
619cd20f14
Fix badly-formatted else/else if/catch clauses
2015-08-02 23:06:15 -04:00
Ray Speth
d086be8d3d
Eliminate do-while loops in favor of regular while loops
2015-08-02 23:06:15 -04:00
Ray Speth
c3c80f79fb
Remove extraneous parentheses
2015-08-02 23:06:14 -04:00
Ray Speth
de005c083e
Eliminate VCS_DATA_PTR macro
2015-07-20 16:17:31 -04:00
Ray Speth
bf2ceed60e
Remove some leftover debugging ifdefs
2015-07-20 15:47:17 -04:00
Ray Speth
808f088ffd
Merge namespace VCSnonideal with namespace Cantera
2015-05-27 18:27:25 -04:00
Ray Speth
1c878c16de
Fix issues indicated by compiler warnings
2015-05-26 11:42:20 -04:00
Ray Speth
341b137766
[Doc] Capitalize proper nouns and acronyms
2015-05-25 20:58:44 -04:00
Ray Speth
ecb6242b79
Fix spelling errors
2015-04-08 19:36:55 -04:00
Ray Speth
cc17716182
Cleanup trailing whitespace
2015-02-26 21:52:52 +00:00
Ray Speth
79cf2dcba7
Remove empty comment blocks
2015-02-20 00:11:05 +00:00
Ray Speth
002c158761
Cleanup include statements
...
Move includes from header to implementation files where possible, and remove
unnecessary includes.
2014-08-28 16:54:13 +00:00
Ray Speth
1cd82d40af
Remove 'SQUARE' and 'DSIGN' macros
2014-07-25 18:32:29 +00:00
Ray Speth
83e38480d6
Throw exceptions instead of calling std::exit after an error
...
By throwing an exception, Cantera is better behaved when used within other
applications, e.g. as in the case of the Matlab and Python interfaces.
2014-06-06 00:17:58 +00:00
Ray Speth
dbfe428437
Fix compiler warnings
...
These were mostly related to changes from r2957.
2014-06-03 16:53:40 +00:00
Ray Speth
b5396837b2
Make use of std::min, std::max, and clip
2014-06-03 16:52:43 +00:00
Ray Speth
46a36c11cb
Eliminate redundant VCS vector functions
...
These functions just duplicated features of the standard library.
2014-05-30 19:23:25 +00:00
Ray Speth
c6cefd6df8
Replace IntStarStar with Array2D
2014-05-30 19:23:16 +00:00
Ray Speth
b569b842d0
Replace DoubleStarStar with Array2D
2014-05-30 19:23:03 +00:00
Ray Speth
f80db6c08d
Make function signatures independent of DEBUG_MODE
2014-05-27 02:54:34 +00:00
Ray Speth
ddfc7db080
Make helper functions for pieces of vcs_solve_TP main loop
2014-05-27 02:54:24 +00:00
Ray Speth
ad12f392ce
Some cleanup of vcs_solve_TP
...
Use local variables where possible. Remove unreachable code.
Move repeated code out of if/else blocks. Flatten nested if statements.
2014-05-27 02:54:11 +00:00
Ray Speth
32276b1fda
Refactor vcs_solve_TP to eliminate goto
...
This contains just the changes to the flow control to give the same
behavior as the original implementation. Additional refactoring
still to come.
2014-05-27 02:54:07 +00:00
Ray Speth
4b9e4da822
Fix some compiler warnings
2014-05-27 02:53:35 +00:00
Ray Speth
712293e415
Change debug code to avoid ifdefs where possible
...
Use "if (DEBUG_MODE_ENABLED)" instead of "#ifdef DEBUG_MODE". This makes
it easier to see the flow control logic, and the compiler will optimize
out the always-false conditionals when DEBUG_MODE_ENABLED is 0, so there
isn't any speed penalty.
2014-05-27 02:53:22 +00:00
Ray Speth
6c0cea5ee4
Standardize function used for writing a line of repeated characters
2014-05-27 02:53:06 +00:00
Ray Speth
789574ac80
Remove commented-out code
2014-05-27 02:52:21 +00:00
Ray Speth
4dcdc01fb8
[VCS] Use local variable declarations where possible
2014-05-23 22:47:03 +00:00
Ray Speth
44e7dd91ad
[Equil] Eliminate 'mlequ' and 'gaussj' in favor of using LAPACK
2014-05-21 16:35:02 +00:00
Ray Speth
54ded64e4b
Miscellaneous whitespace cleanup
2014-05-08 23:01:12 +00:00
Ray Speth
6f8da1a27e
Fix 'unused variable' warnings
2014-02-21 19:08:33 +00:00
Ray Speth
f61cbeafcb
[Equil] Fix infinite loop in VCS equilibrium solver
...
The threshold being removed here was introduced in r714, which was merged into
trunk in r1115.
Fixes Issue 113.
2013-08-23 17:43:44 +00:00
Ray Speth
d253fc0d63
Eliminate redundant standard library includes
2013-06-05 17:08:13 +00:00
Ray Speth
7d79b30c27
Removed unnecessary MIN and MAX macros
2013-04-29 18:05:10 +00:00
Ray Speth
30b01ab8fd
Cleaned up Doxygen documentation for class VCS_SOLVE
2013-04-18 22:07:59 +00:00
Harry Moffat
cd387a15d7
Fixed an error due to negative size_t values
2013-04-03 19:26:58 +00:00
Harry Moffat
94cb8cbb65
Fixed printout issues for interfacial voltage variables in equilibrium solver.
...
Added a global variable to indicate debug mode.
2013-03-26 02:26:35 +00:00
Ray Speth
934010136d
Removed unnecessary temporaries used for storing return values
2013-02-14 01:04:07 +00:00
Ray Speth
e04e59cdd3
Removed extraneous parentheses around arguments to 'return'
...
'return' is a keyword, not a function, so these parens are unnecessary.
2013-02-14 01:03:48 +00:00
Ray Speth
7da738d238
Re-applied consistent formatting to trunk
...
Applied using: astyle -n --style=kr --add-brackets --indent=spaces=4
--indent-col1-comments --unpad-paren --pad-header --align-pointer=type
--lineend=linux
2013-02-07 23:40:59 +00:00
Harry Moffat
ea25de7fe7
Continuing transfering LiquidTransport changes, doing bugfixes, and
...
qualifying against our testsuite.
2012-12-15 00:49:14 +00:00
Harry Moffat
c6f7abbf2f
Fixed a serious error in InterfaceKinetics that had crept into this branch.
...
Started upgrade/update of equilibrium solver
- Fixed numerical jacobian calculation of the ln activity coefficients.
2012-11-29 02:18:05 +00:00
Victor Brunini
7c70568bb3
Clean up compiler warnings.
2012-11-07 21:08:56 +00:00