research/cantera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4345 commits 2 branches 16 tags 37 MiB
Commit graph

74 commits

Author SHA1 Message Date
Ray Speth
fae8197bd4 [Transport] Check that mole fractions are different before recalcuating 
This avoids recomputing and factorizing the L matrix under some circumstances,
such as when both thermal conductivity and the Soret coefficients are requested
for the same mixture.
 2013-02-15 17:32:19 +00:00
Ray Speth
529c9b762a [Transport] Fixed update of multicomponent diffusion coefficients 
Certain temperature-dependent quantities used in computing multicomponent
diffusion coefficients were not being reliably updated. This caused convergence
issues for the 1D solver in some cases.
 2013-02-15 17:32:16 +00:00
Ray Speth
934010136d Removed unnecessary temporaries used for storing return values 2013-02-14 01:04:07 +00:00
Ray Speth
e04e59cdd3 Removed extraneous parentheses around arguments to 'return' 
'return' is a keyword, not a function, so these parens are unnecessary.
 2013-02-14 01:03:48 +00:00
Ray Speth
6d6e237f07 Removed unnecessary checks surrounding delete operations 2013-02-14 01:03:32 +00:00
Ray Speth
7da738d238 Re-applied consistent formatting to trunk 
Applied using: astyle -n --style=kr --add-brackets --indent=spaces=4
--indent-col1-comments --unpad-paren --pad-header --align-pointer=type
--lineend=linux
 2013-02-07 23:40:59 +00:00
Ray Speth
a1d24776f1 Fixed setting m_nsp in TransportBase 2013-02-07 23:40:48 +00:00
Ray Speth
83097b3860 Consolidated definitions of repeatedly-used constants 
"MIN_X" and "TINY" are replaced by "Tiny". "xxSmall" is replaced with
"SmallNumber".
 2013-01-11 22:55:46 +00:00
Ray Speth
6b8986d0d0 Fixed const-ness of PecosTransport virtual functions 
These now match the function signatures in the base class.
 2012-12-26 23:56:10 +00:00
Harry Moffat
eab8781ea7 Added back ability to get transport parameters from transport objects. 
Added back read and write of named XML array blocks.
Fixed an error in IonsFromNeutralVPSSTP.
 2012-12-21 01:18:28 +00:00
Victor Brunini
95e66cd5ff Get rid of static variables in member functions. 2012-12-17 16:14:14 +00:00
Harry Moffat
ea25de7fe7 Continuing transfering LiquidTransport changes, doing bugfixes, and 
qualifying against our testsuite.
 2012-12-15 00:49:14 +00:00
Victor Brunini
bd653e357f Revert change to LiquidTransport. 2012-12-13 22:16:50 +00:00
Victor Brunini
749f988e52 Convert LiquidTransport to just store a pointer to the external 
gradient (T, X, V) values that it uses to compute fluxes. These
are never changed by the LiquidTransport object so there is no
reason to have them stored locally rather than just holding a pointer
to the data.
 2012-12-13 22:15:35 +00:00
Victor Brunini
d4d1093957 Performance improvements focused on Stefan-Maxwell liquid transport 
model for molten salts.

Summary:
- Division is expensive, replace repeated division with multiplication
  by stored 1/x.
- New and delete are expensive, make working vectors in some functions
  static so that they are not repeatedly instantiated and deleted.
- Reorder a few loops to reduce computation and hopefully cache misses.
 2012-12-13 22:14:36 +00:00
Harry Moffat
64d252fdbf Rolled back some of the changes that Victor made that actually 
changed the S-M formula.
 2012-11-26 21:37:11 +00:00
Victor Brunini
985b1f07a8 Correctly size grad_lnAC so that we don't write past the end of it 
for 2D and 3D problems.

Fix the creation of the Stefan-Maxwell matrix coefficients.
 2012-11-26 20:20:52 +00:00
Victor Brunini
c3233c1355 Update TransportFactory to allow the specification of the number of 
dimensions in the problem and default it to 1. At present this is
only passed through to the LiquidTransport constructor.

Remove LiquidTransport member m_nDim since the base Transport class
already stores m_nDim.

Don't set m_nDim to 1 in LiquidTransport constructor, it is set by
the Transport constructor.
 2012-11-26 20:19:57 +00:00
Victor Brunini
7d8a61baf1 Clean up function prototypes to avoid 'a is hidden by b' warnings 
where the subclass prototype had an int and the super had a size_t
for a virtual function of the same name.
 2012-11-14 00:04:05 +00:00
Victor Brunini
28171eeece Update the definition of getSpeciesFluxesES to use all size_t 
instead of int to match the definition for the base Transport class.
Prior to this LiquidTransport::getSpeciesFluxesES was not overriding
the virtual Transport::getSpeciesFluxesES because the prototypes
differed.
 2012-11-13 21:59:11 +00:00
Victor Brunini
7c70568bb3 Clean up compiler warnings. 2012-11-07 21:08:56 +00:00
Ray Speth
436f38c6a6 Removed some unused member variables from Transport classes 2012-10-24 15:46:45 +00:00
Ray Speth
94d08f1d5e Removed unnecessary casts from object duplication functions 2012-10-24 15:45:33 +00:00
Ray Speth
f4d35e4bd7 Always pass "const std::string&" instead of "const std::string" 2012-10-24 15:44:54 +00:00
Ray Speth
1d19803885 Pass "const std::string&" instead of "std::string" when possible 2012-10-24 15:42:51 +00:00
Ray Speth
5f2ec1f11d Added ability to switch between transport models in the Cython module 2012-09-06 19:59:45 +00:00
Ray Speth
85d9d360c7 Fixed a bunch of spelling issues 2012-08-17 16:43:34 +00:00
Ray Speth
08f1e48371 Fixed calculation of some multicomponent transport properties 
For some properties, the internal temperature-dependent properties
were being updated in the wrong order.

cherry-pick of r1636 from 2.0 maintenance branch
 2012-08-13 20:14:10 +00:00
Ray Speth
24d7a3e091 Removed some unused exception classes 2012-08-08 22:17:22 +00:00
Ray Speth
346605abc4 Removed some unused CTML functions 2012-08-08 22:17:05 +00:00
Nicholas Malaya
77bb5e15ce removing several deprecated header files from the makefile.ams. In addition, headers should now be properly installed by the make install step 2012-07-18 22:54:54 +00:00
Ray Speth
3ce3da1fa2 Fixed code formatting 2012-07-18 18:32:29 +00:00
Nicholas Malaya
f9f6a93c39 removing a cout that was not necessary 2012-07-17 22:09:57 +00:00
Nicholas Malaya
d9381b55da merging into cantera 2.0 the pecos autotools trunk 2012-07-17 21:12:16 +00:00
Ray Speth
8611f43eb0 Removed deprecated 'GasTransportData' struct 
Simplified implementation of TransportFactory::getTransportData,
and removed data members of MixTransport and MultiTransport that
were only used to fill in the GasTransportData structure.
 2012-07-16 22:18:58 +00:00
Ray Speth
cfe5824a7d Removed some deprecated code 2012-07-16 22:18:35 +00:00
Nicholas Malaya
255c1453db [cantera2.0]: more makefile.am adjustments... cantera autotools version is very nearly functioning now 2012-06-18 02:56:59 +00:00
Nicholas Malaya
92c5f5c57f [cantera2.0]: updating a few makefiles for the autotools version. Not yet working without link errors, but getting close 2012-06-18 02:29:29 +00:00
Ray Speth
9f6c79eaf8 Fixed thread safety of TransportFactory 2012-05-31 14:58:03 +00:00
Ray Speth
2970e0c693 Added a ScopedLock typedef that can be used without requiring extra any #ifdefs 2012-05-31 14:57:54 +00:00
Ray Speth
6011f24b38 Removed unnecessary WITH_FEATURE configuration options 2012-05-31 14:57:32 +00:00
Ray Speth
f24f8f6d3b Fixed update logic for temperature-dependent properties in MultiTransport 2012-05-30 16:02:35 +00:00
Ray Speth
d3e98fe5a8 Corrected a bunch of spelling errors 2012-05-29 21:21:47 +00:00
Ray Speth
9b2d97f41e Fixed some compiler warnings 2012-05-25 23:13:18 +00:00
Ray Speth
5af70f3db8 Removed keyword-substitution cruft 2012-05-24 16:29:29 +00:00
Ray Speth
cc2ed9b751 Fixed some small problems with GasTransport 2012-05-13 22:41:20 +00:00
Ray Speth
6167a724e5 Added functions for computing alternate mixture-averaged diffusion coefficients 2012-05-11 15:27:56 +00:00
Ray Speth
49b631d346 Merged mixture-averaged diffusion coefficient calculations in GasTransport 2012-05-11 15:27:50 +00:00
Ray Speth
f8308d5853 Merged viscosity calculations from MixTransport and MultiTransport 2012-05-11 15:27:44 +00:00
Ray Speth
74e9fa050b Removed a layer of indirection in MultiTransport property updaters 2012-05-11 15:27:38 +00:00