Commit graph

79 commits

Author SHA1 Message Date
Ray Speth
0bfdf146c0 [1D] Include transport derivatives when computing Jacobian for adjoint 2016-11-12 14:48:01 -05:00
BangShiuh
859eb6b94a [1D] Deprecate 'withSoret' argument of setTransport 2016-10-24 18:57:05 -04:00
BangShiuh
6d5e28ec46 [1D] Use c_offset_Y instead of literal value "4" 2016-10-19 17:40:04 -04:00
Ray Speth
f17750e483 Make species names case-preserving instead of case-sensitive
This improves interoperability when working with mechanisms which use differing
conventions for naming species using uppercase or lowercase.
2016-10-13 18:40:03 -04:00
Ray Speth
ecbfecd7fd Replace existing copyright notices with uniform copyright/license info 2016-10-10 22:19:01 -04:00
Ray Speth
4582e724ee Eliminate compiler warnings issued by Visual Studio 2015 2016-07-30 23:09:17 -04:00
Ray Speth
bd8a5d0bc9 [Transport] Replace numerical constants for Transport types with strings 2016-07-07 22:52:25 -04:00
Ray Speth
cd958a343b [1D] Make better use of local variables 2016-06-28 17:35:40 -04:00
Ray Speth
9ed23a57ab Move non-trivial functions out of header files 2016-04-08 19:13:09 -04:00
Ray Speth
9c632cf123 [1D] Remove unused / unimplemented methods from StFlow 2016-03-27 22:19:37 -04:00
Ray Speth
d52a0fdbcb [1D] Eliminate redundant parts of StFlow::showSolution 2016-03-27 21:19:45 -04:00
Ray Speth
b56094b183 [1D/Examples] eliminate unnecessary setting of tolerances
For most problems, these new default tolerances for both time stepping and
steady state solves are more likely to converge than tighter tolerances, but
still give well-resolved results. Tighter tolerances are required in some cases,
e.g. when evaluating sensitivity coefficients by finite difference.
2016-03-27 17:07:36 -04:00
Ray Speth
9f3821db82 [1D] Use most prevalent species to impose sum-of-mass-fractions constraint
Previously, the first species was always used, which could cause problems with
negative mass fractions in cases where the first species has a mass fraction
near zero.
2016-03-27 17:07:36 -04:00
Ray Speth
318fa04cf7 [1D] Reset negative species concentrations after a failed time step 2016-03-27 17:07:35 -04:00
Ray Speth
5a576a7c75 [1D] Tighten default negative species bounds 2016-03-25 12:21:19 -04:00
Ray Speth
f44b5fed57 Replace usage of int2str with cppformat and deprecate int2str 2016-02-04 19:11:49 -05:00
Ray Speth
34ff39e3df Clean up Doxygen docs and comments in OneD classes 2015-11-12 11:41:34 -05:00
Ray Speth
0647823ada Replace DATA_PTR macro with calls to data() 2015-10-17 18:58:50 -04:00
Ray Speth
3f6d8b0aca Use cppformat instead of int2str and fp2str 2015-10-14 18:45:23 -04:00
Ray Speth
1411419b0f [1D] Eliminate sprintf-style string formatting 2015-10-14 18:45:22 -04:00
Ray Speth
41527b1ea7 Rename two-argument version of writelog 'debuglog'
This is a prerequisite to allowing writelog to take an arbitrary number
of arguments.
2015-10-14 18:45:22 -04:00
Ray Speth
acdf9cf0ed Clean up interstitial whitespace
Remove extra space around operators, between words, etc.
2015-08-02 23:06:16 -04:00
Ray Speth
6a04193646 Fix un-bracketed if, for, and else statements 2015-08-02 23:06:15 -04:00
Ray Speth
e4c45b6429 General whitespace cleanup
Remove unnecessary blank lines and trailing whitespace. Replace tabs with
spaces.
2015-08-02 23:06:15 -04:00
Ray Speth
619cd20f14 Fix badly-formatted else/else if/catch clauses 2015-08-02 23:06:15 -04:00
Ray Speth
f1f10b6526 Remove unused, deprecated code marked for removal after Cantera 2.2 2015-07-15 12:08:50 -04:00
Ray Speth
5214672ab3 Merge namespace ctml with namespace Cantera 2015-05-27 18:09:07 -04:00
Ray Speth
ecb6242b79 Fix spelling errors 2015-04-08 19:36:55 -04:00
Ray Speth
b63d759918 [1D] Remove unused members of class StFlow 2015-01-15 21:15:24 +00:00
Ray Speth
020f3e756c [1D] Only update radiation flux for specified range grid points 2015-01-15 21:15:22 +00:00
Ray Speth
af447cb85f [1D] Avoid repeated search for indices of radiating species
Also, look for both uppercase and lowercase species names
2015-01-15 21:15:20 +00:00
Ray Speth
bade514587 [1D] Fix up getters/setters/default values for radiation values 2015-01-15 21:15:18 +00:00
Andreas Rücker
49c963143e [1D] Add simple radiation model for flames
Implements the radiation model of Liu & Rogg (1991). Optically thin limit,
gray-gas approximation using Planck mean absorption coefficients. Considers
emissions from CO2 and H2O, with the temperature-dependent absorption
coefficients calculated using polynomial fits to results from RADCAL
(Grosshandler, 1993).
2015-01-15 21:15:15 +00:00
Ray Speth
cdf764be4a [Transport] Allow CK_Mix and CK_Multi transport models in 1D flames 2014-11-19 20:27:57 +00:00
Ray Speth
a208c54d1c Add a version of XML_Node::getChildren with a simpler interface 2014-10-22 21:48:04 +00:00
Ray Speth
2a69d99d83 [1D] Update thermo properties during Jacobian updates
In combination with the previous commit, this significantly improves the
convergence behavior of the solver when using multicomponent transport
properties. In many cases, the solver is now able to directly solve the
multicomponent problem directly from the mixture-averaged solution without any
timestepping.
2014-09-07 21:17:05 +00:00
Ray Speth
92f8fc4292 [1D] Change multicomponent diffusion calculation to improve convergence
Change the formulation of multicomponent diffusion fluxes to avoid using the
equivalent Fickian diffusion coefficient. That formulation leads to negative
diffusivities for some species at some grid points, which generate numerical
instabilities while timestepping. This formulation produces a more dense
Jacobian, but with a much better eigenvalue spectrum.
2014-09-07 21:17:03 +00:00
Ray Speth
002c158761 Cleanup include statements
Move includes from header to implementation files where possible, and remove
unnecessary includes.
2014-08-28 16:54:13 +00:00
Ray Speth
a2e3e97a1f [1D] Check that specified grid is monotonically increasing 2014-07-10 22:34:05 +00:00
Ray Speth
6c0cea5ee4 Standardize function used for writing a line of repeated characters 2014-05-27 02:53:06 +00:00
Ray Speth
789574ac80 Remove commented-out code 2014-05-27 02:52:21 +00:00
Ray Speth
54ded64e4b Miscellaneous whitespace cleanup 2014-05-08 23:01:12 +00:00
Ray Speth
aa4dcf393c [1D] Avoid Jacobian update after successful solve
Calling solve() again after a successful solution no longer automatically
triggers a Jacobian update. This enables relatively efficient sensitivity
analysis by sequentially perturbing the reaction multipliers and re-solving
the system. Since the perturbed system is close to the orignal, the solution
can be found after only a few steps, even when using the original Jacobian.
2014-03-24 04:03:44 +00:00
Ray Speth
d516d46f33 Remove unnecessary use of static_cast<int> 2014-01-31 23:15:09 +00:00
Ray Speth
904459c6b8 [1D] Remove unused 'importSolution' function 2014-01-23 04:20:35 +00:00
Ray Speth
cf0ff0c6fd [1D] Move m_zfixed and m_tfixed variables from Domain1D to FreeFlame
FreeFlame is the only subclass of Domain1D where these variables are used.
2014-01-21 17:21:43 +00:00
Ray Speth
a20fd58000 [1D] Fix save/restore when mechanism size differs
The failures were caused when attempting to restore the tolerance vectors, which
have a value for each species. Since these tolerances are usually the same for
all species, the last value in the array can be used to extend the array to the
required length.

Also add some tests for this feature.
2013-07-18 00:04:13 +00:00
Ray Speth
e7754fbcf2 [1D] Deprecate vector version of Domain1D::setBounds
The scalar version is actually easier to use in most cases.
2013-06-24 15:22:45 +00:00
Ray Speth
3e4c944416 [1D] Simplify interface for setting tolerances 2013-06-24 15:22:38 +00:00
Ray Speth
f75ba112f9 Clean up Doxygen docs for 1D simulation classes 2013-06-05 03:09:03 +00:00