Commit graph

1744 commits

Author SHA1 Message Date
Ray Speth
5967e952e6 Cleaned up Doxygen docs for functions declared in stringUtils.h 2013-04-12 23:07:15 +00:00
Ray Speth
eec1a6b3ec [1D] Removed min and max attributes from saved profiles
Actual array values could be outside the assumed bounds as a result of solver
tolerances, so it doesn't actually make sense to check these when restoring the
solution.

Resolves Issue 88.
2013-04-12 23:07:08 +00:00
Ray Speth
e13116c229 Cleaned up Doxygen documentation of XML-related classes 2013-04-12 23:07:02 +00:00
Ray Speth
1019cdb51e Cleaned up Doxygen docs for CTML functions 2013-04-12 23:06:54 +00:00
Ray Speth
59d615c8d2 Removed the useless SAFE_DELETE macro 2013-04-12 23:06:45 +00:00
Ray Speth
acdf1e3900 Cleaned up Doxygen docs for Stoichiometry Manager classes 2013-04-12 23:06:36 +00:00
Ray Speth
41a23e44d2 Cleaned up Doxygen docs for Reaction path related classes 2013-04-12 23:06:28 +00:00
Ray Speth
c43b02e130 Cleaned up Doxygen docs for KineticsFactory and ImportKinetics 2013-04-12 23:06:20 +00:00
Ray Speth
2326b07c68 [1D] Reset timestep after grid refinement
This addresses a performance issue where many failed timesteps would be
taken after adding new grid points. These failed timesteps are slow because
they require additional Jacobian re-evaluations. It is more efficient to
preemptively reduce the time step after adding new grid points.

Resolves Issue 155.
2013-04-12 23:06:05 +00:00
Ray Speth
255896715c Allow RedlichKwongMFTP objects to be constructed by newThermoPhase 2013-04-12 23:05:59 +00:00
Ray Speth
1909526ba7 Cleaned up Doxygen docs for class solveSP 2013-04-12 23:05:53 +00:00
Ray Speth
68c0270958 Cleaned up Doxygen docs for class ImplicitSurfChem 2013-04-12 23:05:46 +00:00
Ray Speth
76d3a03921 Updated Doxygen documentation for falloff-related classes 2013-04-12 23:05:38 +00:00
Ray Speth
d103ec8d2f Cleaned up Doxygen documentation for class Kinetics and descendants 2013-04-12 23:05:20 +00:00
Ray Speth
50617105b5 Removed inaccurately-named atofCheck in favor of fpValueCheck 2013-04-03 23:10:35 +00:00
Ray Speth
7b7d3ac0d4 Fixed locale-dependent processing of XML files
Floating point values are read using a std::stringstream imbued with the "C"
locale to avoid problems with using std::atof when the user's locale uses a
character other than "." as the decimal separator.

Patch provided by Phillip Berndt.

Fixes Issue 153.
2013-04-03 23:10:18 +00:00
Harry Moffat
cd387a15d7 Fixed an error due to negative size_t values 2013-04-03 19:26:58 +00:00
Harry Moffat
6434e1edca Tightened the tolerances on the phaseStability calculation routine.
Took out an unnecessary duplication of work.
2013-03-27 00:35:58 +00:00
Harry Moffat
94cb8cbb65 Fixed printout issues for interfacial voltage variables in equilibrium solver.
Added a global variable to indicate debug mode.
2013-03-26 02:26:35 +00:00
Harry Moffat
3c08cba848 Fixed a bug in the equilibrium solver
Potentials of electron phases were being altered when they shouldn't have been.
2013-03-23 01:06:36 +00:00
Ray Speth
9a1d6532ba Fixed compilation error when using Sundials 2.3 2013-03-13 20:20:27 +00:00
Ray Speth
c59ee86d5d [1D] Fixed restoration from XML files with missing fields
This improves compatibility with output files from older versions of Cantera
that don't save the 'energy_enabled' and 'species_enabled' flags.
2013-03-08 15:32:02 +00:00
Ray Speth
86ce3da4ef [1D] Save and restore grid refinement parameters 2013-03-07 18:51:36 +00:00
Ray Speth
302ebb2c7e [1D] Save and restore energy_enabled and species_enabled flags 2013-03-07 18:51:33 +00:00
Ray Speth
557078229f [1D] Save and restore solver tolerances 2013-03-07 18:51:31 +00:00
Ray Speth
01bc55e1bb [1D] Refactored Domain1D::save and Domain1D::restore
Derived class implementations now call the parent class method to save/restore
information represented in the parent class.
2013-03-07 18:51:23 +00:00
Ray Speth
e7f580148f Cleaned up Doxygen documentation for class WaterProps and friends 2013-03-07 18:51:17 +00:00
Ray Speth
b4506cebe1 Cleaned up Doxygen documentation for class VPSSMgr and descendants 2013-03-07 18:51:11 +00:00
Ray Speth
4671f857d0 Cleaned up Doxygen documentation for class StatMech 2013-03-07 18:51:08 +00:00
Ray Speth
01b57ba821 Cleaned up Doxygen documentation for thermo factory classes 2013-03-07 18:51:04 +00:00
Ray Speth
3a53ae3660 [1D] Fixed infinite loops in grid refinement / pruning
Improved determination of the conditions under which points can be removed
without violating the 'ratio' constraint. Previously, required points were being
removed from the grid.
2013-03-05 17:02:56 +00:00
Ray Speth
68b129eb96 [1D] Fixed singular Jacobian errors after grid modification
Modification of the grid can interfere with the way the fixed temperature point
is handled, leading to solver failures. To fix this, the temperature fixed point
is checked and may be recalculated at the start of the solver.
2013-03-05 17:02:53 +00:00
Ray Speth
246bbfa7fb [1D] Prevent removal of the grid point used for the fixed temperature 2013-03-05 17:02:50 +00:00
Ray Speth
6b9fc98fc8 [1D] Pruning may not remove adjacent grid points 2013-03-05 17:02:47 +00:00
Ray Speth
b3a1e1e47c [Cython/1D] 1D solver can be interrupted by ctrl-c
By calling a pure Python function each time OneDim::eval is called, we can
catch KeyboardInterrupt exceptions and abort the 1D solver loop, returning
control to Python.

Partially addresses Issue 93.
2013-03-04 17:31:41 +00:00
Ray Speth
229ef825f0 [Kinetics] Refactored GasKinetics to more easily support derived classes 2013-03-04 17:31:32 +00:00
Ray Speth
57a9a3f458 Cleaned up Doxygen documentation for class PDSS and descendants 2013-03-04 17:31:27 +00:00
Ray Speth
3426b73b7a Cleaned up Doxygen docs for class SpeciesThermoInterpType and descendants 2013-03-04 17:31:22 +00:00
Ray Speth
c68e01d475 Cleaned up Doxygen documentation for class SpeciesThermo and descendants 2013-03-04 17:31:19 +00:00
Ray Speth
c084148b0e [SCons] Python module can be installed to user's site-packages directory
Setting the scons options 'python_prefix=USER' or 'python3_prefix=USER' will
pass the '--user' flag to setup.py, causing the Python module to be installed to
a platform-specific directory on the user's module path.
2013-03-04 17:31:08 +00:00
Harry Moffat
3cc0aa1689 Fixed an overloaded operator error
Fixed a compilation error that occurred in DEBUG_MODE
2013-02-25 20:00:24 +00:00
Ray Speth
fae8197bd4 [Transport] Check that mole fractions are different before recalcuating
This avoids recomputing and factorizing the L matrix under some circumstances,
such as when both thermal conductivity and the Soret coefficients are requested
for the same mixture.
2013-02-15 17:32:19 +00:00
Ray Speth
529c9b762a [Transport] Fixed update of multicomponent diffusion coefficients
Certain temperature-dependent quantities used in computing multicomponent
diffusion coefficients were not being reliably updated. This caused convergence
issues for the 1D solver in some cases.
2013-02-15 17:32:16 +00:00
Ray Speth
8847b5abac [Kinetics] Ensure that equilibrium constants are not zero
This prevents reverse rate constants from becoming NaN when the forward rate
constant underflows.
2013-02-15 17:31:15 +00:00
Ray Speth
934010136d Removed unnecessary temporaries used for storing return values 2013-02-14 01:04:07 +00:00
Ray Speth
e04e59cdd3 Removed extraneous parentheses around arguments to 'return'
'return' is a keyword, not a function, so these parens are unnecessary.
2013-02-14 01:03:48 +00:00
Ray Speth
3b78634381 Removed extraneous parentheses around arguments to 'delete'.
'delete' is a keyword, not a function, so the parens are not necessary.
2013-02-14 01:03:42 +00:00
Ray Speth
6d6e237f07 Removed unnecessary checks surrounding delete operations 2013-02-14 01:03:32 +00:00
Ray Speth
4e3a79394b Eliminated some shadowing of member variables by function arguments 2013-02-14 01:03:19 +00:00
Ray Speth
70b08a6891 Eliminated some local variable shadowing 2013-02-14 01:03:13 +00:00