From d9f9f69fc37492e160556e553c58fb76e3114bda Mon Sep 17 00:00:00 2001 From: Ray Speth Date: Tue, 28 Aug 2018 19:52:31 -0400 Subject: [PATCH] [SCons/Test] Regression tests also look for input files in test/data This allows the elimination of a number of duplicate input files. --- .../data}/HMW_NaCl_sp1977_alt.xml | 0 .../NaCl_equil => test/data}/NaCl_Solid.xml | 0 .../data/liquid-water.xml | 15 -- test_problems/SConscript | 11 +- .../cathermo/HMW_graph_CpvT/NaCl_Solid.xml | 39 --- .../HMW_graph_GvT/HMW_NaCl_sp1977_alt.xml | 239 ------------------ .../cathermo/HMW_graph_GvT/NaCl_Solid.xml | 39 --- .../HMW_graph_HvT/HMW_NaCl_sp1977_alt.xml | 239 ------------------ .../cathermo/HMW_graph_HvT/NaCl_Solid.xml | 39 --- .../HMW_graph_VvT/HMW_NaCl_sp1977_alt.xml | 239 ------------------ .../cathermo/HMW_graph_VvT/NaCl_Solid.xml | 39 --- .../cathermo/stoichSub/NaCl_Solid.xml | 39 --- .../cathermo/testWaterTP/testWaterSSTP.cpp | 2 +- .../cathermo/wtWater/waterTPphase.xml | 54 ---- test_problems/cathermo/wtWater/wtWater.cpp | 2 +- 15 files changed, 8 insertions(+), 988 deletions(-) rename {test_problems/cathermo/HMW_graph_CpvT => test/data}/HMW_NaCl_sp1977_alt.xml (100%) rename {test_problems/VCSnonideal/NaCl_equil => test/data}/NaCl_Solid.xml (100%) rename test_problems/cathermo/testWaterTP/waterTPphase.xml => test/data/liquid-water.xml (73%) delete mode 100644 test_problems/cathermo/HMW_graph_CpvT/NaCl_Solid.xml delete mode 100644 test_problems/cathermo/HMW_graph_GvT/HMW_NaCl_sp1977_alt.xml delete mode 100644 test_problems/cathermo/HMW_graph_GvT/NaCl_Solid.xml delete mode 100644 test_problems/cathermo/HMW_graph_HvT/HMW_NaCl_sp1977_alt.xml delete mode 100644 test_problems/cathermo/HMW_graph_HvT/NaCl_Solid.xml delete mode 100644 test_problems/cathermo/HMW_graph_VvT/HMW_NaCl_sp1977_alt.xml delete mode 100644 test_problems/cathermo/HMW_graph_VvT/NaCl_Solid.xml delete mode 100644 test_problems/cathermo/stoichSub/NaCl_Solid.xml delete mode 100644 test_problems/cathermo/wtWater/waterTPphase.xml diff --git a/test_problems/cathermo/HMW_graph_CpvT/HMW_NaCl_sp1977_alt.xml b/test/data/HMW_NaCl_sp1977_alt.xml similarity index 100% rename from test_problems/cathermo/HMW_graph_CpvT/HMW_NaCl_sp1977_alt.xml rename to test/data/HMW_NaCl_sp1977_alt.xml diff --git a/test_problems/VCSnonideal/NaCl_equil/NaCl_Solid.xml b/test/data/NaCl_Solid.xml similarity index 100% rename from test_problems/VCSnonideal/NaCl_equil/NaCl_Solid.xml rename to test/data/NaCl_Solid.xml diff --git a/test_problems/cathermo/testWaterTP/waterTPphase.xml b/test/data/liquid-water.xml similarity index 73% rename from test_problems/cathermo/testWaterTP/waterTPphase.xml rename to test/data/liquid-water.xml index a58b5a2ba..3a0faf0af 100644 --- a/test_problems/cathermo/testWaterTP/waterTPphase.xml +++ b/test/data/liquid-water.xml @@ -35,20 +35,5 @@ - - - - - H:2 C:2 F:4 - - - 273.14999999999998 - 23083414.8686 - 167025.46599999999 - 0.0 - - - - diff --git a/test_problems/SConscript b/test_problems/SConscript index 17ec0fdf4..d4a5e9a3f 100644 --- a/test_problems/SConscript +++ b/test_problems/SConscript @@ -32,7 +32,8 @@ else: localenv['ENV']['PYTHON_CMD'] = localenv.subst('$python_cmd') haveConverters = True -localenv['ENV']['CANTERA_DATA'] = pjoin(os.getcwd(), '..', 'build', 'data') +localenv['ENV']['CANTERA_DATA'] = (Dir('#build/data').abspath + os.pathsep + + Dir('#test/data').abspath) # Add build/lib in order to find Cantera shared library if env['OS'] == 'Windows' or env['OS'] == 'Cygwin': @@ -183,7 +184,7 @@ Test('DH_graph_Pitzer', 'cathermo/DH_graph_1', CompileAndTest('HMW_graph_CpvT', 'cathermo/HMW_graph_CpvT', 'HMW_graph_CpvT', 'output_blessed.txt', extensions=['^HMW_graph_CpvT.cpp'], - arguments='HMW_NaCl_sp1977_alt.xml') + arguments=File('#test/data/HMW_NaCl_sp1977_alt.xml').abspath) CompileAndTest('HMW_graph_GvI', 'cathermo/HMW_graph_GvI', 'HMW_graph_GvI', None, comparisons=[('T298_blessed.csv', 'T298.csv'), @@ -193,15 +194,15 @@ CompileAndTest('HMW_graph_GvI', 'cathermo/HMW_graph_GvI', CompileAndTest('HMW_graph_GvT', 'cathermo/HMW_graph_GvT', 'HMW_graph_GvT', 'output_blessed.txt', extensions=['^HMW_graph_GvT.cpp'], - arguments='HMW_NaCl_sp1977_alt.xml') + arguments=File('#test/data/HMW_NaCl_sp1977_alt.xml').abspath) CompileAndTest('HMW_graph_HvT', 'cathermo/HMW_graph_HvT', 'HMW_graph_HvT', 'output_blessed.txt', extensions=['^HMW_graph_HvT.cpp'], - arguments='HMW_NaCl_sp1977_alt.xml') + arguments=File('#test/data/HMW_NaCl_sp1977_alt.xml').abspath) CompileAndTest('HMW_graph_VvT', 'cathermo/HMW_graph_VvT', 'HMW_graph_VvT', 'output_blessed.txt', extensions=['^HMW_graph_VvT.cpp'], - arguments='HMW_NaCl_sp1977_alt.xml') + arguments=File('#test/data/HMW_NaCl_sp1977_alt.xml').abspath) CompileAndTest('HMW_test_1', 'cathermo/HMW_test_1', 'HMW_test_1', 'output_noD_blessed.txt') CompileAndTest('HMW_test_3', 'cathermo/HMW_test_3', diff --git a/test_problems/cathermo/HMW_graph_CpvT/NaCl_Solid.xml b/test_problems/cathermo/HMW_graph_CpvT/NaCl_Solid.xml deleted file mode 100644 index d711be8ff..000000000 --- a/test_problems/cathermo/HMW_graph_CpvT/NaCl_Solid.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - - - - - - - O H C Fe Ca N Na Cl - - NaCl(S) - - 2.165 - - - - - - - - - - - Na:1 Cl:1 - - - - 50.72389, 6.672267, -2.517167, - 10.15934, -0.200675, -427.2115, - 130.3973 - - - - 2.165 - - - - - diff --git a/test_problems/cathermo/HMW_graph_GvT/HMW_NaCl_sp1977_alt.xml b/test_problems/cathermo/HMW_graph_GvT/HMW_NaCl_sp1977_alt.xml deleted file mode 100644 index 0e4b0e510..000000000 --- a/test_problems/cathermo/HMW_graph_GvT/HMW_NaCl_sp1977_alt.xml +++ /dev/null @@ -1,239 +0,0 @@ - - - - - - H2O(L) Cl- H+ Na+ OH- - - - 298.15 - 101325.0 - - Na+:6.0954 - Cl-:6.0954 - H+:2.1628E-9 - OH-:1.3977E-6 - - - - - - - - - - - - 0.0765, 0.008946, -3.3158E-6, - -777.03, -4.4706 - - 0.2664, 6.1608E-5, 1.0715E-6 , 0.0, 0.0 - 0.0 , 0.0, 0.0, 0.0, 0.0 - 0.00127, -4.655E-5, 0.0, - 33.317, 0.09421 - - 2.0 - - - - 0.1775, 0.0, 0.0, 0.0, 0.0 - 0.2945, 0.0, 0.0, 0.0, 0.0 - 0.0, 0.0, 0.0, 0.0, 0.0 - 0.0008, 0.0, 0.0, 0.0, 0.0 - 2.0 - - - - 0.0864, 0.0, 0.0, 0.0, 0.0 - 0.253, 0.0, 0.0, 0.0, 0.0 - 0.0, 0.0, 0.0, 0.0, 0.0 - 0.0044, 0.0, 0.0, 0.0, 0.0 - 2.0 - - - - -0.05 - - - - -0.05 - -0.006 - - - - 0.036 - - - - 0.036 - -0.004 - - - - H2O(L) - - O H C E Fe Si N Na Cl - - - - - - - - - - H:2 O:1 - - - - 7.255750050E+01, -6.624454020E-01, 2.561987460E-03, -4.365919230E-06, - 2.781789810E-09, -4.188654990E+04, -2.882801370E+02 - - - - - - - - - - - Na:1 E:-1 - +1 - - - - -57993.47558 , 305112.6040 , -592222.1591 , - 401977.9827 , 804.4195980 , 10625.24901 , - -133796.2298 - - - - - - - 0.00834 - - - - - - Cl:1 E:1 - -1 - - - - 0.00834 - - - - - 56696.2042 , -297835.978 , 581426.549 , - -401759.991 , -804.301136 , -10873.8257 , - 130650.697 - - - - - - - - H:1 E:-1 - +1 - - 0.0 - - - - 0.0 - 3 - - 0.0 , 0.0, 0.0 - - - 273.15, 298.15 , 623.15 - - - - - - - - O:1 H:1 E:1 - -1 - - - 0.00834 - - - - - 44674.99961 , -234943.0414 , 460522.8260 , - -320695.1836 , -638.5044716 , -8683.955813 , - 102874.2667 - - - - - - - - diff --git a/test_problems/cathermo/HMW_graph_GvT/NaCl_Solid.xml b/test_problems/cathermo/HMW_graph_GvT/NaCl_Solid.xml deleted file mode 100644 index d711be8ff..000000000 --- a/test_problems/cathermo/HMW_graph_GvT/NaCl_Solid.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - - - - - - - O H C Fe Ca N Na Cl - - NaCl(S) - - 2.165 - - - - - - - - - - - Na:1 Cl:1 - - - - 50.72389, 6.672267, -2.517167, - 10.15934, -0.200675, -427.2115, - 130.3973 - - - - 2.165 - - - - - diff --git a/test_problems/cathermo/HMW_graph_HvT/HMW_NaCl_sp1977_alt.xml b/test_problems/cathermo/HMW_graph_HvT/HMW_NaCl_sp1977_alt.xml deleted file mode 100644 index 0e4b0e510..000000000 --- a/test_problems/cathermo/HMW_graph_HvT/HMW_NaCl_sp1977_alt.xml +++ /dev/null @@ -1,239 +0,0 @@ - - - - - - H2O(L) Cl- H+ Na+ OH- - - - 298.15 - 101325.0 - - Na+:6.0954 - Cl-:6.0954 - H+:2.1628E-9 - OH-:1.3977E-6 - - - - - - - - - - - - 0.0765, 0.008946, -3.3158E-6, - -777.03, -4.4706 - - 0.2664, 6.1608E-5, 1.0715E-6 , 0.0, 0.0 - 0.0 , 0.0, 0.0, 0.0, 0.0 - 0.00127, -4.655E-5, 0.0, - 33.317, 0.09421 - - 2.0 - - - - 0.1775, 0.0, 0.0, 0.0, 0.0 - 0.2945, 0.0, 0.0, 0.0, 0.0 - 0.0, 0.0, 0.0, 0.0, 0.0 - 0.0008, 0.0, 0.0, 0.0, 0.0 - 2.0 - - - - 0.0864, 0.0, 0.0, 0.0, 0.0 - 0.253, 0.0, 0.0, 0.0, 0.0 - 0.0, 0.0, 0.0, 0.0, 0.0 - 0.0044, 0.0, 0.0, 0.0, 0.0 - 2.0 - - - - -0.05 - - - - -0.05 - -0.006 - - - - 0.036 - - - - 0.036 - -0.004 - - - - H2O(L) - - O H C E Fe Si N Na Cl - - - - - - - - - - H:2 O:1 - - - - 7.255750050E+01, -6.624454020E-01, 2.561987460E-03, -4.365919230E-06, - 2.781789810E-09, -4.188654990E+04, -2.882801370E+02 - - - - - - - - - - - Na:1 E:-1 - +1 - - - - -57993.47558 , 305112.6040 , -592222.1591 , - 401977.9827 , 804.4195980 , 10625.24901 , - -133796.2298 - - - - - - - 0.00834 - - - - - - Cl:1 E:1 - -1 - - - - 0.00834 - - - - - 56696.2042 , -297835.978 , 581426.549 , - -401759.991 , -804.301136 , -10873.8257 , - 130650.697 - - - - - - - - H:1 E:-1 - +1 - - 0.0 - - - - 0.0 - 3 - - 0.0 , 0.0, 0.0 - - - 273.15, 298.15 , 623.15 - - - - - - - - O:1 H:1 E:1 - -1 - - - 0.00834 - - - - - 44674.99961 , -234943.0414 , 460522.8260 , - -320695.1836 , -638.5044716 , -8683.955813 , - 102874.2667 - - - - - - - - diff --git a/test_problems/cathermo/HMW_graph_HvT/NaCl_Solid.xml b/test_problems/cathermo/HMW_graph_HvT/NaCl_Solid.xml deleted file mode 100644 index d711be8ff..000000000 --- a/test_problems/cathermo/HMW_graph_HvT/NaCl_Solid.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - - - - - - - O H C Fe Ca N Na Cl - - NaCl(S) - - 2.165 - - - - - - - - - - - Na:1 Cl:1 - - - - 50.72389, 6.672267, -2.517167, - 10.15934, -0.200675, -427.2115, - 130.3973 - - - - 2.165 - - - - - diff --git a/test_problems/cathermo/HMW_graph_VvT/HMW_NaCl_sp1977_alt.xml b/test_problems/cathermo/HMW_graph_VvT/HMW_NaCl_sp1977_alt.xml deleted file mode 100644 index 0e4b0e510..000000000 --- a/test_problems/cathermo/HMW_graph_VvT/HMW_NaCl_sp1977_alt.xml +++ /dev/null @@ -1,239 +0,0 @@ - - - - - - H2O(L) Cl- H+ Na+ OH- - - - 298.15 - 101325.0 - - Na+:6.0954 - Cl-:6.0954 - H+:2.1628E-9 - OH-:1.3977E-6 - - - - - - - - - - - - 0.0765, 0.008946, -3.3158E-6, - -777.03, -4.4706 - - 0.2664, 6.1608E-5, 1.0715E-6 , 0.0, 0.0 - 0.0 , 0.0, 0.0, 0.0, 0.0 - 0.00127, -4.655E-5, 0.0, - 33.317, 0.09421 - - 2.0 - - - - 0.1775, 0.0, 0.0, 0.0, 0.0 - 0.2945, 0.0, 0.0, 0.0, 0.0 - 0.0, 0.0, 0.0, 0.0, 0.0 - 0.0008, 0.0, 0.0, 0.0, 0.0 - 2.0 - - - - 0.0864, 0.0, 0.0, 0.0, 0.0 - 0.253, 0.0, 0.0, 0.0, 0.0 - 0.0, 0.0, 0.0, 0.0, 0.0 - 0.0044, 0.0, 0.0, 0.0, 0.0 - 2.0 - - - - -0.05 - - - - -0.05 - -0.006 - - - - 0.036 - - - - 0.036 - -0.004 - - - - H2O(L) - - O H C E Fe Si N Na Cl - - - - - - - - - - H:2 O:1 - - - - 7.255750050E+01, -6.624454020E-01, 2.561987460E-03, -4.365919230E-06, - 2.781789810E-09, -4.188654990E+04, -2.882801370E+02 - - - - - - - - - - - Na:1 E:-1 - +1 - - - - -57993.47558 , 305112.6040 , -592222.1591 , - 401977.9827 , 804.4195980 , 10625.24901 , - -133796.2298 - - - - - - - 0.00834 - - - - - - Cl:1 E:1 - -1 - - - - 0.00834 - - - - - 56696.2042 , -297835.978 , 581426.549 , - -401759.991 , -804.301136 , -10873.8257 , - 130650.697 - - - - - - - - H:1 E:-1 - +1 - - 0.0 - - - - 0.0 - 3 - - 0.0 , 0.0, 0.0 - - - 273.15, 298.15 , 623.15 - - - - - - - - O:1 H:1 E:1 - -1 - - - 0.00834 - - - - - 44674.99961 , -234943.0414 , 460522.8260 , - -320695.1836 , -638.5044716 , -8683.955813 , - 102874.2667 - - - - - - - - diff --git a/test_problems/cathermo/HMW_graph_VvT/NaCl_Solid.xml b/test_problems/cathermo/HMW_graph_VvT/NaCl_Solid.xml deleted file mode 100644 index d711be8ff..000000000 --- a/test_problems/cathermo/HMW_graph_VvT/NaCl_Solid.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - - - - - - - O H C Fe Ca N Na Cl - - NaCl(S) - - 2.165 - - - - - - - - - - - Na:1 Cl:1 - - - - 50.72389, 6.672267, -2.517167, - 10.15934, -0.200675, -427.2115, - 130.3973 - - - - 2.165 - - - - - diff --git a/test_problems/cathermo/stoichSub/NaCl_Solid.xml b/test_problems/cathermo/stoichSub/NaCl_Solid.xml deleted file mode 100644 index d711be8ff..000000000 --- a/test_problems/cathermo/stoichSub/NaCl_Solid.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - - - - - - - O H C Fe Ca N Na Cl - - NaCl(S) - - 2.165 - - - - - - - - - - - Na:1 Cl:1 - - - - 50.72389, 6.672267, -2.517167, - 10.15934, -0.200675, -427.2115, - 130.3973 - - - - 2.165 - - - - - diff --git a/test_problems/cathermo/testWaterTP/testWaterSSTP.cpp b/test_problems/cathermo/testWaterTP/testWaterSSTP.cpp index cc1dd8bee..2e1a433a2 100644 --- a/test_problems/cathermo/testWaterTP/testWaterSSTP.cpp +++ b/test_problems/cathermo/testWaterTP/testWaterSSTP.cpp @@ -20,7 +20,7 @@ int main() #endif double pres; try { - ThermoPhase* w = newPhase("waterTPphase.xml"); + ThermoPhase* w = newPhase("liquid-water.xml"); /* * Print out the triple point conditions diff --git a/test_problems/cathermo/wtWater/waterTPphase.xml b/test_problems/cathermo/wtWater/waterTPphase.xml deleted file mode 100644 index a58b5a2ba..000000000 --- a/test_problems/cathermo/wtWater/waterTPphase.xml +++ /dev/null @@ -1,54 +0,0 @@ - - - - - - - O H - H2O - - 300.0 - 101325.0 - - - - - - - - - - - - - H:2 O:1 - - - - 4.198640560E+00, -2.036434100E-03, 6.520402110E-06, -5.487970620E-09, - 1.771978170E-12, -3.029372670E+04, -8.490322080E-01 - - - - 3.033992490E+00, 2.176918040E-03, -1.640725180E-07, -9.704198700E-11, - 1.682009920E-14, -3.000429710E+04, 4.966770100E+00 - - - - - - - - H:2 C:2 F:4 - - - 273.14999999999998 - 23083414.8686 - 167025.46599999999 - 0.0 - - - - - - diff --git a/test_problems/cathermo/wtWater/wtWater.cpp b/test_problems/cathermo/wtWater/wtWater.cpp index 1cdd18437..b1f2c09fe 100644 --- a/test_problems/cathermo/wtWater/wtWater.cpp +++ b/test_problems/cathermo/wtWater/wtWater.cpp @@ -20,7 +20,7 @@ int main() { try { double lambda; - ThermoPhase* w = newPhase("waterTPphase.xml"); + ThermoPhase* w = newPhase("liquid-water.xml"); WaterTransport* wtTran = new WaterTransport(w, 3); printf("------------------------------------------------------------------------------------\n");