research/cantera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Numerics] Fix invalid dereference in SquareMatrix::factor

Browse source 
The work array hasn't always been allocated, so taking its address isn't
necessarily valid. Also, dlange doesn't use the work array in the '1' norm
case anyway.

Cherry-pick of trunk commit 2830.
This commit is contained in:
Ray Speth 2014-03-24 21:37:16 +00:00
parent fe858b39f3
commit 70e0553792
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/numerics/SquareMatrix.cpp
View file

@ -131,7 +131,7 @@ int SquareMatrix::factor()
if (useQR_) {
return factorQR();
}
a1norm_ = ct_dlange('1', m_nrows, m_nrows, &(*(begin())), m_nrows, DATA_PTR(work));
a1norm_ = ct_dlange('1', m_nrows, m_nrows, &(*(begin())), m_nrows, 0);
integer n = static_cast<int>(nRows());
int info=0;
m_factored = 1;