research/cantera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix "catching polymorphic type" GCC 8 warnings

Browse source 
The "catching polymorphic type" warnings appear during compilation with GCC 8:

src/base/global.cpp: In function ‘void Cantera::setLogger(Cantera::Logger*)’:
src/base/global.cpp:28:19: warning: catching polymorphic type ‘class std::bad_alloc’ by value [-Wcatch-value=]
     } catch (std::bad_alloc) {
                   ^~~~~~~~~

src/equil/vcs_MultiPhaseEquil.cpp: In member function ‘int Cantera::vcs_MultiPhaseEquil::equilibrate_HP(doublereal, int, double, double, int, int, doublereal, int, int)’:
src/equil/vcs_MultiPhaseEquil.cpp:228:31: warning: catching polymorphic type ‘class Cantera::CanteraError’ by value [-Wcatch-value=]
         } catch (CanteraError err) {
                               ^~~

src/equil/vcs_MultiPhaseEquil.cpp: In member function ‘int Cantera::vcs_MultiPhaseEquil::equilibrate_SP(doublereal, double, double, int, int, doublereal, int, int)’:
src/equil/vcs_MultiPhaseEquil.cpp:354:31: warning: catching polymorphic type ‘class Cantera::CanteraError’ by value [-Wcatch-value=]
         } catch (CanteraError err) {
                               ^~~

This commit fix this warnings via caught by reference.
This commit is contained in:
band-a-prend 2019-08-09 03:24:54 +03:00 • committed by Ray Speth
parent 1606ce1565
commit 5184ebccba
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/base/global.cpp
View file

@ -25,7 +25,7 @@ void setLogger(Logger* logwriter)
{ {
try { try {
app()->setLogger(logwriter); app()->setLogger(logwriter);
} catch (std::bad_alloc) { } catch (const std::bad_alloc&) {
logwriter->error("bad alloc thrown by app()"); logwriter->error("bad alloc thrown by app()");
} }
} }

4
src/equil/vcs_MultiPhaseEquil.cpp
View file

@ -225,7 +225,7 @@ int vcs_MultiPhaseEquil::equilibrate_HP(doublereal Htarget,
Tnew = 0.5*Tnow; Tnew = 0.5*Tnow;
} }
m_mix->setTemperature(Tnew); m_mix->setTemperature(Tnew);
} catch (CanteraError err) { } catch (const CanteraError& err) {
if (!estimateEquil) { if (!estimateEquil) {
strt = -1; strt = -1;
} else { } else {
@ -351,7 +351,7 @@ int vcs_MultiPhaseEquil::equilibrate_SP(doublereal Starget,
Tnew = 0.5*Tnow; Tnew = 0.5*Tnow;
} }
m_mix->setTemperature(Tnew); m_mix->setTemperature(Tnew);
} catch (CanteraError err) { } catch (const CanteraError& err) {
if (!estimateEquil) { if (!estimateEquil) {
strt = -1; strt = -1;
} else { } else {