research/cantera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Thermo] Deprecate class SemiconductorPhase

Browse source 
Can't be constructed from ThermoFactory, and constructor from file is not
implemented. Also, the getChemPotentials method uses the m_work array, which is
never initialized because the private method initLengths() is never called.

See #267
This commit is contained in:
Ray Speth 2016-04-16 21:04:36 -04:00
parent f583bd4530
commit 111b4909c9
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
include/cantera/thermo/SemiconductorPhase.h
View file

@ -21,12 +21,16 @@ const int cHole = 1;
* @ingroup thermoprops * @ingroup thermoprops
* *
* Class SemiconductorPhase represents electrons and holes in a semiconductor. * Class SemiconductorPhase represents electrons and holes in a semiconductor.
* @deprecated Broken and unused. To be removed after Cantera 2.3.
* *
*/ */
class SemiconductorPhase : public ThermoPhase class SemiconductorPhase : public ThermoPhase
{ {
public: public:
SemiconductorPhase() {} SemiconductorPhase() {
warn_deprecated("class SemiconductorPhase",
"To be removed after Cantera 2.3.");
}
SemiconductorPhase(std::string infile, std::string id=""); SemiconductorPhase(std::string infile, std::string id="");
SemiconductorPhase(const SemiconductorPhase& right) { SemiconductorPhase(const SemiconductorPhase& right) {

5
src/thermo/SemiconductorPhase.cpp
View file

@ -11,7 +11,10 @@ static doublereal JoyceDixon(doublereal r)
} }
SemiconductorPhase::SemiconductorPhase(std::string infile, SemiconductorPhase::SemiconductorPhase(std::string infile,
std::string id_) {} std::string id_) {
warn_deprecated("class SemiconductorPhase",
"To be removed after Cantera 2.3.");
}
void SemiconductorPhase::getChemPotentials(doublereal* mu) const void SemiconductorPhase::getChemPotentials(doublereal* mu) const
{ {