Commit graph

1608 commits

Author SHA1 Message Date
Will Bainbridge
ee536e6878 CloudFunctionObjects: ParticleTrap: Corrected example usage
Resolves bug report https://bugs.openfoam.org/view.php?id=2805
2018-01-11 08:55:14 +00:00
Henry Weller
c409ae7d90 RBD: restraints: Corrected restraint force transformations
From commit d4c479cb6447dbfd920bbe3e0204b70a1d5fbb03 in OpenFOAM-dev

The restraints generate either joint-local (tau) or global (fx) forces.
At the moment they all generate the latter. This change corrects three
of the four restraints so that the forces are in the gobal coordinate
system and not the local coordinate system of the body.

The problem with this is that the forward dynamics code then transforms
most of the forces back to the body local coordinate system. A better
solution would be to associate restraints which are more sensibly
defined in a local frame with the joints instead of the bodies, and
return the forces as part of the tau variable.
2018-01-08 10:58:00 +00:00
Henry Weller
6c5c27c0b1 sampledSets: Corrected curve distance list ordering in parallel
Resolves bug-report https://bugs.openfoam.org/view.php?id=2792
2017-12-18 16:15:19 +00:00
Henry Weller
73d878406f compressibleInterFoam family: Corrected transonic option
Resolves bug-report https://bugs.openfoam.org/view.php?id=2785
2017-12-10 13:41:41 +00:00
Henry Weller
b486157a61 OSspecific/POSIX: Updated function name in diagnostic messages
Patch contributed by Bruno Santos
Resolves bug-report https://bugs.openfoam.org/view.php?id=2786
2017-12-10 11:10:50 +00:00
Will Bainbridge
ce59c4abf7 particle: Corrected property list for barycentric coordinates
This resolves bug report https://bugs.openfoam.org/view.php?id=2777
2017-12-01 16:15:22 +00:00
Will Bainbridge
e00301939f polyMesh: Stopped re-seeding of RNG on each cell-tree update
This resolves bug report https://bugs.openfoam.org/view.php?id=2772
2017-11-29 11:34:54 +00:00
Henry Weller
a268af9720 wallHeatFlux: Changed sign of radiative heat flux contribution
to compensate for the inconsistent definition of this flux

Resolves bug-report https://bugs.openfoam.org/view.php?id=2722
2017-11-29 10:59:01 +00:00
Henry Weller
dfa9d0787d fileOperation: Corrected processor counting for moving mesh cases
Also resolves bug-report https://bugs.openfoam.org/view.php?id=2774
2017-11-28 13:01:08 +00:00
Henry Weller
538044ac05 decomposedBlockData: Updated to support 64-bit labels
Patch contributed by Mattijs Janssens
Resolves bug-report https://bugs.openfoam.org/view.php?id=2747
2017-11-03 15:20:15 +00:00
Henry Weller
83293fa32e UPstream: Added const_cast for OpenMPI versions < 1.7.4
Note
    The const_cast used in this file is a temporary hack for to work around
    bugs in OpenMPI for versions < 1.7.4
2017-11-03 14:39:28 +00:00
Henry Weller
ba26df7ed6 temperatureCoupledBase: Added more user-friendly error messages for inconsistent input
Resolves bug-report https://bugs.openfoam.org/view.php?id=2748
2017-11-02 14:56:30 +00:00
Henry Weller
5f49a69300 CompactSpatialTensor: Corrected constructor from components 2017-10-31 10:07:06 +00:00
Henry Weller
197d9d3bf2 collatedFileOperation: preferentially collect all data in the simulation thread
so the write thread does not have to do any parallel communication.  This avoids
the bugs in the threading support in OpenMPI.

Patch contributed by Mattijs Janssens
Resolves bug-report https://bugs.openfoam.org/view.php?id=2669
2017-10-29 08:38:31 +00:00
Henry Weller
16416c79ec collatedFileOperation: preferentially collect all data in the simulation thread
so the write thread does not have to do any parallel communication.  This avoids
the bugs in the threading support in OpenMPI.

Patch contributed by Mattijs Janssens
Resolves bug-report https://bugs.openfoam.org/view.php?id=2669
2017-10-28 09:24:47 +01:00
Henry Weller
28fdc3c4e8 mirrorMesh: Added support for cellLevel and pointLevel to support dynamic mesh refinement
Patch contributed by Mattijs Janssens
Resolves bug-report https://bugs.openfoam.org/view.php?id=2712
2017-10-27 15:25:29 +01:00
Henry Weller
effd8186ab Matrix: Corrected size of field resulting from rectangular matrix multiplication
Resolves bug-report https://bugs.openfoam.org/view.php?id=2740
2017-10-26 15:54:23 +01:00
Will Bainbridge
d8a1697d22 waveAlphaFvPatchScalarField: Write liquid flag
Resolves bug report https://bugs.openfoam.org/view.php?id=2734
2017-10-23 16:24:43 +01:00
Will Bainbridge
26b8a50286 functionObjects: nearWallFields: Fixed particle not found error
Removed all the special handling for awkward particles from the
nearWallFields function object. The version 5+ tracking already handles
this more robustly.

Resolves bug-report https://bugs.openfoam.org/view.php?id=2728
2017-10-20 11:47:44 +01:00
Henry Weller
638557bb4c functionObjects::nearWallFields: Set patch types of the sampled field to calculated
Resolves bug-report https://bugs.openfoam.org/view.php?id=2729
2017-10-20 10:47:14 +01:00
Henry Weller
00efd091d1 externalWallHeatFluxTemperatureFvPatchScalarField: Set size of option fields before mapping
Resolves problem with reconstruction
2017-10-16 17:18:23 +01:00
Henry Weller
2d5af005e5 blockMesh: Corrected diagram printed with "-help" to be consistent with the documentation
Resolves bug report https://bugs.openfoam.org/view.php?id=2710
2017-10-13 11:30:57 +01:00
Will Bainbridge
f05ccec6e8 PatchInteraction: Added "none" to list of interaction type names 2017-10-10 09:12:57 +01:00
Henry Weller
a36ee338ae GAMG: removed warnComm 2017-09-01 16:43:24 +01:00
Henry Weller
437961d247 externalWallHeatFluxTemperature: Allow manipulation of the boundary values
Provides support for the limitTemperature fvOption.

Resolves bug-report https://bugs.openfoam.org/view.php?id=2675
2017-08-29 16:48:56 +01:00
Henry Weller
3fe7aa77e6 Time::purgeWrite: Corrected handling of collated processors directory
Resolves bug-report https://bugs.openfoam.org/view.php?id=2667
2017-08-17 14:55:03 +01:00
Henry Weller
af02f92b9e swirlFlowRateInletVelocityFvPatchVectorField: Avoid calculating origin and axis for patches with no faces
Resolves problem with reconstructPar
2017-08-16 14:22:02 +01:00
Will Bainbridge
18d3aa150e externalWallHeatFluxTemperature: Fixed restart
Resolves bug report https://bugs.openfoam.org/view.php?id=2665
2017-08-15 14:22:04 +01:00
Will Bainbridge
90ce63f694 ThermoParcel: Improved numerical stability of heat transfer term
Patch contributed by Timo Niemi, VTT.
Resolves bug-report https://bugs.openfoam.org/view.php?id=2655
2017-08-14 08:59:43 +01:00
Will Bainbridge
718111a3b2 waves: Improved handling of reversed flow and additional wave models
The wave library from dev has been copied over into 5.x. It is still
backwards compatible. This change has fixed a failure in the DTCHullWave
tutorial.
2017-08-08 10:32:12 +01:00
Henry Weller
f5c3640f1c Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-5.x 2017-08-03 10:48:36 +01:00
Henry Weller
ef412e1b83 argList: addition of fileHandler option moved to argList.C
Patch contributed by Timo Niemi, VTT.
Resolves bug-report https://bugs.openfoam.org/view.php?id=2645
2017-08-03 10:47:55 +01:00
Will Bainbridge
9d57e8795a lagrangian: Always set switchProcessor flag
The TrackData::switchProcessor flag was not being set for some of the
tracking steps made by the more complicated parcels. In the case that a
parcel starts the step already on a processor boundary, this sometimes
lead to the particle being transferred back and forth indefinitely. The
flag is now explicitly set in all cases.
2017-08-02 10:13:05 +01:00
Will Bainbridge
bfda106526 lagrangian: Fixed argument passing from Colliding to Kinematic parcel component constructor
Resolves bug report https://bugs.openfoam.org/view.php?id=2643
2017-07-31 16:53:20 +01:00
Will Bainbridge
3ece3e9e81 fvOptions: limitVelocity: Fixed the correction factor
Resolves bug report https://bugs.openfoam.org/view.php?id=2634
2017-07-27 15:19:12 +01:00
Henry Weller
dbb428a3a8 Updated to OpenFOAM-5.x 2017-07-25 14:23:49 +01:00
Henry Weller
b11b28db06 surfaceFilmModels::transferModelList: Resolve problem with the Intel C++ compiler 2017-07-25 12:19:37 +01:00
Henry Weller
3fba921563 POSIX::fileStat: Avoid warning from gcc 2017-07-25 00:03:09 +01:00
Henry Weller
d1b59e976d MULES: Improve handling of very small geometries 2017-07-24 10:35:54 +01:00
Henry Weller
c6f365f6cc refineMesh: Correct parallel operation
Patch contributed by Mattijs Janssens
Resolves bug-report https://bugs.openfoam.org/view.php?id=2621
2017-07-22 22:39:40 +01:00
Henry Weller
0c4175bec7 surfaceFilmModels: 0.333 -> 1.0/3.0 and 0.666 -> 2.0/3.0
Resolves bug-report https://bugs.openfoam.org/view.php?id=2629
2017-07-21 17:38:31 +01:00
Henry Weller
53a524a280 Simplified scalar(0.0) -> scalar(0) and scalar(1.0) -> scalar(1) 2017-07-21 17:37:37 +01:00
Henry Weller
1937f7bca2 Radiation: Renamed Qin -> qin, Qem -> qem for consistency with qr
See also commit 8aac0a1808
2017-07-21 09:25:52 +01:00
Will Bainbridge
e879da1341 lagrangian: Fixed infinite loops
Tracking through an inverted region of the mesh happens in a reversed
direction relative to a non-inverted region. Usually, this allows the
tracking to propagate normally, regardless of the sign of the space.
However, in rare cases, it is possible for a straight trajectory to form
a closed loop through both positive and negative regions. This causes
the tracking to loop indefinitely.

To fix this, the displacement through inverted regions has been
artifically increased by a small amount (1% at the moment). This has the
effect that the change in track fraction over the negative part of the
loop no longer exactly cancels the change over the positive part, and
the track therefore terminates.
2017-07-19 16:56:58 +01:00
Henry Weller
177d1d762c reactingOneDim: Correct reporting of temperature range in parallel
Patch Contributed by Karl Meredith, FM Global.
Resolves bug-report https://bugs.openfoam.org/view.php?id=2621
2017-07-19 12:45:23 +01:00
Henry Weller
829a109b2f New BCs: Updated for clang 2017-07-17 17:02:42 +01:00
Henry Weller
01fe45deef New BCs: Updated for single-precision compilation 2017-07-17 16:54:48 +01:00
Henry Weller
12d5d001d2 matchedFlowRateOutletVelocity: New flow-rate outlet BC
Velocity outlet boundary condition which corrects the extrapolated velocity
to match the flow rate of the specified corresponding inlet patch.
2017-07-17 15:48:39 +01:00
Henry Weller
a10d2c3b3a swirlInletVelocity: New general swirl inlet BC
which support the specification of the individual velocity components (axial,
radial and tangential) as Function1s.
2017-07-17 15:47:24 +01:00
Henry Weller
4fa0192e1d flowRateInletVelocity extrapolated: Removed reverse flow and correct only the normal component
Improved stability and convergence.
2017-07-17 12:18:47 +01:00