Commit graph

1148 commits

Author SHA1 Message Date
Henry Weller
c989277b5e thermoSingleLayer::q: Use a local "alpha" without hydrophilic/phobic adjustment
Resolves bug-report https://bugs.openfoam.org/view.php?id=2605
2017-07-10 12:08:28 +01:00
Henry Weller
f71eecf0cc DimensionedField: Correct database registration of fields created with new names 2017-06-18 20:36:15 +01:00
Henry Weller
bf3559e6be fixedShearStressFvPatchVectorField: Removed duplicate "value" entry
Resolves bug-report https://bugs.openfoam.org/view.php?id=2556
2017-05-18 19:58:03 +01:00
Henry Weller
783d6cf640 Updated header 2017-05-18 19:57:52 +01:00
Henry Weller
bb1309bee1 kqRWallFunctionFvPatchField: Corrected scope 2017-05-18 19:57:16 +01:00
Henry Weller
e4bbb06941 sixDoFRigidBodyMotion: Corrected handling of acceleration update in first time-step
Resolves bug-report https://bugs.openfoam.org/view.php?id=2551
2017-05-18 16:31:47 +01:00
Henry Weller
ecc796de76 thermophysicalModels: Corrected alphah to be enthalpy based
in

solidSpecie/transport/const/constAnIsoSolidTransport
solidSpecie/transport/const/constIsoSolidTransport
solidSpecie/transport/exponential/exponentialSolidTransport
solidSpecie/transport/polynomial/polynomialSolidTransport
specie/transport/logPolynomial/logPolynomialTransport
specie/transport/polynomial/polynomialTransport
specie/transport/sutherland/sutherlandTransport

Resolves bug-report https://bugs.openfoam.org/view.php?id=2532
2017-05-04 12:01:57 +01:00
Henry Weller
f10cfe3fb0 functionObjects::fieldAverage: Initialize totalTime_ for new fields following restart
Patch contributed by Timo Niemi, VTT.
Resolves bug-report https://bugs.openfoam.org/view.php?id=2510
2017-05-03 18:44:17 +01:00
Henry Weller
56a4152a93 faceOnlySet, uniformSet: Reset mesh.moving before returning
Resolves bug-report https://bugs.openfoam.org/view.php?id=2514
2017-03-29 23:17:46 +01:00
Henry Weller
1e24adef1f Updated header 2017-03-22 19:11:10 +00:00
Henry Weller
ec0c14f527 functionObjects::wallShearStress: Corrected dimensions for compressible cases 2017-03-22 19:10:21 +00:00
Henry Weller
38af843e10 functionObjects::functionObjects: Corrected initial totalTime for cases with variable time-step
Resolves bug-report https://bugs.openfoam.org/view.php?id=2459
2017-03-20 17:24:13 +00:00
Henry Weller
17013e6f44 functionObjects::systemCall: Removed redundant Make directory 2017-03-17 09:01:59 +00:00
Henry Weller
dbcc59da2f functionObjects::systemCall: Removed unused entry from Make/files
Resolves bug-report https://bugs.openfoam.org/view.php?id=2503
2017-03-17 08:58:41 +00:00
Henry Weller
7d5fe2f3d9 turbulenceModels::RAS: Corrected sign of "C3" dilatation term
Set default value of C3 to 0
Set C3 to -0.33 in the engineFoam/kivaTest tutorial.

Resolves bug-report https://bugs.openfoam.org/view.php?id=2496
2017-03-13 17:59:24 +00:00
Henry Weller
16dbac4c03 Updated header 2017-03-10 11:07:01 +00:00
Henry Weller
71161ef0b8 CrankNicolsonDdtScheme: Corrected fvcDdtUfCorr for compressible flow
Resolves bug-report https://bugs.openfoam.org/view.php?id=2491
2017-03-10 11:06:00 +00:00
Henry Weller
efa306a033 turbulenceModels::LES::dynamicLagrangian: Converted advection to compressible convection form
Formally this is equivalent to the previous formulation but more convenient to
use given that for compressible flow the mass flux rather than the volume flux
is available.
2017-03-10 11:03:42 +00:00
Henry Weller
fc009a4fa2 LES::dynamicLagrangian: Corrected access to the volumetric flux for compressible flow
Resolves bug-report https://bugs.openfoam.org/view.php?id=2489
2017-03-09 09:39:41 +00:00
Henry Weller
6804c6cf49 GeometricField: corrected assignment to tmp which wraps a non-tmp 2017-02-22 13:18:33 +00:00
Henry Weller
89a346ec52 functionObjects::fieldCoordinateSystemTransform: added coordinateSystem sub-dict and updated the description
Patch contributed by Bruno Santos
Resolves bug-report https://bugs.openfoam.org/view.php?id=2454
2017-02-22 13:15:00 +00:00
Henry Weller
e964d879e2 csvSetWriter: Corrected axis header
Resolves bug-report https://bugs.openfoam.org/view.php?id=2455
2017-02-09 17:44:48 +00:00
Henry Weller
1decf44db0 functionObjects::scalarTransport: Corrected FatalError 2017-02-08 16:56:30 +00:00
Henry Weller
8f3169652e functionObjects::streamLine: Reinstated default "U" 2017-02-03 21:55:03 +00:00
Henry Weller
7c8d3866cb PBiCG: Suggest changing to the more robust PBiCGStab solver
if convergence is not achieved within the maximum number of iterations.

Sometimes, particularly running in parallel, PBiCG fails to converge or diverges
without warning or obvious cause leaving a solution field containing significant
errors which can cause divergence of the application.  PBiCGStab is more robust
and does not suffer from the problems encountered with PBiCG.
2017-02-03 21:53:53 +00:00
Henry Weller
a1a70270f0 functionObjects::streamLine,wallBoundedStreamLine: Removed outdated check for 'UName'
Patch contributed by Bruno Santos
Resolves patch request https://bugs.openfoam.org/view.php?id=2444
2017-01-28 18:05:41 +00:00
Henry Weller
54efb46f26 codedFunctionObject: Updated documentation
Patch contributed by Bruno Santos
Resolves bug-report https://bugs.openfoam.org/view.php?id=2441
2017-01-28 18:05:11 +00:00
Henry Weller
8ff56d46b9 meshSearch: Add support for cell decomposition mode CELL_TETS
Resolves bug-report https://bugs.openfoam.org/view.php?id=2428
2017-01-20 10:44:51 +00:00
Henry Weller
100d9a9dd1 eConstThermo: Corrected entropy function
Resolves bug-report https://bugs.openfoam.org/view.php?id=2436
2017-01-18 10:14:07 +00:00
Henry Weller
a8ccb13d48 Documentation updates
Patch contributed by Bruno Santos
Resolves patch request https://bugs.openfoam.org/view.php?id=2409
2016-12-27 15:10:04 +00:00
Henry Weller
a7c2bd6cac functionObjects::volRegion: Improved parallel efficiency
Patch contributed by Kevin Nordin-Bates
Resolves bug-report https://bugs.openfoam.org/view.php?id=2401
2016-12-19 16:18:34 +00:00
Henry Weller
fb57ecbfdf functionObjects::forceCoeffs: Corrected setting of rhoRef for compressible flow
Resolves bug-report https://bugs.openfoam.org/view.php?id=2387
2016-12-14 10:42:49 +00:00
Henry Weller
3d754f4a12 PBiCGStab: Corrected to support processorAgglomerator
Patch contributed by Battijs Janssens
Resolves bug-report http://bugs.openfoam.org/view.php?id=2383
2016-12-09 17:00:50 +00:00
Henry Weller
7209ceb306 metisDecomp: Corrected return from metisDecomp::decompose
Resolves bug-report http://bugs.openfoam.org/view.php?id=2370
2016-12-03 19:27:24 +00:00
Henry Weller
daa4d54a49 processorMeshes::read destruct before de-register
Patch contributed by Mattijs Janssens
Resolves bug-report http://bugs.openfoam.org/view.php?id=2368
2016-12-01 22:06:35 +00:00
Henry Weller
0b3c8e6fb4 meshToMesh0: fixed segmentation fault
Patch contributed by Mattijs Janssens
Resolves bug-report http://bugs.openfoam.org/view.php?id=2363
2016-12-01 19:57:00 +00:00
Henry Weller
0e18bbaa12 functionObjects::grad: Avoid cache conflict with 'postProcess' utility
Resolves bug-report http://bugs.openfoam.org/view.php?id=2350
2016-12-01 15:53:38 +00:00
Henry Weller
422f1770e0 tensor::eigenValues: Test the magnitude of 'QQ' before dividing by it.
Resolves bug-report http://bugs.openfoam.org/view.php?id=2351
2016-11-26 20:53:19 +00:00
Henry Weller
fcb789a267 functionObject.H: Updated documentation
Patch contributed by Bruno Santos
Resolves patch request http://bugs.openfoam.org/view.php?id=2355
2016-11-26 19:47:45 +00:00
Henry Weller
769940a61b functionObjects::yPlus: Removed the AUTO_WRITE option on yPlus
Writing is controlled directly by the functionObject
2016-11-26 17:35:17 +00:00
Henry Weller
35f4d2da07 functionObjects::fieldExpression: Correct and improve warning messages
postProcess -func MachNo

previously generated the warning

Executing functionObjects
--> FOAM Warning :     functionObjects::MachNo MachNo cannot find required field U

which is incorrect; the field 'U' is available but the
thermophysicalProperties is not.  Now 'postProcess' generates the
warning:

Executing functionObjects
--> FOAM Warning :     functionObjects::MachNo MachNo cannot find required object thermophysicalProperties of type fluidThermo
--> FOAM Warning :     functionObjects::MachNo MachNo failed to execute.

Resolves bug-report http://bugs.openfoam.org/view.php?id=2352
2016-11-25 21:49:56 +00:00
Henry Weller
acc2a7707e functionObjects::yPlus: Call read() in constructor to set base-class controls
Patch contributed by Bruno Santos
Resolves bug-report http://bugs.openfoam.org/view.php?id=2320
2016-11-06 10:33:18 +00:00
Henry Weller
c4b8d5e443 kOmegaSSTBase: Corrected read() to re-read the base-class settings
Patch contributed by Bruno Santos
Resolves bug-report http://bugs.openfoam.org/view.php?id=2318
2016-11-05 23:27:19 +00:00
Henry Weller
61195404f7 Cloud: Added 'td.switchProcessor' check to processor transfer logic
Patch contributed by Bruno Santos
Resolves bug-report http://bugs.openfoam.org/view.php?id=2315
2016-11-05 21:20:18 +00:00
Henry Weller
d23f7d0fd1 movingWallVelocityFvPatchVectorField: Removed incorrect documentation concerning MRF
Resolves bug-report http://bugs.openfoam.org/view.php?id=2287
2016-10-07 17:39:30 +01:00
Henry Weller
7dce08191e fvOptions: Corrected docs: 'fieldName' -> 'fields'
Resolves bug-report http://bugs.openfoam.org/view.php?id=2273
2016-09-28 19:40:47 +01:00
Henry Weller
7dbca43064 PatchToPatchInterpolate: Update to use the tmp ref() non-const access function
Resolves bug-report http://bugs.openfoam.org/view.php?id=2248
2016-09-16 14:48:31 +01:00
Henry Weller
de29a3309e rigidBodyMotion: Change the transform averaging to use approximate inverse-distance weighting
Now works correctly for an arbitrary number of bodies
Resolves bug-report http://bugs.openfoam.org/view.php?id=2211
2016-09-15 14:36:20 +01:00
Henry Weller
1ca4bbf1d2 PBiCGStab: New preconditioned bi-conjugate gradient stabilized solver for asymmetric lduMatrices
using a run-time selectable preconditioner

References:
    Van der Vorst, H. A. (1992).
    Bi-CGSTAB: A fast and smoothly converging variant of Bi-CG
    for the solution of nonsymmetric linear systems.
    SIAM Journal on scientific and Statistical Computing, 13(2), 631-644.

    Barrett, R., Berry, M. W., Chan, T. F., Demmel, J., Donato, J.,
    Dongarra, J., Eijkhout, V., Pozo, R., Romine, C. & Van der Vorst, H.
    (1994).
    Templates for the solution of linear systems:
    building blocks for iterative methods
    (Vol. 43). Siam.

See also: https://en.wikipedia.org/wiki/Biconjugate_gradient_stabilized_method

Tests have shown that PBiCGStab with the DILU preconditioner is more
robust, reliable and shows faster convergence (~2x) than PBiCG with
DILU, in particular in parallel where PBiCG occasionally diverges.
2016-09-12 15:19:24 +01:00
Henry Weller
168b29e2cf functionObjectList::readFunctionObject: Added support for region specification
Now the postProcess utility '-region' option works correctly, e.g. for
the chtMultiRegionSimpleFoam/heatExchanger case

postProcess -region air -func "mag(U)"

calculates 'mag(U)' for all the time steps in region 'air'.
2016-09-09 11:24:12 +01:00