Commit graph

604 commits

Author SHA1 Message Date
Henry Weller
5841ee3481 Revert "meshRefinementBaffles: Correct faceZone orientation"
This reverts commit 6206280471.
2015-11-08 22:20:11 +00:00
Henry Weller
29111c3723 fvcAverage: Minor improvement to the evaluation of the internalField 2015-11-08 12:25:30 +00:00
Henry Weller
d5b4448e1a src/OpenFOAM: Update ...ErrorIn -> ...ErrorInFunction
Avoids the clutter and maintenance effort associated with providing the
function signature string.
2015-11-08 12:23:52 +00:00
Henry Weller
d46bbbf440 sutherlandTransport: Add support for reading thermo and transport from separate dictionaries
Based on patch provided by Daniel Jasinski
See http://www.openfoam.org/mantisbt/view.php?id=1888
2015-11-06 17:36:58 +00:00
Henry Weller
6206280471 meshRefinementBaffles: Correct faceZone orientation
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1479
Patches provided by Bruno Santos based on the work of Mattijs Janssens
2015-11-04 11:53:54 +00:00
Henry Weller
03494fef5d Updated notImplemented -> NotImplemented
The new NotImplemented macro uses __PRETTY_FUNCTION__ for GNU compatible
compilers otherwise __func__ to provide the function name string.
2015-11-01 10:26:37 +00:00
Henry Weller
dfecb23b08 equationOfState/Boussinesq: New equation of state for the Boussinesq approximation for buoyant flows
Description
    Incompressible gas equation of state using the Boussinesq approximation for
    the density as a function of temperature only:

    \verbatim
        rho = rho0*(1 - beta*(T - T0))
    \endverbatim

To be used with the buoyantPimpleFoam and buoyantSimpleFoam solvers as
an alternative to using buoyantBoussinesqPimpleFoam or
buoyantBoussinesqSimpleFoam, providing consistency with all other
solvers and utilities using the thermodynamics package in OpenFOAM.
2015-10-31 18:27:38 +00:00
Henry Weller
678a7a5202 Updated headers 2015-10-30 21:37:59 +00:00
Henry Weller
1e4a07c714 Updated docs for Doxygen: '<' -> '\<' and '>' -> '\>' 2015-10-30 21:37:03 +00:00
Henry Weller
ff10fe0d5e messageStream, error: Add new versions of message and error macros
which use the __PRETTY_FUNCTION__ constant string to provide the function name
2015-10-30 17:30:26 +00:00
Henry Weller
941117a1c4 createIncompressibleRadiationModel: Allow specification of value only for rhoRef and CpRef
Patch provided by Daniel Jasinski: http://www.openfoam.org/mantisbt/view.php?id=1856
2015-10-30 14:01:20 +00:00
Henry Weller
d3621371e0 TurbulenceModels: Corrected docs
Reported in http://www.openfoam.org/mantisbt/view.php?id=1856
2015-10-30 13:28:28 +00:00
Henry Weller
b5f64cd165 radiationCoupledBase: Correct docs 2015-10-29 22:42:14 +00:00
Henry Weller
f623ba2542 Make Doxygen documentation consistent with the rest of OpenFOAM 2015-10-29 22:40:41 +00:00
Henry Weller
15d700a966 porousBafflePressureFvPatchField: Corrected docs
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1884
2015-10-29 14:05:55 +00:00
Henry Weller
866ec7d5cf PrimitivePatchCheck::checkTopology: Correct non-manifold check logic
Patch provided by Aron Jóhannesson
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1877
2015-10-29 10:54:47 +00:00
Henry Weller
63c620dc68 temperatureCoupledBase, turbulentHeatFluxTemperatureFvPatchScalarField: updated docs
Provided by Bruno Santos
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1875
2015-10-25 17:08:29 +00:00
Henry Weller
f52fb042b8 turbulentHeatFluxTemperatureFvPatchScalarField: Updated docs
Resolves report http://www.openfoam.org/mantisbt/view.php?id=1875
Patch provided by Bruno Santos
2015-10-25 15:31:49 +00:00
Henry Weller
cbd3f823e5 cyclicACMIPolyPatch: remove tolerance from the ACMI interpolation
Maybe resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1335
awaiting feedback from reporter.
2015-10-24 21:39:10 +01:00
Henry Weller
7595f4c225 cyclicAMIPolyPatch: corrected rotationAngle signs in parallel decomposition of cyclicAMI
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1726
2015-10-23 08:31:11 +01:00
Henry Weller
1fb1af5e87 reactingEulerFoam: Updated handling of thermal diffusivity to support Prandtl number and thermal wall-functions 2015-10-22 22:44:59 +01:00
Henry Weller
c9e4d5c135 cyclicAMIPolyPatch, cyclicACMIPolyPatch: Ensure geometry is updated correctly following mesh-motion
Resolves bug-report: http://www.openfoam.org/mantisbt/view.php?id=1664
2015-10-22 09:48:40 +01:00
Henry Weller
e64a8929a6 polyMesh: Ensure parallel consistency in findCell
by ensuring tetBasePtIs is called on all processors, even for those with
0 cells.  Also use unique communicator for globalMeshData to avoid data
transfer interference.

Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1792
2015-10-21 12:47:02 +01:00
Henry Weller
2c46bf1554 polyMesh: Correct CELL_TETS mode in findCell
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1792
2015-10-19 16:59:19 +01:00
Henry Weller
95c4f934db sixDoFSolver: Run-time selectable solver (integrator) for sixDoFRigidBodyMotion
The built-in explicit symplectic integrator has been replaced by a
general framework supporting run-time selectable integrators.  Currently
the explicit symplectic, implicit Crank-Nicolson and implicit Newmark
methods are provided, all of which are 2nd-order in time:

Symplectic 2nd-order explicit time-integrator for 6DoF solid-body motion:

    Reference:
        Dullweber, A., Leimkuhler, B., & McLachlan, R. (1997).
        Symplectic splitting methods for rigid body molecular dynamics.
        The Journal of chemical physics, 107(15), 5840-5851.

    Can only be used for explicit integration of the motion of the body,
    i.e. may only be called once per time-step, no outer-correctors may be
    applied.  For implicit integration with outer-correctors choose either
    CrankNicolson or Newmark schemes.

    Example specification in dynamicMeshDict:
    solver
    {
        type    symplectic;
    }

Newmark 2nd-order time-integrator for 6DoF solid-body motion:

    Reference:
        Newmark, N. M. (1959).
        A method of computation for structural dynamics.
        Journal of the Engineering Mechanics Division, 85(3), 67-94.

    Example specification in dynamicMeshDict:
    solver
    {
        type    Newmark;
        gamma   0.5;    // Velocity integration coefficient
        beta    0.25;   // Position integration coefficient
    }

Crank-Nicolson 2nd-order time-integrator for 6DoF solid-body motion:

    The off-centering coefficients for acceleration (velocity integration) and
    velocity (position/orientation integration) may be specified but default
    values of 0.5 for each are used if they are not specified.  With the default
    off-centering this scheme is equivalent to the Newmark scheme with default
    coefficients.

    Example specification in dynamicMeshDict:
    solver
    {
        type    CrankNicolson;
        aoc     0.5;    // Acceleration off-centering coefficient
        voc     0.5;    // Velocity off-centering coefficient
    }

Both the Newmark and Crank-Nicolson are proving more robust and reliable
than the symplectic method for solving complex coupled problems and the
tutorial cases have been updated to utilize this.

In this new framework it would be straight forward to add other methods
should the need arise.

Henry G. Weller
CFD Direct
2015-10-19 14:03:46 +01:00
Henry Weller
f0e866e874 functionObjects/utilities/turbulenceFields/turbulenceFields: Added k and epsilon
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1870
2015-10-17 15:20:10 +01:00
Henry Weller
033e73e3f9 prghTotalPressureFvPatchScalarField: Total pressure BC for p_rgh
Resolves some stability issues with the outlet of multiphase problems.
2015-10-14 13:15:17 +01:00
Henry Weller
0e5596879e uniformFixedValueFvPatchField: Remove the inconsistent optional "value"
read in the construction from dictionary.

It is important that the initial value is obtained from the table
provided to avoid the user having to evaluate a consistent one or risk
the code crashing from a very sudden change in the value.
2015-10-13 22:28:26 +01:00
Henry Weller
6c0384da15 Update header 2015-10-12 21:33:56 +01:00
Henry Weller
57c32b0503 sixDoFRigidBodyMotion: Time integration now switches between symplectic and Crank-Nicolson
For explicit motion (and the first iteration of iterative motion
correction) the 2nd-order symplectic motion integrator is used.

For iterative correction a form of lagged Crank-Nicolson is used in
which the current time-step values correspond to the current iteration.
This converges to a 2nd-order implicit solution.
2015-10-12 21:27:42 +01:00
Henry Weller
f4b648e1cb fvSchemes: setFluxRequired now adds entry quietly 2015-10-12 21:26:40 +01:00
Henry Weller
a1550cba22 dimensionedType: rationalize lookupOrDefault and lookupOrAddToDict
Now consistent with constructors.
2015-10-01 17:29:29 +01:00
Henry Weller
a684e7308e surfaceFilmModels/submodels/thermo/phaseChangeModel/solidification: Corrected and improved solidification rate controls
Solidification phase change model where all film mass is converted when the
    local temperature > activation temperature.  The latent heat is
    assumed to be removed by heat-transfer to the wall.
2015-09-30 18:18:20 +01:00
Henry Weller
fb3eddd2cb patchInjection: Check for 0-patches 2015-09-30 18:17:32 +01:00
Henry Weller
df85b892a5 dimensionedType: Corrected order of dimensions and value in lookupOrDefault and lookupOrAddToDict
Deprecated old versions.
2015-09-30 18:16:12 +01:00
Henry Weller
289d67f825 Removed unnecessary "else if" conditions
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1858
2015-09-28 22:18:39 +01:00
Henry Weller
1b42beda24 KinematicLookupTableInjection: Use 64bit integers to avoid overflow for large numbers of injectors. 2015-09-28 14:30:48 +01:00
Henry Weller
3487bd4991 reactingTwoPhaseEulerFoam: alphatFixedDmdtWallBoilingWallFunction: new BC to test wall boiling 2015-09-25 17:52:51 +01:00
Henry Weller
84b4dae80d solidBodyMotionFvMesh: Fixed typo
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1854
2015-09-23 15:55:54 +01:00
Henry Weller
9f666b0dbd pairPatchAgglomeration: Added call to compactLevels at the end of agglomerate
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1853
2015-09-17 17:05:12 +01:00
Henry Weller
711452d46c PtrListDictionary: New form of Dictionary in which the list type is PtrList rather than a linked-list 2015-09-16 21:26:26 +01:00
Henry Weller
57e98f135e PtrList: Added const_iterator 2015-09-16 21:25:09 +01:00
Henry Weller
511489a40b globalMeshData: Changed the communicator for the reductions
Avoids problems with overlapping communicationbetween these reductions
and the calculation of deltaCoeffs.  This is a temporary fix while code
reorganizations are undertaken to ensure the globalMeshData is updated
before deltaCoeffs are requested.

Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1780
2015-09-13 22:21:53 +01:00
Henry Weller
13d35c5810 Updated headers 2015-09-02 15:33:16 +01:00
Henry Weller
f00623d40a chemkinReader: Add tolerance to element balance check
Patch provided by Daniel Jasinski
Resolved bug-report http://www.openfoam.org/mantisbt/view.php?id=1843
2015-09-02 15:32:16 +01:00
Henry Weller
b0eda7bc4e Updated headers 2015-09-02 15:30:10 +01:00
Henry Weller
689b0a00fc Added ROOTSMALL 2015-09-02 15:29:54 +01:00
Henry Weller
e907574c72 blockMesh: Avoid test failure for lambda == 1 2015-08-28 20:26:23 +01:00
Henry Weller
2d35c2638a reactingEulerFoam/phaseSystem: Create an ordered container for phaseModels
The previous method using a HashTable required a separate ordered list
of names which is hard to work with and maintain.
2015-08-28 18:40:22 +01:00
Henry Weller
0f3186fd21 blockMeshMergeFast: Added more diagnostics 2015-08-28 18:39:50 +01:00