Commit graph

107 commits

Author SHA1 Message Date
Henry Weller
efa28279b8 fvPatchFields, fvsPatchFields, pointPatchFields: specifically declare namespace of functions
It is better to declare the namespace of each function in the C file
rather than "open" the namespace as this may lead to inconsistencies
between the declaration in the H files and definition in the C file.
2015-12-08 22:29:05 +00:00
Henry Weller
b4d7adcb01 Minor updates to aid porting to FreeBSD
Based on patches provided by Jason Bacon
2015-12-02 18:18:06 +00:00
Henry Weller
016aad0d72 functionObjects: Format time according to the specification in controlDict
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1921
2015-11-20 13:22:51 +00:00
Henry Weller
5e6a7ea282 Completed update ...ErrorIn -> ...ErrorInFunction
Avoids the clutter and maintenance effort associated with providing the
function signature string.
2015-11-11 09:03:39 +00:00
Henry Weller
cc99b65d77 src/OpenFOAM: Update ...IOErrorIn -> ...IOErrorInFunction
Avoids the clutter and maintenance effort associated with providing the
function signature string.
2015-11-10 21:13:04 +00:00
Henry Weller
1944b09bb5 SolverPerformance: Complete the integration of the templated SolverPerformance<Type>
Now solvers return solver performance information for all components
with backward compatibility provided by the "max" function which created
the scalar solverPerformance from the maximum component residuals from
the SolverPerformance<Type>.

The residuals functionObject has been upgraded to support
SolverPerformance<Type> so that now the initial residuals for all
(valid) components are tabulated, e.g. for the cavity tutorial case the
residuals for p, Ux and Uy are listed vs time.

Currently the residualControl option of pimpleControl and simpleControl
is supported in backward compatibility mode (only the maximum component
residual is considered) but in the future this will be upgraded to
support convergence control for the components individually.

This development started from patches provided by Bruno Santos, See
http://www.openfoam.org/mantisbt/view.php?id=1824
2015-11-10 08:50:11 +00:00
Henry Weller
d5b4448e1a src/OpenFOAM: Update ...ErrorIn -> ...ErrorInFunction
Avoids the clutter and maintenance effort associated with providing the
function signature string.
2015-11-08 12:23:52 +00:00
Henry Weller
03494fef5d Updated notImplemented -> NotImplemented
The new NotImplemented macro uses __PRETTY_FUNCTION__ for GNU compatible
compilers otherwise __func__ to provide the function name string.
2015-11-01 10:26:37 +00:00
Henry Weller
ff10fe0d5e messageStream, error: Add new versions of message and error macros
which use the __PRETTY_FUNCTION__ constant string to provide the function name
2015-10-30 17:30:26 +00:00
Henry Weller
f623ba2542 Make Doxygen documentation consistent with the rest of OpenFOAM 2015-10-29 22:40:41 +00:00
Henry Weller
866ec7d5cf PrimitivePatchCheck::checkTopology: Correct non-manifold check logic
Patch provided by Aron Jóhannesson
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1877
2015-10-29 10:54:47 +00:00
Henry Weller
e64a8929a6 polyMesh: Ensure parallel consistency in findCell
by ensuring tetBasePtIs is called on all processors, even for those with
0 cells.  Also use unique communicator for globalMeshData to avoid data
transfer interference.

Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1792
2015-10-21 12:47:02 +01:00
Henry Weller
2c46bf1554 polyMesh: Correct CELL_TETS mode in findCell
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1792
2015-10-19 16:59:19 +01:00
Henry Weller
a1550cba22 dimensionedType: rationalize lookupOrDefault and lookupOrAddToDict
Now consistent with constructors.
2015-10-01 17:29:29 +01:00
Henry Weller
df85b892a5 dimensionedType: Corrected order of dimensions and value in lookupOrDefault and lookupOrAddToDict
Deprecated old versions.
2015-09-30 18:16:12 +01:00
Henry Weller
711452d46c PtrListDictionary: New form of Dictionary in which the list type is PtrList rather than a linked-list 2015-09-16 21:26:26 +01:00
Henry Weller
57e98f135e PtrList: Added const_iterator 2015-09-16 21:25:09 +01:00
Henry Weller
511489a40b globalMeshData: Changed the communicator for the reductions
Avoids problems with overlapping communicationbetween these reductions
and the calculation of deltaCoeffs.  This is a temporary fix while code
reorganizations are undertaken to ensure the globalMeshData is updated
before deltaCoeffs are requested.

Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1780
2015-09-13 22:21:53 +01:00
Henry Weller
b0eda7bc4e Updated headers 2015-09-02 15:30:10 +01:00
Henry Weller
689b0a00fc Added ROOTSMALL 2015-09-02 15:29:54 +01:00
Henry Weller
2d35c2638a reactingEulerFoam/phaseSystem: Create an ordered container for phaseModels
The previous method using a HashTable required a separate ordered list
of names which is hard to work with and maintain.
2015-08-28 18:40:22 +01:00
Henry Weller
2828d82cba utilities/postProcessing/noise: Corrected documentation
Patches provided by Bruno Santos
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1832
2015-08-19 11:37:27 +01:00
Henry Weller
36b1c587a8 face: Add handling for duplicate vertices in sameVertices
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1821
2015-08-10 10:01:36 +01:00
Henry Weller
23f4ce9871 polyMeshFromShapeMesh: Set patch-face to corresponding cell-face
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1818
2015-08-08 14:30:06 +01:00
Henry Weller
44e7fc454d ints: Add support for mag(int32_t) and mag(int64_t)
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1817
2015-08-07 15:52:22 +01:00
Henry Weller
9a32ae3754 Rename circulators to be consistent with the standard OpenFOAM class naming convention 2015-08-06 16:54:47 +01:00
Henry Weller
28955589d2 polyMeshFromShapeMesh: Change patch face matching to be vertex ordering independent
This simplifies the specification of patch faces in blockMeshDict which
now do need not have any particular ordering of the block vertices.
2015-08-06 16:51:56 +01:00
Henry Weller
fdd1beccf4 functionObjectFile: Use wordList rather than wordHashSet to maintain order
Change based on patch provided by Hassan Kassem
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1796
2015-08-05 17:38:31 +01:00
Henry Weller
00b6400860 Removed trailing whitespace
Resolves bug-report http://openfoam.org/mantisbt/view.php?id=1805
2015-08-01 15:43:05 +01:00
Henry Weller
40ae36b5f6 dimensioned<Type>: Added constructor from name, dimensions and dictionary
to simplify construction of dimensionedScalar properties and avoid the
duplication of the name string in the constructor call.
2015-07-21 12:57:07 +01:00
Henry Weller
ecee2d275e Input of dimensionedScalars: update read-construction of dimensionedScalar in applications
so that the specification of the name and dimensions are optional in property dictionaries.

Update tutorials so that the name of the dimensionedScalar property is
no longer duplicated but optional dimensions are still provided and are
checked on read.
2015-07-20 22:52:53 +01:00
Henry Weller
36ae54f803 Resolve various unimportant warning messages from Gcc, Clang and Icpc 2015-07-19 11:31:49 +01:00
Henry Weller
d6e6e2bf70 Remove unnecessary use of keyword "explicit" 2015-07-17 18:26:58 +01:00
Henry Weller
e6e7820ae5 Upgrade Intel C++ compiler to icpc (ICC) 15.0.3 20150407
This resolves a whole range of issues and work-arounds with earlier
releases.  This version of icpc is more or less compatible with the
latest gcc and clang compilers and only required one hack to avoid
warnings from PackedBoolList.H.
2015-07-17 16:50:40 +01:00
Henry Weller
feebe8d30a OpenFOAM/primitives/functions/DataEntry/Table: Removed unnecessary multiple inheritance
This resolves issues with and complexities in the virtual function inheritance
2015-07-17 16:48:35 +01:00
Henry Weller
77bf182edc Resolved issues with virtual function inheritance and warning from clang
Also removed __GNUC__ conditional compilation statements which are no
longer needed.
2015-07-17 12:11:37 +01:00
Henry Weller
8e7c777ec5 UList::swap: implemented fast version which swaps the size and storage pointer 2015-07-16 11:52:11 +01:00
Henry Weller
9f58f7ede4 filmViscosityModel/constantViscosity/constantViscosity: Add dimensions to mu0 2015-07-16 10:54:23 +01:00
Henry Weller
3599b8918b UList, FixedList: Correct swap member function
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1787
2015-07-15 12:10:05 +01:00
Henry Weller
43030b7fbc src/OpenFOAM: Added posPart and negPart functions
posPart returns a value or field in which the value or values are set to
0 if negative

negPart returns a value or field in which the value or values are set to
0 if positive
2015-07-03 18:02:24 +01:00
Henry Weller
0d024dd37d Removed use of the deprecated "register" keyword
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4340.html
2015-06-30 10:26:44 +01:00
Henry Weller
0b5082b8c7 Correct typo 2015-06-24 10:06:56 +01:00
Henry Weller
97b0882ef4 timeSelector: Add support for -newTimes option
//- Return the set of times selected based on the argList options
    //  including support for \b -newTimes in which times are selected
    //  if the file <fName> does not exist in the time directory.
    //  Also set the runTime to the first instance or the
    //  \c constant/ directory if no instances are specified or available
    static instantList select
    (
        Time& runTime,
        const argList& args,
        const word& fName
    );

This is experimental functionality and currently on test in the yPlus
post-processing utility.
2015-06-24 10:04:29 +01:00
Henry
34e062daab polyMesh::findCell: Call tetBasePtIs for CELL_TETS to ensure parallel consistency
Resolves additional bug-report http://www.openfoam.org/mantisbt/view.php?id=1544
2015-06-11 17:45:25 +01:00
Henry
1a3ef4d827 IOobject: Added member function "member()" which returns the member name of the object
i.e. without the group suffix.

Patch provided by William Bainbridge
2015-06-04 17:09:42 +01:00
Henry
54af0e3359 Time: Correct precision adjustment for user-time 2015-05-20 12:43:54 +01:00
Henry
d9090fcf42 messageStream: Remove confusing argument-based conditional output
This had been used in functionObjects:

    Info(log)<< "messages" << data << ....

in which it is not at all clear what the "log" argument does whereas

    if (log) Info<< "messages" << data << ....

is totally clear and more efficient.
2015-05-18 11:54:56 +01:00
Henry
372dc26c8d int32: Add IO operators for long on 32bit OS
On 32bit OSs long is not unambiguously int32_t (or int64_t) causing
problems for IO operator resolution.  This problem is avoided by
explicitly defining the following operators:
2015-05-16 15:29:34 +01:00
Henry
c9d9ba0b6c surfaceFilmModels: Replaced removeInjection with patchInjection
patchInjection accumulates mass exchanges on a per-patch basis which are
reported by injectionModelList
2015-05-08 16:40:03 +01:00
Henry
767e1a4e69 GAMG solver: Set the following defaults:
cacheAgglomeration true;
    agglomerator    faceAreaPair;
    nCellsInCoarsestLevel 10;
    mergeLevels     1;
2015-05-03 18:11:25 +01:00