From 8b7440a2fdf07f9af39497f985920f350468f65a Mon Sep 17 00:00:00 2001 From: william Date: Thu, 3 Apr 2014 10:58:48 +0100 Subject: [PATCH 1/2] BUG: fixed definition of lagrangian dense drag models to account for pressure gradient --- .../Drag/ErgunWenYuDrag/ErgunWenYuDragForce.C | 6 +++--- .../Drag/PlessisMasliyahDrag/PlessisMasliyahDragForce.C | 4 ++-- .../ParticleForces/Drag/WenYuDrag/WenYuDragForce.C | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/ErgunWenYuDrag/ErgunWenYuDragForce.C b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/ErgunWenYuDrag/ErgunWenYuDragForce.C index ae26d505..a18ffbec 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/ErgunWenYuDrag/ErgunWenYuDragForce.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/ErgunWenYuDrag/ErgunWenYuDragForce.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2013 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2013-2014 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -110,7 +110,7 @@ Foam::forceSuSp Foam::ErgunWenYuDragForce::calcCoupled ( vector::zero, (mass/p.rho()) - *(150.0*(1.0 - alphac) + 1.75*Re)*muc/(alphac*sqr(p.d())) + *(150.0*(1.0 - alphac)/alphac + 1.75*Re)*muc/(alphac*sqr(p.d())) ); } else @@ -119,7 +119,7 @@ Foam::forceSuSp Foam::ErgunWenYuDragForce::calcCoupled ( vector::zero, (mass/p.rho()) - *0.75*CdRe(alphac*Re)*muc*pow(alphac, -2.65)/sqr(p.d()) + *0.75*CdRe(alphac*Re)*muc*pow(alphac, -2.65)/(alphac*sqr(p.d())) ); } } diff --git a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/PlessisMasliyahDrag/PlessisMasliyahDragForce.C b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/PlessisMasliyahDrag/PlessisMasliyahDragForce.C index 1b7dee57..970dee90 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/PlessisMasliyahDrag/PlessisMasliyahDragForce.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/PlessisMasliyahDrag/PlessisMasliyahDragForce.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2013 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2013-2014 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -123,7 +123,7 @@ Foam::forceSuSp Foam::PlessisMasliyahDragForce::calcCoupled ( vector::zero, (mass/p.rho()) - *(A*(1.0 - alphac) + B*Re)*muc/(alphac*sqr(p.d())) + *(A*(1.0 - alphac)/alphac + B*Re)*muc/(alphac*sqr(p.d())) ); } diff --git a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/WenYuDrag/WenYuDragForce.C b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/WenYuDrag/WenYuDragForce.C index 415bd06b..57356aa1 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/WenYuDrag/WenYuDragForce.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/WenYuDrag/WenYuDragForce.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2013 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2013-2014 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -105,7 +105,7 @@ Foam::forceSuSp Foam::WenYuDragForce::calcCoupled ( vector::zero, (mass/p.rho()) - *0.75*CdRe(alphac*Re)*muc*pow(alphac, -2.65)/sqr(p.d()) + *0.75*CdRe(alphac*Re)*muc*pow(alphac, -2.65)/(alphac*sqr(p.d())) ); } From 13b2ff2be961fd0a730ec3a7f33083f1d2e0db56 Mon Sep 17 00:00:00 2001 From: william Date: Fri, 4 Apr 2014 09:27:02 +0100 Subject: [PATCH 2/2] BUG: divergence in cyclone tutorial fixed by turning off cellValueSourceCorrection --- .../MPPICFoam/cyclone/constant/kinematicCloudProperties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorials/lagrangian/MPPICFoam/cyclone/constant/kinematicCloudProperties b/tutorials/lagrangian/MPPICFoam/cyclone/constant/kinematicCloudProperties index c0341ddd..d87d0dbf 100644 --- a/tutorials/lagrangian/MPPICFoam/cyclone/constant/kinematicCloudProperties +++ b/tutorials/lagrangian/MPPICFoam/cyclone/constant/kinematicCloudProperties @@ -20,7 +20,7 @@ solution active true; coupled true; transient yes; - cellValueSourceCorrection on; + cellValueSourceCorrection off; maxCo 1.0;